IronPort-SDR: xw72zawMbrjhpLX6vr0whCXdh/U3N16Oey1brVEYT9kTvjcNfYn5y+Kj3u+BtWkkiRr/eDdLo7
 svoo2ou2MVZrvu/rerouXWD8H73I3/z0Pjn9YVFPxjAHRMso9wujcLwNQXofE9HE9aO/EJjD/W
 wOXeXuf0N4BqMr3Ugae026LoOGa6ObONzRZLh5QcpCwzbCoe/g0xLwnJRp/NZMpkuHDB32hcPZ
 Uq/5SLxK7kSZdQ88H8BBqkJdTbm7hNcBI6PIxbvIEoPveMi6iVoQtxfwiU3fvaofvliCCR5sPH
 V9MC7xcRZqbSq1l5kLub8Hg1
Date:   Fri, 26 Nov 2021 10:12:21 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     <davem@davemloft.net>, <kuba@kernel.org>, <robh+dt@kernel.org>,
        <UNGLinuxDriver@microchip.com>, <p.zabel@pengutronix.de>,
        <linux@armlinux.org.uk>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 3/6] net: lan966x: add port module support
Message-ID: <20211126091221.tzrqsgawavlzitp5@soft-dev3-1.localhost>
References: <20211123135517.4037557-1-horatiu.vultur@microchip.com>
 <20211123135517.4037557-4-horatiu.vultur@microchip.com>
 <YZ59hpDWjNjvx5kP@lunn.ch>
 <20211125092638.7b2u75zdv2ulekmo@soft-dev3-1.localhost>
 <YZ+kvpCmWomKNr9l@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <YZ+kvpCmWomKNr9l@lunn.ch>
Precedence: bulk

The 11/25/2021 15:59, Andrew Lunn wrote:

Hi Andrew,

> 
> > If I undestood you correctly I have tried to do the following:
> >
> > struct lan966x_ifh {
> >     __be32 timestamp;
> >     __be32 bypass : 1;
> >     __be32 port : 3;
> >     ...
> > };
> >
> > But then I start to get errors from sparse:
> >
> > error: invalid bitfield specifier for type restricted __be32.
> 
> Maybe look at struct iphdr. It has bitfields for the header length and
> the IP version.

I think it would get pretty messy to add all these defines in the
lan966x_ifh struct. One reason is that the IFH contains 38 fields.

I have send another version(v4) where I think I have simplified it a little
bit more. If you think is still not clear enough, I will try again the
approach that you proposed.

> 
>     Andrew

-- 
/Horatiu