Date:   Fri, 26 Nov 2021 17:44:06 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Giovanni Gherdovich <ggherdovich@suse.cz>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Borislav Petkov <bp@suse.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        Steven Noonan <steven@valvesoftware.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v4 06/22] cpufreq: amd: introduce a new amd pstate driver
 to support future processors
Message-ID: <YaCsZqIl4+Dbefg7@amd.com>
References: <20211119103102.88124-1-ray.huang@amd.com>
 <20211119103102.88124-7-ray.huang@amd.com>
 <dbb61b3a2602150aa091d3b456c1866a580e3c53.camel@suse.cz>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dbb61b3a2602150aa091d3b456c1866a580e3c53.camel@suse.cz>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JjW4SZ165jTnY/LBoqQSZ82jeXis4toQZcCMBo/VzHH9fAIv5XrwwAcW2uEy?=
 =?us-ascii?Q?+PFVXNKM47IMHVnEWjaua6caALq1gZqOYlsIIQGp/RUg5exETXJSI5LLASBC?=
 =?us-ascii?Q?kfUvWfND0G830peShAM+DoyhiJ0vOffC9fyHbQOxbjJ2nL/T7AEfJm2VlOGb?=
 =?us-ascii?Q?r4dLS2n8qRlgBM4zpINFVp2bFfBO0GmY0C0fVUvK+v05i1pT3ggfI3iPq8qG?=
 =?us-ascii?Q?vFxufUqWSIGApin2A5VA2Q55sMW9xvfh1gAIgTKS700zgJex2cKcAJ96zMQY?=
 =?us-ascii?Q?wGD0V4KWM8vW8SIexDW2MHWxy1yh7Fi+ewqOxQ5MRkX8sqY9c9HS2MhhMU8W?=
 =?us-ascii?Q?XvKdJGqz+xlrV/3WIev7EUD/QUba6DTlfDTFQjYGDy7dEMZFJB8Xq10xY3jR?=
 =?us-ascii?Q?0HYfRYaK+K0R+74sQI366pKj2h6Bi/qPLrhD26BAXiG4Y7Cc61CuQcYzHFFF?=
 =?us-ascii?Q?TwsSpmOWhqvlCTtAwYXu02lxytgWcqGtUdLbqrwnxdYtU5r49a+B4m5tQGLW?=
 =?us-ascii?Q?00Wyrau7tPLUbzU4PK+4nc210Dv8J6AQeXxsRxdGtk4k8JV3ydqicQ2koBZ5?=
 =?us-ascii?Q?VCRYZ3ukw/3jCHiYiyDI/+pqIAMFXyD7gJMSu4AreBJ+Q8iKlGR7yzRSa8Nu?=
 =?us-ascii?Q?USBhcjktMaDM3sSAmuf9VFIMci+jQB4BcohZGqpJe9R/bLqZ1HVP19rkiv42?=
 =?us-ascii?Q?mIvJ6mEX+jHtwnWhyMm6cSIM8ER8krHgmsFrH9oyF2QMiusUMGLMUx47XTTi?=
 =?us-ascii?Q?8QI97hefohnIDvfiYGb8IRiZ3BulP3F1COS7CfntsqQh+f1GuTAGLhggWcs7?=
 =?us-ascii?Q?xFkaUcqN8C5NbZfvVxNesCVATH3Pja9KsmcIxgm8xdrlT825+3T3CauLUiaw?=
 =?us-ascii?Q?0bbEosEmxgqG5W/AolaqXtENdl/vF80hQMl68dACvQYsPBHGsqRU8hxtAYFE?=
 =?us-ascii?Q?WvlNftBiHaRPv8XnozZJYQxIAJkWRj0C+H2zMHjxJ0fujiWgbFOzeRwc53V9?=
 =?us-ascii?Q?hYTN7Be3CymQ27VklMWpooGltD4CSYE31yw2YzfM8G4+e/oU5B0fW07CmgAD?=
 =?us-ascii?Q?58/Eh8kH4k2tVpRhAM9G61YCBPeaqoUL5fizhwykI/46eFgmiDxhgDXg+ZzD?=
 =?us-ascii?Q?N0rzACBWGNQPiSUXkaTtS1ILLNrudPZv+NI+wshy2yJKcSJ7pJX/q1yq67FT?=
 =?us-ascii?Q?Lyem8amPlP+h2TgfDOfDcCQhoto4ADp5PtjPc9GlONoK5yelWrmCIs+xqTci?=
 =?us-ascii?Q?+E+RZJjkEQUVsQJP+wydiymi6ZzJB4s5BrKL0f/NGzvWjFHsYOE62eNI0HF+?=
 =?us-ascii?Q?fOhrDIaMGI06+y4v3HSsH3RJpRW7A+wHDv8PByQ2X3SJ8lRCroVXfoNlkhyZ?=
 =?us-ascii?Q?gOqoEOKZVweP/O772cKIfYgv1USpw7EZPyZNACDWUYRu/FFTThDDqzPfzAI5?=
 =?us-ascii?Q?sRqeMgBoXY4gfPVQ7lIAi4gUUlaC9DupsdYjSz/+XkgTTrIl7I0KkG+t+arp?=
 =?us-ascii?Q?0VHmyl9XODEqT/aZ3QWtm1mjYa3Agw09FFpVBPzxeNzHa2vUx3v19+y4MWbS?=
 =?us-ascii?Q?jHlvN+LoN60voTGWnyR/he5xJMsC5Tf0Y0Sm0f+WyANmK/qIBXUzJogaTNkr?=
 =?us-ascii?Q?cf5mYM/GIlMW/VbVfwHw/zE=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95dfb4c4-02a6-4e0c-d23e-08d9b0c15b89
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4918.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2021 09:44:36.2602
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ullcQQvGiMYDjgq2EQKEfA14MPrco/u1o8UDstyPAmETaWE7XZMNBmgz/0uSvOKasgYFzZp6zUEvJoxa35KpMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4598
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 25, 2021 at 11:03:58PM +0800, Giovanni Gherdovich wrote:
> On Fri, 2021-11-19 at 18:30 +0800, Huang Rui wrote:
> > <snip>
> >
> > Performance Per Watt (PPW) Calculation:
> > 
> > The PPW calculation is referred by below paper:
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsoftware.intel.com%2Fcontent%2Fdam%2Fdevelop%2Fexternal%2Fus%2Fen%2Fdocuments%2Fperformance-per-what-paper.pdf&amp;data=04%7C01%7Cray.huang%40amd.com%7C65f95f752ce142a5356d08d9b024d0de%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637734494579654964%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=6SzLLzQ1mRlbxdO1skcnrjulOmaqGWCrtDpIZToVjMM%3D&amp;reserved=0
> > 
> > Below formula is referred from below spec to measure the PPW:
> > 
> > (F / t) / P = F * t / (t * E) = F / E,
> > 
> > "F" is the number of frames per second.

This "F" should be the number of frames, not per second.

> > "P" is power measured in watts.
> > "E" is energy measured in joules.
> 
> Hello, I'd appreciate if you can remove the reference to the above paper and
> formula, because it is not really relevant to this context, and ends up being
> confusing.
> 
> It describes performance per watt tailored to graphics benchmarks, in the form
> of frames per joule. Nothing wrong with that, but it only works for tests that
> measure frames per second, and none of the tests below is of that type.

OK, actually, we would test 3D steam game benchmarks as well on our
processors with amd-pstate. :-)

And yes, below three benchmark tests are not related with "frame", but the
"MB" or "runs" of speedometer are actually another meaning of "frame" which
represent the performance data on each benchmark, right. That's is original
reason to put paper and formula here.

If you think it may confuse any guys, I can remove this in next version.

> 
> You have:
> 
> - tbench measures throughput (MB/sec)
> - gitsource, aka run the git test suite, measures elapsed time
> - speedometer, a web browser test that gives "runs per minute"
> 
> If you want performance per watt, you need to express your result as
> "operations per second", where "operations" is up to you to define. For
> tbench, one "operation" is moving a MB of data. For speedometer, one
> "operation" is one "run", as defined in the benchmark. Once you have op/sec
> (aka performance), divide by the average power measured over the entire
> duration of the benchmark.
> 
> In cases like gitsource, where you have elapsed_time as a result, performance
> per watt is 1 / (elapsed_time * average_power).
> 

The "operations" you mentioned here is another meaning of "frames" at the
paper in general. That's actual my previous purpose. :-)

> > We use the RAPL interface with "perf" tool to get the energy data of the
> > package power.
> > 
> > The data comparisons between amd-pstate and acpi-freq module are tested on
> > AMD Cezanne processor:
> > 
> > 1) TBench CPU benchmark:
> > 
> > +---------------------------------------------------------------------+
> > >                                                                     |
> > >               TBench (Performance Per Watt)                         |
> > >                                                    Higher is better |
> > +-------------------+------------------------+------------------------+
> > >                   |  Performance Per Watt  |  Performance Per Watt  |
> > >   Kernel Module   |       (Schedutil)      |       (Ondemand)       |
> > >                   |  Unit: MB / (s * J)    |  Unit: MB / (s * J)    |
> 
> The unit "MB / (s * J)" doesn't really work, it should be "MB / (sec * watt)".
> Can you double check that you divided the performance result by the average
> power? Same for the other tests.
> 
> It is also relevant to show performance, alongside with perf-per-watt.
> 

Aligned with you offline before, we will update the new performance per
watt data here with MB / Joule. Thanks to point it out.

Thanks,
Ray