From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 4/4] drm: rcar-du: mipi-dsi: Support bridge probe ordering
Thread-Topic: [PATCH 4/4] drm: rcar-du: mipi-dsi: Support bridge probe
 ordering
Thread-Index: AQHX4q8a5cXhcQbc30ydYfJwY8HDu6wVoKCA
Date:   Fri, 26 Nov 2021 10:51:48 +0000
Message-ID: <OS0PR01MB5922819388EAA6973EDCD3D386639@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20211126101518.938783-1-kieran.bingham+renesas@ideasonboard.com>
 <20211126101518.938783-5-kieran.bingham+renesas@ideasonboard.com>
In-Reply-To: <20211126101518.938783-5-kieran.bingham+renesas@ideasonboard.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8X5bdT+gB+4XsEguVYy47S1RJ51TEGzgcTssnzzcBzy+gA4kapsyTewcP43N?=
 =?us-ascii?Q?Tk0ddq/p37VbzZ+IT9jo480Xr7u3JfY4o/HzdUWQGdx9JD0S++ahaQ2lklyX?=
 =?us-ascii?Q?H/aSvy2Pl1ZdrMU5bhejzDR+vMBI7QqrynJU5Lgn3BlVNxQ+9Kz+Zq2hwzDk?=
 =?us-ascii?Q?ohu8bhLggHoT4IVM5nRqIqBv740IPHmYpUWtoSiGCo8EX1BkrI997Ji5H6fd?=
 =?us-ascii?Q?Hkh5HOmiDecbLZuS8CjpFUhCD+qV5nq5oZZ/tKJJFmoQO9pXo+5ByFM5yVyT?=
 =?us-ascii?Q?4ESelNK/1vbFCnjNO6ov3/Uj5HooNMlVxpzGRAJ7caqiwDgM/65BYMxPVdip?=
 =?us-ascii?Q?k/cWUtAZxRKpO/huu8DbGo9LT+wh+hiob9H+eIpfAQ8p0jqqrOpo20FEthEx?=
 =?us-ascii?Q?46HfIRSjg4NOZP70YbMke36tjn0O5nBGQecbOE3DCSfXVcSJrf03/G2uG5YB?=
 =?us-ascii?Q?rRW/29czaYGy6qEHEKaBW4LnU2/KRJcT32jyzHWh+VNslnYosSSaWobmUP1p?=
 =?us-ascii?Q?XZrA+0OloGeH8Jh6DmFgYalCkBVt+m/2xs7vB6ubkd5IYa82zVRQhjNvzhpD?=
 =?us-ascii?Q?w7T0c1jMqp3jTysAQCT7R4xAsEX1UUGMFYXoUgxWrpgrSBwIl61b2KOxWy8K?=
 =?us-ascii?Q?MvFeARJi/envvBmXi87NNo+CvczYOF+DbeaGajcUHOqr60u45McpE25Klx9Q?=
 =?us-ascii?Q?MdrjZK9NnXsiaSmXfAkgYB+fKhE83aKfv2ZkhvnUr656AsDo/z5vLxvP11OD?=
 =?us-ascii?Q?UkfrfyVooR6QAj5HvRqH4kN2HndfJyLs/9WCc43e8HP//gp0q3Slk/EOgbjU?=
 =?us-ascii?Q?3tE50RcHlHgdMQAEQ4dwrz1qQz370dFrI3M6fEjmIPA1UGxmxxIfPt1Nwgv/?=
 =?us-ascii?Q?nxPQ5CpHQKkf0zsKdAuq+Vg5IxlrNWrYU87YBi0YS3OW3PS3XLeHP1UtCWLU?=
 =?us-ascii?Q?EZHBA1jamBss8cIT/RhdfZe+j2JTQSPUH+/5hIR5IU/yItFkANz78ToyF/VK?=
 =?us-ascii?Q?IsqxlAFBUvRGydQqSylU4ZX0Wu7UH6L2vj+1jsvpVumyoCCypUaKMui/Apwb?=
 =?us-ascii?Q?Jbzr2vi/2knM0CzWF7TSRrRkQ6WXJ1LycN5FOaTXaJnpYy9OdvevFSQ5VRQA?=
 =?us-ascii?Q?ivkpDiuZwHS5vT8W+NwNSEUoz7mSZeyWrul8LD+3wdoAp9uKJHbov77AXxLb?=
 =?us-ascii?Q?5cU6g832T5bLKzLEKSiJ370o/mk711hGF85asqjKQmIISeQNORSxjZA/si/3?=
 =?us-ascii?Q?Wdb/Lfmd0oh/r1ImqK09ZYP6VLjT07Y3ylFNQ1Ex4NlVMxPT42LYrTAwc1Xp?=
 =?us-ascii?Q?SFIPd2iMHW547GaRzCcFEMXxRPTvkKDC2B1GFOidRQhZX/TKVn7mjkc71d0p?=
 =?us-ascii?Q?QYguwJZ25L/D909LIYDOneQVY1n3+IMP1B/c24bG/ECHOSX8tRXsu+ppJ0ZJ?=
 =?us-ascii?Q?tX95TvStvbjnJn+2xR+uSydtJKzraogHx9wX7GYLp0uR7Am7eNvvEJGbEadS?=
 =?us-ascii?Q?S4QGAuLKMQQndMN94UFzQCiJ5UsojC+uyTHgS6h7QLAUWLS5o3LCnYfhFvHa?=
 =?us-ascii?Q?M4gWw95XptAMqMEoLFqFymYYhoOavcM3UIDy1C9GTsZ9SlPY4YBJPYaWBjoB?=
 =?us-ascii?Q?Wm6XcvbdZ5ItNTqK68SaJZrQxGwoieHcLLhQfks7vPO6pRYzQoXhCLwupxOQ?=
 =?us-ascii?Q?AX4DNA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96eba79e-347d-4312-86d6-08d9b0cabee9
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2021 10:51:48.1358
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: u5ZTehXkKOib8zKOu1Q58KtQ96Ga0uVMlWzsvi/FBuSaBZV6zQKmYanFmojF6qYg/3W49ZSO+5y+GU4RT50jf3PdQ7/jhjiMyDQllHbcPqw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB3204
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Kieran,

Thanks for the patch.

> Subject: [PATCH 4/4] drm: rcar-du: mipi-dsi: Support bridge probe orderin=
g
>=20
> The bridge probe ordering for DSI devices has been clarified and further
> documented in
>=20
> To support connecting with the SN65DSI86 device after commit c3b75d4734cb
> ("drm/bridge: sn65dsi86: Register and attach our DSI device at probe"),
> update to the new probe ordering to remove a perpetual -EPROBE_DEFER loop
> between the two devices.
>=20
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
>  drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 48 +++++++++++++------------
>  1 file changed, 26 insertions(+), 22 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
> b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
> index 833f4480bdf3..f783bacee8da 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c
> @@ -639,6 +639,8 @@ static int rcar_mipi_dsi_host_attach(struct
> mipi_dsi_host *host,
>  					struct mipi_dsi_device *device)
>  {
>  	struct rcar_mipi_dsi *dsi =3D host_to_rcar_mipi_dsi(host);
> +	struct drm_panel *panel;
> +	int ret;
>=20
>  	if (device->lanes > dsi->num_data_lanes)
>  		return -EINVAL;
> @@ -646,12 +648,36 @@ static int rcar_mipi_dsi_host_attach(struct
> mipi_dsi_host *host,
>  	dsi->lanes =3D device->lanes;
>  	dsi->format =3D device->format;
>=20
> +	ret =3D drm_of_find_panel_or_bridge(dsi->dev->of_node, 1, 0, &panel,
> +					  &dsi->next_bridge);
> +	if (ret) {
> +		dev_err_probe(dsi->dev, ret, "could not find next bridge\n");
> +		return ret;

This can merged with previous line. return dev_err_probe(dsi->dev, ret, "co=
uld not find next bridge\n");
> +	}
> +
> +	if (!dsi->next_bridge) {
> +		dsi->next_bridge =3D devm_drm_panel_bridge_add(dsi->dev, panel);
> +		if (IS_ERR(dsi->next_bridge)) {
> +			dev_err(dsi->dev, "failed to create panel bridge\n");
> +			return PTR_ERR(dsi->next_bridge);

Why not return dev_err_probe??

Cheers,
Biju

> +		}
> +	}
> +
> +	/* Initialize the DRM bridge. */
> +	dsi->bridge.funcs =3D &rcar_mipi_dsi_bridge_ops;
> +	dsi->bridge.of_node =3D dsi->dev->of_node;
> +	drm_bridge_add(&dsi->bridge);
> +
>  	return 0;
>  }
>=20
>  static int rcar_mipi_dsi_host_detach(struct mipi_dsi_host *host,
>  					struct mipi_dsi_device *device)
>  {
> +	struct rcar_mipi_dsi *dsi =3D host_to_rcar_mipi_dsi(host);
> +
> +	drm_bridge_remove(&dsi->bridge);
> +
>  	return 0;
>  }
>=20
> @@ -766,21 +792,6 @@ static int rcar_mipi_dsi_probe(struct platform_devic=
e
> *pdev)
>  		return PTR_ERR(dsi->rstc);
>  	}
>=20
> -	ret =3D drm_of_find_panel_or_bridge(dsi->dev->of_node, 1, 0, &panel,
> -					  &dsi->next_bridge);
> -	if (ret) {
> -		dev_err_probe(dsi->dev, ret, "could not find next bridge\n");
> -		return ret;
> -	}
> -
> -	if (!dsi->next_bridge) {
> -		dsi->next_bridge =3D devm_drm_panel_bridge_add(dsi->dev, panel);
> -		if (IS_ERR(dsi->next_bridge)) {
> -			dev_err(dsi->dev, "failed to create panel bridge\n");
> -			return PTR_ERR(dsi->next_bridge);
> -		}
> -	}
> -
>  	/* Initialize the DSI host. */
>  	dsi->host.dev =3D dsi->dev;
>  	dsi->host.ops =3D &rcar_mipi_dsi_host_ops; @@ -788,11 +799,6 @@ static
> int rcar_mipi_dsi_probe(struct platform_device *pdev)
>  	if (ret < 0)
>  		return ret;
>=20
> -	/* Initialize the DRM bridge. */
> -	dsi->bridge.funcs =3D &rcar_mipi_dsi_bridge_ops;
> -	dsi->bridge.of_node =3D dsi->dev->of_node;
> -	drm_bridge_add(&dsi->bridge);
> -
>  	return 0;
>  }
>=20
> @@ -800,8 +806,6 @@ static int rcar_mipi_dsi_remove(struct platform_devic=
e
> *pdev)  {
>  	struct rcar_mipi_dsi *dsi =3D platform_get_drvdata(pdev);
>=20
> -	drm_bridge_remove(&dsi->bridge);
> -
>  	mipi_dsi_host_unregister(&dsi->host);
>=20
>  	return 0;
> --
> 2.30.2