MIME-Version: 1.0
References: <20211126141027.16161-1-henning.schild@siemens.com> <20211126141027.16161-5-henning.schild@siemens.com>
In-Reply-To: <20211126141027.16161-5-henning.schild@siemens.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 26 Nov 2021 16:51:00 +0200
Message-ID: <CAHp75Vf6x4-AYPPEMf7qXTi-RF92mdUn6rhghBpJ5avQAjYRzA@mail.gmail.com>
Subject: Re: [PATCH v4 4/4] platform/x86: pmc_atom: improve critclk_systems
 matching for Siemens PCs
To:     Henning Schild <henning.schild@siemens.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        linux-watchdog@vger.kernel.org,
        Srikanth Krishnakar <skrishnakar@gmail.com>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Gerd Haeussler <gerd.haeussler.ext@siemens.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Mark Gross <mgross@linux.intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Pavel Machek <pavel@ucw.cz>, Enrico Weigelt <lkml@metux.net>,
        Michael Haener <michael.haener@siemens.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 26, 2021 at 4:10 PM Henning Schild
<henning.schild@siemens.com> wrote:
>
> Siemens industrial PCs unfortunately can not always be properly
> identified the way we used to. An earlier commit introduced code that
> allows proper identification without looking at DMI strings that could
> differ based on product branding.
> Switch over to that proper way and revert commits that used to collect
> the machines based on unstable strings.

Usually we start a series with fixes, but I guess it's fine here since
this can be taken separately, right?

...

> +#include <linux/platform_data/x86/simatic-ipc.h>

Seems not.  Question is then, what Fixes tags would  mean in this case?

-- 
With Best Regards,
Andy Shevchenko