Subject: Re: [PATCH] serial: amba-pl011: do not request memory region twice
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     gregkh@linuxfoundation.org, jirislaby@kernel.org,
        p.rosenberger@kunbus.com, lukas@wunner.de,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211126143925.18758-1-LinoSanfilippo@gmx.de>
 <YaEGvkBl8YT33YAR@shell.armlinux.org.uk>
From:   Lino Sanfilippo <LinoSanfilippo@gmx.de>
Message-ID: <7e7dae62-ac66-e5cd-f801-add3a9f81dc6@gmx.de>
Date:   Fri, 26 Nov 2021 17:27:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YaEGvkBl8YT33YAR@shell.armlinux.org.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On 26.11.21 at 17:09, Russell King (Oracle) wrote:
> On Fri, Nov 26, 2021 at 03:39:25PM +0100, Lino Sanfilippo wrote:
>> The driver attempts to request and release the IO memory region for a u=
art
>> port twice:
>>
>> First during the probe() function devm_ioremap_resource() is used to
>> allocate and map the ports memory.
>> Then a combo of pl011_config_port() and pl011_release_port() is used to
>> request/release the same memory area. These functions are called by the
>> serial core as soon as the uart is registered/unregistered.
>>
>> However since the allocation request via devm_ioremap_resource() alread=
y
>> succeeds, the attempt to claim the memory again via pl011_config_port()
>> fails. This failure remains unnoticed, since the concerning return valu=
e is
>> not evaluated.
>> Later at module unload also the attempt to release the unclaimed memory
>> in pl011_release_port() fails. This time the failure results in a =E2=
=80=9CTrying
>> to free nonexistent resource" warning printed by the serial core.
>>
>> Fix these issues by removing the callbacks that implement the redundant
>> memory allocation/release.
>
> I think you will also need the verify_port method to also deny changing
> port->mapbase.
>


Right, I will add this, thanks for the hint!

Regards,
Lino