Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932379AbXAPFqP (ORCPT ); Tue, 16 Jan 2007 00:46:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932375AbXAPFqP (ORCPT ); Tue, 16 Jan 2007 00:46:15 -0500 Received: from smtp.osdl.org ([65.172.181.24]:47015 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932373AbXAPFqO (ORCPT ); Tue, 16 Jan 2007 00:46:14 -0500 Date: Mon, 15 Jan 2007 21:44:27 -0800 From: Stephen Hemminger To: Nate Diller Cc: Nate Diller , Andrew Morton , Alan Cox , Trond Myklebust , Benjamin LaHaise , Alexander Viro , Suparna Bhattacharya , Kenneth W Chen , David Brownell , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-aio@kvack.org, xfs-masters@oss.sgi.com Subject: Re: [PATCH -mm 2/10][RFC] aio: net use struct socket for io Message-ID: <20070115214427.7fc55a6c@oldman> In-Reply-To: <20070116015450.9764.24404.patchbomb.py@nate-64.agami.com> References: <20070116015450.9764.37697.patchbomb.py@nate-64.agami.com> <20070116015450.9764.24404.patchbomb.py@nate-64.agami.com> X-Mailer: Sylpheed-Claws 2.5.0-rc3 (GTK+ 2.10.6; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 753 Lines: 19 On Mon, 15 Jan 2007 17:54:50 -0800 Nate Diller wrote: > Remove unused arg from socket operations > > The sendmsg and recvmsg socket operations take a kiocb pointer, but none of > the functions actually use it. There's really no need even theoretically, > it's really quite ugly having it there at all. Also, removing it will pave > the way for a more generic completion path in the file_operations. > > --- Would getting rid of these make later implementation of AIO networking harder? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/