Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E76C433EF for ; Fri, 26 Nov 2021 17:13:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245588AbhKZRQ4 (ORCPT ); Fri, 26 Nov 2021 12:16:56 -0500 Received: from dcvr.yhbt.net ([64.71.152.64]:39276 "EHLO dcvr.yhbt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347508AbhKZROz (ORCPT ); Fri, 26 Nov 2021 12:14:55 -0500 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 16EE41F953; Fri, 26 Nov 2021 17:11:42 +0000 (UTC) Date: Fri, 26 Nov 2021 17:11:41 +0000 From: Eric Wong To: Thorsten Leemhuis Cc: workflows@vger.kernel.org, linux-kernel@vger.kernel.org, Konstantin Ryabitsev , Jonathan Corbet , git@vger.kernel.org, Linus Walleij , Kees Cook Subject: Re: [RFC PATCH v1 1/1] docs: add the new commit-msg tags 'Reported:' and 'Reviewed:' Message-ID: <20211126171141.GA21826@dcvr> References: <6b760115ecdd3687d4b82680b284f55a04f3ad90.1637566224.git.linux@leemhuis.info> <20211123185237.M476855@dcvr> <12cefa81-495b-3083-5f19-b319c704ebf7@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <12cefa81-495b-3083-5f19-b319c704ebf7@leemhuis.info> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thorsten Leemhuis wrote: > Ccing Linus Walleij, who added this, and Kees, who apparently came up > with this originally. > > On 23.11.21 19:52, Eric Wong wrote: > > Thorsten Leemhuis wrote: > >> diff --git a/Documentation/maintainer/configure-git.rst b/Documentation/maintainer/configure-git.rst > >> index 80ae5030a590..8429d45d661c 100644 > >> --- a/Documentation/maintainer/configure-git.rst > >> +++ b/Documentation/maintainer/configure-git.rst > > > > , +cc git@vger > > > >> @@ -56,7 +56,7 @@ by adding the following hook into your git: > >> $ cat >.git/hooks/applypatch-msg <<'EOF' > >> #!/bin/sh > >> . git-sh-setup > >> - perl -pi -e 's|^Message-Id:\s*]+)>?$|Link: https://lore.kernel.org/r/$1|g;' "$1" > >> + perl -pi -e 's|^Message-Id:\s*]+)>?$|Reviewed: https://lore.kernel.org/r/$1|g;' "$1" > > > > Side note: that regexp should match "Message-ID" case-insensitively. > > git send-email is an outlier in its capitalization of "Message-Id", > > most RFCs capitalize it "Message-ID", as do common MUAs. > > Argh :-/ > > It's still totally unclear if that or a similar patch will be accepted. > And even if it is: the "don't do two different things in one commit" > rule might not be that strict enforced when it comes to the Linux > kernel's docs, but changing this regexp as part of another patch crosses > the line. > > IOW: we afaics need a separate patch to make the regexp > case-insensitively. Eric, do you want to submit one, as you brought it > up? Or are there any other volunteers? I suggest you turn this into a 2 patch series to avoid conflicts for a trivial change. I don't even have a kernel worktree handy at the moment (ENOSPC :x)