MIME-Version: 1.0
References: <20211126143329.2689618-1-arnd@kernel.org> <CAHmME9rotnZRzqeD43FJmSX6-i2CwvUVpXHrFkLGt+qVVdxK7A@mail.gmail.com>
 <CAK8P3a2KfmmGDbVHULWevB0hv71P2oi2ZCHEAqT=8dQfa0=cqQ@mail.gmail.com> <CAHmME9q3ihG6OukcbhgkzwMUY7y+N3tKrGu2aRHjkgmAv4j=WQ@mail.gmail.com>
In-Reply-To: <CAHmME9q3ihG6OukcbhgkzwMUY7y+N3tKrGu2aRHjkgmAv4j=WQ@mail.gmail.com>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Fri, 26 Nov 2021 21:19:31 +0100
Message-ID: <CAK8P3a1Jk8-mokkzo6Q4M5xoO+13fCgdh-A2bajD9HR7Xenn0w@mail.gmail.com>
Subject: Re: [PATCH] crypto: siphash - use _unaligned version by default
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jean-Philippe Aumasson <jeanphilippe.aumasson@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 26, 2021 at 4:26 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> On Fri, Nov 26, 2021 at 10:18 AM Arnd Bergmann <arnd@kernel.org> wrote:
> > I have not tested this specific patch on all platforms, but I did
> > extensive testing of the get_unaligned()/put_unaligned() helpers
> > in my rewrite earlier this year[1], making sure that these are NOPs
> > on all the important architectures, and that they prevent the use
> > of trapping ldrd/ldm instructions on ARMv6/ARMv7.
>
> If you're confident that the codegen doesn't change for ARMv8 and
> x86{,_64}, then:
>
> Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>

Thanks

> We should probably Cc stable@, right?

Yes, I meant to add that but forgot.

> I'm preparing a patchset for DaveM's stable tree today, and I can take
> this in that patchset.

It's not urgent, but I think we need to fix it and get it into stable kernels
at some point. I'm happy with whatever timing works for you.

         Arnd