Subject: Re: [PATCH] powercap/drivers/dtpm: Disable dtpm at boot time
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
To:     dsmythies@telus.net, rafael@kernel.org
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        lukasz.luba@arm.com, gregkh@linuxfoundation.org,
        Daniel Lezcano <daniel.lezcano@kernel.org>
References: <9821f60a-c562-12e8-bdd4-45dbfe88a117@linaro.org>
 <20211126230820.3441863-1-daniel.lezcano@linaro.org>
Message-ID: <9e81f795-6d3a-2078-5ef1-13b965e89a2a@linaro.org>
Date:   Sat, 27 Nov 2021 00:10:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211126230820.3441863-1-daniel.lezcano@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


Hi Doug,

I was unable to reproduce the issue because I don't have an x86 platform.

Is it possible to check if this fix is ok?

  -- Daniel

On 27/11/2021 00:08, Daniel Lezcano wrote:
> The DTPM framework misses a mechanism to set it up. That is currently
> under review but will come after the next cycle.
> 
> As the distro are enabling all the kernel options, the DTPM framework
> is enabled on platforms where the energy model is not implemented,
> thus making the framework inconsistent and disrupting the CPU
> frequency scaling service.
> 
> Remove the initialization at boot time as a hot fix.
> 
> Fixes: 7a89d7eacf8e ("powercap/drivers/dtpm: Simplify the dtpm table")
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  drivers/powercap/dtpm.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c
> index b9fac786246a..fb35c5828bfb 100644
> --- a/drivers/powercap/dtpm.c
> +++ b/drivers/powercap/dtpm.c
> @@ -471,9 +471,6 @@ static int __init init_dtpm(void)
>  		return PTR_ERR(pct);
>  	}
>  
> -	for_each_dtpm_table(dtpm_descr)
> -		dtpm_descr->init();
> -
>  	return 0;
>  }
>  late_initcall(init_dtpm);
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog