MIME-Version: 1.0
References: <20211125193852.3617-1-goldstein.w.n@gmail.com>
 <20211127063904.102017-1-goldstein.w.n@gmail.com> <CANn89i+AAx6dAFkUr9eOSxp6d47=y6oZox8DErGQdNyfjLipdg@mail.gmail.com>
In-Reply-To: <CANn89i+AAx6dAFkUr9eOSxp6d47=y6oZox8DErGQdNyfjLipdg@mail.gmail.com>
From:   Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Sat, 27 Nov 2021 01:18:48 -0600
Message-ID: <CAFUsyf+qeVFPrmPnq+WHsxvKi6gVAf8ZanG0kgAM6-SgKtT67Q@mail.gmail.com>
Subject: Re: [PATCH v3] x86/lib: Optimize 8x loop and memory clobbers in csum_partial.c
To:     Eric Dumazet <edumazet@google.com>
Cc:     tglx@linutronix.de, mingo@redhat.com,
        Borislav Petkov <bp@alien8.de>, dave.hansen@linux.intel.com,
        X86 ML <x86@kernel.org>, hpa@zytor.com, peterz@infradead.org,
        alexanderduyck@fb.com, open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Nov 27, 2021 at 12:51 AM Eric Dumazet <edumazet@google.com> wrote:
>
> On Fri, Nov 26, 2021 at 10:39 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > Modify the 8x loop to that it uses two independent
> > accumulators. Despite adding more instructions the latency and
> > throughput of the loop is improved because the `adc` chains can now
> > take advantage of multiple execution units.
>
> Oh well, there was really no need to resend this, especially if you do
> not add my ack.
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>

Sorry!

Is the protocol for tags to let the maintainer add them or
should I post a V4 with your tag?