Date: Tue, 16 Jan 2007 13:24:21 +0300
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Nate Diller <nate@agami.com>, Nate Diller <nate.diller@gmail.com>,
       Andrew Morton <akpm@osdl.org>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Trond Myklebust <trond.myklebust@fys.uio.no>,
       Benjamin LaHaise <bcrl@kvack.org>,
       Alexander Viro <viro@zeniv.linux.org.uk>,
       Suparna Bhattacharya <suparna@in.ibm.com>,
       Kenneth W Chen <kenneth.w.chen@intel.com>,
       David Brownell <dbrownell@users.sourceforge.net>,
       Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org,
       linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org,
       ocfs2-devel@oss.oracle.com, linux-aio@kvack.org,
       xfs-masters@oss.sgi.com
Subject: Re: [PATCH -mm 2/10][RFC] aio: net use struct socket for io
Message-ID: <20070116102421.GA17284@2ka.mipt.ru>
References: <20070116015450.9764.37697.patchbomb.py@nate-64.agami.com> <20070116015450.9764.24404.patchbomb.py@nate-64.agami.com> <20070115214427.7fc55a6c@oldman>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20070115214427.7fc55a6c@oldman>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1155
Lines: 26

On Mon, Jan 15, 2007 at 09:44:27PM -0800, Stephen Hemminger (shemminger@osdl.org) wrote:
> > The sendmsg and recvmsg socket operations take a kiocb pointer, but none of
> > the functions actually use it.  There's really no need even theoretically,
> > it's really quite ugly having it there at all.  Also, removing it will pave
> > the way for a more generic completion path in the file_operations.
> > 
> > ---
> 
> Would getting rid of these make later implementation of AIO networking
> harder?

Depending on what AIO it will be.
Mainstream AIO does stand on kiocb, but if socket operations will be
extended to have additional async_read/write (like it as done in kevent
AIO) there is no need to have this pointer in sync operations (until
people want to have sync aio just as async with waiting for completion).

So, real question is, what next - how network AIO will be implemented?

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/