MIME-Version: 1.0
References: <202111271017.dLo8jJ8p-lkp@intel.com>
In-Reply-To: <202111271017.dLo8jJ8p-lkp@intel.com>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Sat, 27 Nov 2021 07:10:56 -0800
Message-ID: <CAMo8BfL88Qc6o=WheT6+n4pOpXQbnw220UQa_GCQb98F=S9ffA@mail.gmail.com>
Subject: Re: [linux-stable-rc:linux-4.19.y 565/981] arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33:
 error: initializer element is not constant
To:     kernel test robot <lkp@intel.com>
Cc:     kbuild-all@lists.01.org, LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sasha Levin <sashal@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Nov 26, 2021 at 6:33 PM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> head:   1f244a54b39dd02c69f79001b38e2650e96f1ea8
> commit: 1c21a8df144f1edb3b6f5f24559825780c227a7d [565/981] xtensa: xtfpga: use CONFIG_USE_OF instead of CONFIG_OF
> config: xtensa-randconfig-r001-20211126 (https://download.01.org/0day-ci/archive/20211127/202111271017.dLo8jJ8p-lkp@intel.com/config)
> compiler: xtensa-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=1c21a8df144f1edb3b6f5f24559825780c227a7d
>         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
>         git fetch --no-tags linux-stable-rc linux-4.19.y
>         git checkout 1c21a8df144f1edb3b6f5f24559825780c227a7d
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>    In file included from include/linux/kernel.h:10,
>                     from arch/xtensa/platforms/xtfpga/setup.c:19:
>    include/linux/dma-mapping.h: In function 'dma_map_resource':
>    arch/xtensa/include/asm/page.h:182:16: warning: comparison of unsigned expression in '>= 0' is always true [-Wtype-limits]
>      182 |         ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr)
>          |                ^~
>    include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
>       77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
>          |                                             ^
>    include/linux/dma-mapping.h:329:9: note: in expansion of macro 'BUG_ON'
>      329 |         BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
>          |         ^~~~~~
>    include/linux/dma-mapping.h:329:16: note: in expansion of macro 'pfn_valid'
>      329 |         BUG_ON(pfn_valid(PHYS_PFN(phys_addr)));
>          |                ^~~~~~~~~
>    In file included from arch/xtensa/platforms/xtfpga/setup.c:37:
>    arch/xtensa/platforms/xtfpga/setup.c: At top level:
> >> arch/xtensa/platforms/xtfpga/include/platform/hardware.h:50:33: error: initializer element is not constant
>       50 | #define OETH_REGS_PADDR         (XCHAL_KIO_PADDR + 0x0D030000)
>          |                                 ^

This happens because the backported change
1c21a8df144f1edb3b6f5f24559825780c227a7d depends on the change
d67ed2510d28 ("xtensa: use CONFIG_USE_OF instead of CONFIG_OF")
which is not in that stable tree.

Should I send the backported version of the d67ed2510d28 or should
the change 1c21a8df144f1edb3b6f5f24559825780c227a7d be reverted
from the stable? (IMO they are not the stable material).
-- 
Thanks.
-- Max