Date:   Sat, 27 Nov 2021 17:46:02 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Alyssa Ross <hi@alyssa.is>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>,
        Lee Jones <lee.jones@linaro.org>,
        linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
        linux-stm32@st-md-mailman.stormreply.com (moderated list:ARM/STM32
        ARCHITECTURE),
        linux-arm-kernel@lists.infradead.org (moderated list:ARM/STM32
        ARCHITECTURE), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] iio: trigger: stm32-timer: fix MODULE_ALIAS
Message-ID: <20211127174602.6f674d37@jic23-huawei>
In-Reply-To: <20211125182850.2645424-1-hi@alyssa.is>
References: <20211125182850.2645424-1-hi@alyssa.is>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 25 Nov 2021 18:28:48 +0000
Alyssa Ross <hi@alyssa.is> wrote:

> modprobe can't handle spaces in aliases.
> 
> Fixes: 93fbe91b5521 ("iio: Add STM32 timer trigger driver")
> Signed-off-by: Alyssa Ross <hi@alyssa.is>
Hi Alysaa,

Looks fine to me, but I'd like to give it a little longer on list before
taking it as a fix, particularly as this probably wants to get backported
to stable.

Thanks,

Jonathan

> ---
>  drivers/iio/trigger/stm32-timer-trigger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> index 33083877cd19..4353b749ecef 100644
> --- a/drivers/iio/trigger/stm32-timer-trigger.c
> +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> @@ -912,6 +912,6 @@ static struct platform_driver stm32_timer_trigger_driver = {
>  };
>  module_platform_driver(stm32_timer_trigger_driver);
>  
> -MODULE_ALIAS("platform: stm32-timer-trigger");
> +MODULE_ALIAS("platform:stm32-timer-trigger");
>  MODULE_DESCRIPTION("STMicroelectronics STM32 Timer Trigger driver");
>  MODULE_LICENSE("GPL v2");