Date:   Sat, 27 Nov 2021 20:14:06 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Marc Zygnier <maz@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Megha Dey <megha.dey@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, linux-pci@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        iommu@lists.linux-foundation.org, dmaengine@vger.kernel.org,
        Stuart Yoder <stuyoder@gmail.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        linux-arm-kernel@lists.infradead.org, x86@kernel.org,
        Vinod Koul <vkoul@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Will Deacon <will@kernel.org>, Sinan Kaya <okaya@kernel.org>
Subject: Re: [patch 02/37] device: Add device::msi_data pointer and struct
 msi_device_data
Message-ID: <20211128001406.GT4670@nvidia.com>
References: <20211126224100.303046749@linutronix.de>
 <20211126230524.045836616@linutronix.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211126230524.045836616@linutronix.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RRsHo0qRY+B4SlGd36X+60HpRCou+GDRqJcYrw0CyCgkGqJRqBsAtsAJgNW2?=
 =?us-ascii?Q?K3q7UaND7fYX3Gkb0lyEvv0TdAU4zLm6A84F+iAYAEQeMSutGh/uubKjiSTW?=
 =?us-ascii?Q?EMpYANrGxHencQ2D8JgtOu2ToZjnUwF1aHgThAQuCrrYyr7un0OygKYROA3p?=
 =?us-ascii?Q?mmbUJr8IXqcSS1WZqyf4GGlp/r1QAod9tducsO43drJYr/I16OD5XnkJm+xS?=
 =?us-ascii?Q?Fm6MtYsvT+8h8u9b4x40eIATHhlKYSF3Y3PuZa+FTfRvyYHv7O1Er3NCXZ7l?=
 =?us-ascii?Q?iy7jEKuxXky7Ycgmm9USg0L0LikCkyrT5zHx/hB4uQSOqgEFuBF7z7hCq89g?=
 =?us-ascii?Q?dBVwbcWvkA7gzSegC+HnyrND1+YW+LHsN/tK2Boq9IXkfB/QmuibG+6ZEFke?=
 =?us-ascii?Q?dIK8VxEHzMtK8Opo5tcarpOAwj806JQJML/RRANc4MZJvUBWaBv6anAyLAB2?=
 =?us-ascii?Q?12tgSlbtYUjTjH+3BTd40zcixD/RvGHt9nm/iuiuFG6ajW/aBDg0E2d/ozfx?=
 =?us-ascii?Q?LNjcp162/xAVEywoXWtTLtsLsIuv8uVqxH2MF8JsSd1B6cSATNHy9Q92a8G1?=
 =?us-ascii?Q?PAp+Br2TUFOfp/r3094epid4xy8mYBes8DKaNq+AMzAUgTV0mU/mZCaWlYW7?=
 =?us-ascii?Q?1EmyKpD4GX1iuVrzbu/dz3SXjt5IAYCi45jRLFYpQY66QJwtRPTMGAFz9Khw?=
 =?us-ascii?Q?zdKYxisLYNjGDfFofhITnoJqcts/QZOz+YhDjjQ03tfZS6NJ0clt21ncPlks?=
 =?us-ascii?Q?Fhtjjg250IGLJt4tznAiuxZy4uQ5pPCNU/94Dbot7fJDDBKDxN5q5jR5ao5O?=
 =?us-ascii?Q?LVXN+hiLYzDsJ17rx0gdJYIvSSqoVG95n5rmuXBdUyYzzYW/7om0NkJEz62P?=
 =?us-ascii?Q?FIETsaJt6IvhLX8skWsunRIr3e4CHeG0j1B+ec/bVfhRPbwHaFVFv5P80M5v?=
 =?us-ascii?Q?Zh/CcsKvbSqaspU0146aPmXWctaaXIYRaZPO76EnrUzlqyGOJy1eMS6yNqb2?=
 =?us-ascii?Q?NtaGQMGQ3z1xr0Hkwjq3gQyJq7vdZo47G8uy39MqO4dLw55WjoeX71WQStE1?=
 =?us-ascii?Q?DPHIMM53Yaz4mN8+HTh6NtmXP017Gf0i8go/9g62L7aWKO5M9GdZU8CxvZT8?=
 =?us-ascii?Q?ixgLO1umYOyNaxBYUlRW3nDsngj907cZDZ8j2dL40x4dxVE4JFi8bOayJCvt?=
 =?us-ascii?Q?m8w+qidHEhxJzsqG32yCw6gVRjkccTwVQERi6U8kLUGDM4WIVBNjHaA84fyO?=
 =?us-ascii?Q?rQxv10A7zDonk0tZnTnfKNkinClEBvOmhB6DZppz89ZE1raxzHe3unlU8Ruz?=
 =?us-ascii?Q?RnxgazabkhUH39jZm9peWZrg5yNNNEcqzGJHWnSS5chb3RiwM8duIrtBGSao?=
 =?us-ascii?Q?lbQsdGVz8mjG+uUzRadEUPvZj+7ihArCOH60jx1kzcKP5h/B3p4v7FZbgnXw?=
 =?us-ascii?Q?GJu0wXebsROsxkaT3iXAn6jwMYmY9tbO7Ep0IFNnXfGwjUohDeWWsktoEpvc?=
 =?us-ascii?Q?i4p5F1Mwa0jzvxK8yQsKi3ONFxRTh0c3omwx3IZx7C5sZwi04C2Ox+jr5e8n?=
 =?us-ascii?Q?HTSHbAbHLNoLSpUhaKY=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44bbdb6c-7155-4037-3ab1-08d9b203fe7f
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2021 00:14:07.5217
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L2xi5fOw6dVj8XLGT4aUbG58aAdrDMITs1/raskUu7rf5W5niyEATarM7I9lYG82
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5255
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Nov 27, 2021 at 02:20:09AM +0100, Thomas Gleixner wrote:

> +/**
> + * msi_setup_device_data - Setup MSI device data
> + * @dev:	Device for which MSI device data should be set up
> + *
> + * Return: 0 on success, appropriate error code otherwise
> + *
> + * This can be called more than once for @dev. If the MSI device data is
> + * already allocated the call succeeds. The allocated memory is
> + * automatically released when the device is destroyed.

I would say 'by devres when the driver is removed' rather than device
is destroyed - to me the latter implies it would happen at device_del
or perhaps during release..

> +int msi_setup_device_data(struct device *dev)
> +{
> +	struct msi_device_data *md;
> +
> +	if (dev->msi.data)
> +		return 0;
> +
> +	md = devres_alloc(msi_device_data_release, sizeof(*md), GFP_KERNEL);
> +	if (!md)
> +		return -ENOMEM;
> +
> +	raw_spin_lock_init(&md->lock);

I also couldn't guess why this needed to be raw?

Jason