Message-ID: <b9f738b6-1140-55d1-bb3f-d54f3521b739@intel.com>
Date:   Sun, 28 Nov 2021 14:33:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.2
Subject: Re: [Intel-wired-lan] [PATCH 1/3] Revert "e1000e: Additional PHY
 power saving in S0ix"
Content-Language: en-US
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>,
        "Lifshits, Vitaly" <vitaly.lifshits@intel.com>,
        "Ruinskiy, Dima" <dima.ruinskiy@intel.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <acelan.kao@canonical.com>, Jakub Kicinski <kuba@kernel.org>,
        <intel-wired-lan@lists.osuosl.org>,
        "David S. Miller" <davem@davemloft.net>,
        "Neftin, Sasha" <sasha.neftin@intel.com>, <mpearson@lenovo.com>
References: <20211122161927.874291-1-kai.heng.feng@canonical.com>
 <14e6c86d-0764-ceaf-4244-fcbf2c2dc23e@intel.com>
 <CAAd53p4cQ+3HQKP3--SW68fNPM9LZPbkBrrA68iu12-gA4-B7Q@mail.gmail.com>
From:   Sasha Neftin <sasha.neftin@intel.com>
In-Reply-To: <CAAd53p4cQ+3HQKP3--SW68fNPM9LZPbkBrrA68iu12-gA4-B7Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGJrS0s3K0xTU1I4eEVrWFo3L3pYMzlvMWVCay9Oc052SFNLb3F3N1lmQzU4?=
 =?utf-8?B?N1Z2ek5VaitaOVl2TmtRbkVJblhPT25kMFhlMFhnVWhCaTFMSU84MUREWXVE?=
 =?utf-8?B?RDlxUENDUExmNkJDV3Z4UnBPYUlBaXdpbEh6Zm9rMXZYQWdBdUdWMEV6MXV6?=
 =?utf-8?B?RkpoQ240L3RwUEg0bGdrQjZXUTlXOFYrandBY2dPK01vU00vN2FaVG5pQ0RO?=
 =?utf-8?B?WlBQV1Q5M2xINU94REMxM0dxaHIxbXJKN0dHemkrN21WaDRwcG1Iam9OcFhF?=
 =?utf-8?B?UWpEcTVPaThnZTlTYmpMU3BPUnEyT3hQM25jWTZRWDZuU1E0OFJWc2QrNzA0?=
 =?utf-8?B?SFRzTyt3ZC9vQ3h4T0xuY25zbGU3TGc3N1RmN0RGVkhjQVJmejlzUDQrd2pi?=
 =?utf-8?B?QjgzcnYvQU9PMmlKZ3JuQWl3UjU4Z2pUSXhKcGdITytjMnZvU0E3bDlMSjA1?=
 =?utf-8?B?bWlkWG5JMXAzR0V6UWhJR3JCUGhKNCtWM1N0a1pPMlF2NkdSaElxSklkSEdu?=
 =?utf-8?B?enI3RWZNa1MrY3pla1FXaGF3WWlIQkVZTGg3QWhhVlhVVGtJc3ZBWXN4dm5T?=
 =?utf-8?B?a1ZIUnZiNEpackc3M0RlcXRvSnVVV2ZtT01FeS9NM01aNStMQlhBVnpjd1B4?=
 =?utf-8?B?bnF6b0toUTdXQS9lejZWbFJkTjBETnF5dlhPR1JZM2ZSTTBJNjl6eVdJak95?=
 =?utf-8?B?emVOdEtQdGVuamlwUEJ4aTB5bGR4Mnp5ZUVVMTFVZ3M4aDd3SUVHY1c4WEhU?=
 =?utf-8?B?VHJqSlNEKzllN2JHU3VZendlclpqMjAzRjZuZC9mb29qQ2pSZHRaeTJrMGdr?=
 =?utf-8?B?Z0hsT0JOblhtTUhVcDZvQ0c5WDJKL2tZUHVBbXZmcndUVy9iRm90SWV5dlo3?=
 =?utf-8?B?a09WNUlqeGhlVjFDTm1xdnlYQjBzaENvK3Y4elJJTWlYQ1VEeGR5aG1GT3k1?=
 =?utf-8?B?YTFldWVEbTdKbXpPK3doVGlaRm1TbGtaTEdWWUE4R3JNWk50ZzZSczZFU3Nr?=
 =?utf-8?B?Z28wTVlGaVV3c0JUcjJFV3J6RVR1VDhQdDRxV042Y1FUVkxJVXRTc0FpZTZl?=
 =?utf-8?B?bWRZdS80eUpJTWJKTEdRRFllUkY0RUZMdThOY2hYMU1DeDFvOXlKeUIxdmdv?=
 =?utf-8?B?K09QMVVDZnZUSDRSRFYzWnQwOTNRd0tSSFN5VmRqZnBjdlFOK1hqclhlZTBP?=
 =?utf-8?B?R0swSVhUaHpQVWxySlhHcjZ0dU9rSE1mUng2dzZxbzVLQ1k3dWJ1TDdZOG15?=
 =?utf-8?B?ZWpwUzY0WGZNM0pSVGxxUHVjRGJ6R0RYT0sxZEg0bGRNN0d4TC9TR1pqZTlv?=
 =?utf-8?B?NVQvQWZGNWFQWGdab2VWOHdMQVdEejhFYmdSM20va3NMeExZcjlNaVFpVU0v?=
 =?utf-8?B?Z2E3QUdpM2k3NEJBVC8vVExVekduemhjalFzU2V3QVJZOVRINE1hd3JVd1kx?=
 =?utf-8?B?QVl0aHMzZ1hRM3RReXZwd0ZDc1NTY2I0OTFSS1pHZGFMdmYxRHFoTlV4TmI5?=
 =?utf-8?B?SFI5WnlyVDNibVZ1ZmtVRGFZRnRqL1R4aHFsRUZ2SFc2cWc1YmwrblVVTmp5?=
 =?utf-8?B?aWVDV1gzc2I2MGI2TVdRZ3p2TGJ3MDdtK09UOHFYbDVRNnFUUjdLNUxsbjkw?=
 =?utf-8?B?Z2R1dHVKUFczcjNEclI3TXdzdUE5MzlnRWpjMUk3V0xwYlpTRDdrdXZQWmU3?=
 =?utf-8?B?dTRVcmUzY2JmMEFJTi9CT0hXSjFIeEpVT0txNlFmQ1dvR1VuU2hUUjIwYWVq?=
 =?utf-8?B?Q3JMSEI2ZlJwTDRrbTFKNHFzV2lRczV3TUFyMm1TNWpzM1EwMUhxeWxwY3hP?=
 =?utf-8?B?cFVqRjh6d2todTFQNTE2NjBmdnI5RXF6MDhuRWtQLzcwd015VzNYZGxCUGxI?=
 =?utf-8?B?bWZ4RERHU0l1aStoUnliSXUzZ0NRQjQ4Nmo3UTFwQ0dCS3A5YzBmeGt6blJL?=
 =?utf-8?B?KzlmSVNaR2Q0dTUvZkk1N2JDSWNGRDkxTkJVcnk3NFYxU1FXQlZrT1l4bDls?=
 =?utf-8?B?WFliL3FnYXJQbHFMWGlXWEhWWVNkc2RReU5Xa0JJa3phb2FQSjRvS3k1bmNp?=
 =?utf-8?B?Q2VkNFRKWFpSVGhOSDFvcGgxNUM0cEovUFVJSkQzdHZRL1NWSGROcVhhR0dW?=
 =?utf-8?B?bVRJOVMzQnNONFpzdGtiN1ZpZnZUUEZCM2NjUjhwbTFtYUdhSG83UFRKcVBN?=
 =?utf-8?Q?OdB69/giBAmm7l7bhWwrnUk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 802764cf-c15d-43c2-6f05-08d9b26b406b
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4787.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2021 12:33:16.4281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VV4T3YYEJD/+hQlj5casdy2Zd29cQRy12LrpN3fEc0Rb3CaeGwJpUPSyxb2N85TYimEsrCUwjes6UCqQXFApJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0013
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/24/2021 08:34, Kai-Heng Feng wrote:
> Hi, Vitaly,
> 
> On Tue, Nov 23, 2021 at 11:22 PM Lifshits, Vitaly
> <vitaly.lifshits@intel.com> wrote:
>>
>> Hello Kai,
>>
>>
>> We believe that simply reverting these patches is not a good idea. It will cause the driver to behave on a corporate system as if the CSME firmware is not there. This can lead to an unpredictable behavior in the long run.
> 
> I really don't want to revert the series either.
> 
>>
>>
>> The issue exposed by these patches is currently under active debug. We would like to find the root cause and fix it in a way that will still enable S0ix power savings on both corporate and consumer systems.
> 
> I am aware. But we've been waiting for the fix for a while, so I guess
> it's better to revert the series now, and re-apply them when the fix
> is ready.
> 
> Kai-Heng
Hello Kai-Heng,
In this patch, we addressed additional PHY power saving. There is no 
point in trying to revert it.
> 
>>
>>
>> On 11/22/2021 18:19, Kai-Heng Feng wrote:
>>
>> This reverts commit 3ad3e28cb203309fb29022dea41cd65df0583632.
>>
>> The s0ix series makes e1000e on TGL and ADL fails to work after s2idle
>> resume.
>>
>> There doesn't seem to be any solution soon, so revert the whole series.
>>
>> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=214821
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>>   drivers/net/ethernet/intel/e1000e/netdev.c | 6 ------
>>   1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
>> index 44e2dc8328a22..e16b7c0d98089 100644
>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>> @@ -6380,16 +6380,10 @@ static void e1000e_s0ix_entry_flow(struct e1000_adapter *adapter)
>>    ew32(CTRL_EXT, mac_data);
>>
>>    /* DFT control: PHY bit: page769_20[0] = 1
>> - * page769_20[7] - PHY PLL stop
>> - * page769_20[8] - PHY go to the electrical idle
>> - * page769_20[9] - PHY serdes disable
>>    * Gate PPW via EXTCNF_CTRL - set 0x0F00[7] = 1
>>    */
>>    e1e_rphy(hw, I82579_DFT_CTRL, &phy_data);
>>    phy_data |= BIT(0);
>> - phy_data |= BIT(7);
>> - phy_data |= BIT(8);
>> - phy_data |= BIT(9);
>>    e1e_wphy(hw, I82579_DFT_CTRL, phy_data);
>>
>>    mac_data = er32(EXTCNF_CTRL);
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
> 
Sasha