Date:   Sun, 28 Nov 2021 15:29:22 +0100
From:   "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To:     "Winkler, Tomas" <tomas.winkler@intel.com>
Cc:     Haakon Bugge <haakon.bugge@oracle.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "arnd@arndb.de" <arnd@arndb.de>,
        OFED mailing list <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] mei: Remove some dead code
Message-ID: <YaOSQrGqogbFGAqJ@kroah.com>
References: <3f904c291f3eed06223dd8d494028e0d49df6f10.1636711522.git.christophe.jaillet@wanadoo.fr>
 <80B25490-FE92-420E-A506-C92A996EF174@oracle.com>
 <17d6896a6abf49138556e34cb426d575@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <17d6896a6abf49138556e34cb426d575@intel.com>
Precedence: bulk

On Sun, Nov 28, 2021 at 11:12:33AM +0000, Winkler, Tomas wrote:
> 
> > 
> > 
> > > On 12 Nov 2021, at 11:06, Christophe JAILLET
> > <christophe.jaillet@wanadoo.fr> wrote:
> > >
> > > 'generated' is known to be true here, so "true || whatever" will still
> > > be true.
> > >
> > > So, remove some dead code.
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > ---
> > > This is also likely that a bug is lurking here.
> > >
> > > Maybe, the following was expected:
> > > -	generated = generated ||
> > > +	generated =
> > > 		(hisr & HISR_INT_STS_MSK) ||
> > > 		(ipc_isr & SEC_IPC_HOST_INT_STATUS_PENDING);
> > >
> > > ?
> > 
> > I concur about your analysis, but I do not know the intent here.
> Your fix  is okay, I can ack that patch. 

Is that an ack of this patch?  If so, please provide that...

thanks,

greg k-h