Date:   Sun, 28 Nov 2021 21:26:06 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build
Message-ID: <20211128212606.ft3qzwcsy3divl7z@liuwe-devbox-debian-v2>
References: <20211126023316.25184-1-rdunlap@infradead.org>
 <MWHPR21MB159387A26F1FF1A77CEB4255D7649@MWHPR21MB1593.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MWHPR21MB159387A26F1FF1A77CEB4255D7649@MWHPR21MB1593.namprd21.prod.outlook.com>
Precedence: bulk

On Sat, Nov 27, 2021 at 07:12:11PM +0000, Michael Kelley (LINUX) wrote:
> From: Randy Dunlap <rdunlap@infradead.org> Sent: Thursday, November 25, 2021 6:33 PM
> > 
> > The hyperv utilities use PTP clock interfaces and should depend a
> > a kconfig symbol such that they will be built as a loadable module or
> > builtin so that linker errors do not happen.
> > 
> > Prevents these build errors:
> > 
> > ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit':
> > hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister'
> > ld: drivers/hv/hv_util.o: in function `hv_timesync_init':
> > hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register'
> > 
> > Fixes: 46a971913611a ("Staging: hv: move hyperv code out of staging directory")
> 
> Seems like the "Fixes" tag should reference something a little newer than
> when the Hyper-V code was first added.  Either commit 3716a49a81ba
> ("hv_utils: implement Hyper-V PTP source") or commit e5f31552674e 
> ("ethernet: fix PTP_1588_CLOCK dependencies") when
> PTP_1588_CLOCK_OPTIONAL was added.
[...]
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

I used 3716a49a81ba in the Fixes tag and pushed it to hyperv-fixes.

Wei.