Message-ID: <8752eeae-6280-310e-85f1-bc0e594202fc@infradead.org>
Date:   Sun, 28 Nov 2021 14:49:32 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build
Content-Language: en-US
To:     Wei Liu <wei.liu@kernel.org>,
        "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Dexuan Cui <decui@microsoft.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20211126023316.25184-1-rdunlap@infradead.org>
 <MWHPR21MB159387A26F1FF1A77CEB4255D7649@MWHPR21MB1593.namprd21.prod.outlook.com>
 <20211128212606.ft3qzwcsy3divl7z@liuwe-devbox-debian-v2>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20211128212606.ft3qzwcsy3divl7z@liuwe-devbox-debian-v2>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/28/21 13:26, Wei Liu wrote:
> On Sat, Nov 27, 2021 at 07:12:11PM +0000, Michael Kelley (LINUX) wrote:
>> From: Randy Dunlap <rdunlap@infradead.org> Sent: Thursday, November 25, 2021 6:33 PM
>>>
>>> The hyperv utilities use PTP clock interfaces and should depend a
>>> a kconfig symbol such that they will be built as a loadable module or
>>> builtin so that linker errors do not happen.
>>>
>>> Prevents these build errors:
>>>
>>> ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit':
>>> hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister'
>>> ld: drivers/hv/hv_util.o: in function `hv_timesync_init':
>>> hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register'
>>>
>>> Fixes: 46a971913611a ("Staging: hv: move hyperv code out of staging directory")
>>
>> Seems like the "Fixes" tag should reference something a little newer than
>> when the Hyper-V code was first added.  Either commit 3716a49a81ba
>> ("hv_utils: implement Hyper-V PTP source") or commit e5f31552674e
>> ("ethernet: fix PTP_1588_CLOCK dependencies") when
>> PTP_1588_CLOCK_OPTIONAL was added.
> [...]
>>
>> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> 
> I used 3716a49a81ba in the Fixes tag and pushed it to hyperv-fixes.
> 
> Wei.

Oh, thank you.

~Randy