From:   Manish Rangankar <mrangankar@marvell.com>
To:     Florian Fainelli <f.fainelli@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     kernel test robot <lkp@intel.com>,
        Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "open list:QLOGIC QL41xxx ISCSI DRIVER" <linux-scsi@vger.kernel.org>
Subject: RE: [EXT] [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT
 formatting
Thread-Topic: [EXT] [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT
 formatting
Thread-Index: AQHX47WhTJf6rPyyKkmX/c4q85h7zKwaHiHQ
Date:   Mon, 29 Nov 2021 07:29:19 +0000
Message-ID: <CO6PR18MB4419B4245BB9ED3387105444D8669@CO6PR18MB4419.namprd18.prod.outlook.com>
References: <20211126201708.27140-1-f.fainelli@gmail.com>
 <20211126201708.27140-3-f.fainelli@gmail.com>
In-Reply-To: <20211126201708.27140-3-f.fainelli@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gllw/GrMu0FROYLWrlGnaFw2dFSgeGFFMF9L8on1ASuZl9qi5YS92ZGg6WQL?=
 =?us-ascii?Q?eVSydpIDqVo+ThEQB9USBOCFsjPxWmNElBdyOYtpFdxV3PzDKxObNFfKogr0?=
 =?us-ascii?Q?ZWcMcotJtJHYD8lkZpLRQb24X0E5JPlanbBc2iaOfIoXvj0HI/Uoh59qtI6F?=
 =?us-ascii?Q?1PkJtv2dKmVX3s4mVFq1gU+a+sSqnNvBfr2r/NSujqCYIMSSlmQPIRNuMRuC?=
 =?us-ascii?Q?/5AgaADONMy0Peluw5bVP/usHaeFTnzkcPD8E4z/TbWt0GwCMEMUnJz68qHV?=
 =?us-ascii?Q?iRklIY5Of2CFa/SO6Zur+miqkIQqq3ASr34M7C0sav6pXeGqdeqHQADKjGGj?=
 =?us-ascii?Q?2e0iaju0YWCcPhCoqCc2kblBjXh4YZ6uYckuHeEwIsy07aMQciXyCXlbwaul?=
 =?us-ascii?Q?nnB2Wl8AXurvXLFuVdK2zrHzjlh9SKRqWW3Js8t1NsOcsN2n5U65hDTxsPb6?=
 =?us-ascii?Q?gYoOalO5FELoO7C/BxzJ4YgyBgOT7lcdQNVgCEGQG3tThh2/A5u+nYnnlCfV?=
 =?us-ascii?Q?Luxz2m3N7Hz7YWnjuIA4WVA0FmPEuT+jgx8G1Cb26o5VBYwdfbGRgTKBkfiN?=
 =?us-ascii?Q?vMeDJEz+pzk0GzBk+eJPZ5ATjqXWUJOfkd9Iv/ZA8uoE0r6Qmb2BLoVTNAoB?=
 =?us-ascii?Q?BMLmpK28nzOc0tMtiFnPWpwX9VLyjrGUNhyyH/o94HDLjW0fPEGa3yDStLCD?=
 =?us-ascii?Q?K8hFgynjhXy3WPrwFY9eEjU+46xTIROO+4N8UGQYK0c5FLhu8EwRbO+leXyT?=
 =?us-ascii?Q?m70we5TMaM3BqJMjwb5AFGw7oQGqDMXQk8dqWNwd948rUM8Wy18jHR/rexkn?=
 =?us-ascii?Q?qzVCVCRqu0db0NqdtzxXe+ynDRFweip0zgObsPeI/C0jWhR0VoCwOCJrM0cL?=
 =?us-ascii?Q?S3WZ1MgO5JZgvvlXbGL5Tt6lgQDQsuD/fib0KaqRnQMQWKOrxahZQHKVEFml?=
 =?us-ascii?Q?k2S67rEsHLNl9FtEs+UFhXNgJGPTgpPPI00wAshke4bOutef59zpgGBAEdHo?=
 =?us-ascii?Q?/r5DmHqUuVp7XTqyy5uFs7zQfRZKXo5xx+lkgBJS/ScQLUK69s6C8otq64tg?=
 =?us-ascii?Q?aNjEUON7HYfo2EQI18UkzndNk3+zfyYYQeca6ryBq8r0m/4EI73G6hShlPHM?=
 =?us-ascii?Q?vDYhW6pM0MUkzKYgBzjgcYO6Pgcp4eSh7nG6KdNKEZ2vt4oQKSnqBaehByp2?=
 =?us-ascii?Q?OBMD0ys8e9ehvwsqhVf1s3NuZi9o6+GkSApp6702vbrimbHa63493EzO/L6a?=
 =?us-ascii?Q?lz4nt74B1mTl4C3wWNcOKqfr8bULRo5e6+1oiygbNtvJjA8u2yS+B1AG35h0?=
 =?us-ascii?Q?HT3t+VT610DG0XUgw5USlNdZVPYxpJn5Nq4aAttH/FokqUbkZeqU4wUrBpZU?=
 =?us-ascii?Q?Krl2zRdbtrdU7/yhX59Vaj5+Iug4LzR3MfcKDVa1D1sSLkHvtGtSaKfrcEgw?=
 =?us-ascii?Q?p8KeXAg2es84+npUXF3GUWguuUV0ObkOPPVsJSyqknh17qszBAdMG9eoU7qa?=
 =?us-ascii?Q?/Ev6a1mBJhRplJ9nkHzy/PJUkbe2I1LWhkTU3MKHlfKRPcglHvsiQ++OI+cu?=
 =?us-ascii?Q?3ESR22JjANHTWMGn/dQijdJZFIW/lHAKerfFzYfjyNRkj1AvwPBqOvfyNIZA?=
 =?us-ascii?Q?WA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4419.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 691e95ff-affc-4876-4624-08d9b309f4e0
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2021 07:29:19.2100
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z8jCUdZK8o095ywvM6nl3axk+T1xdIfgqKtwgeD/iGbFcRS+f83Wf+kAJA7NKuOveOmilI15xr3nH0j5CT5bKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB4481
X-Proofpoint-GUID: e3zbXYqiaOYWkCjzmV2SczNhadenvYCy
X-Proofpoint-ORIG-GUID: ynpIrGkz0qT91ofg_rTCAvSGBE5Wov0j
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-29_02,2021-11-28_01,2020-04-07_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Florian Fainelli <f.fainelli@gmail.com>
> Sent: Saturday, November 27, 2021 1:47 AM
> To: linux-kernel@vger.kernel.org
> Cc: Florian Fainelli <f.fainelli@gmail.com>; kernel test robot <lkp@intel=
.com>;
> Nilesh Javali <njavali@marvell.com>; Manish Rangankar
> <mrangankar@marvell.com>; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@marvell.com>; James E.J. Bottomley <jejb@linux.ibm.com>;
> Martin K. Petersen <martin.petersen@oracle.com>; open list:QLOGIC QL41xxx
> ISCSI DRIVER <linux-scsi@vger.kernel.org>
> Subject: [EXT] [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT
> formatting
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> The format used for formatting SYSFS_FLAG_FW_SEL_BOOT creates the
> following warning:
>=20
> drivers/scsi/qedi/qedi_main.c:2259:35: warning: format specifies type 'ch=
ar' but
> the argument has type 'int' [-Wformat]
>                    rc =3D snprintf(buf, 3, "%hhd\n", SYSFS_FLAG_FW_SEL_BO=
OT);
>=20
> Fix this to cast the constant as an u8 since the intention is to print it=
 via sysfs as a
> byte.
>=20
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  drivers/scsi/qedi/qedi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h index
> ce199a7a16b8..421b3a69fd37 100644
> --- a/drivers/scsi/qedi/qedi.h
> +++ b/drivers/scsi/qedi/qedi.h
> @@ -358,7 +358,7 @@ struct qedi_ctx {
>  	bool use_fast_sge;
>=20
>  	atomic_t num_offloads;
> -#define SYSFS_FLAG_FW_SEL_BOOT 2
> +#define SYSFS_FLAG_FW_SEL_BOOT (u8)2
>  #define IPV6_LEN	41
>  #define IPV4_LEN	17
>  	struct iscsi_boot_kset *boot_kset;
> --
> 2.25.1

Acked-by: Manish Rangankar <mrangankar@marvell.com>