IronPort-SDR: M7h1n9HlCDF/boduYqOG8YqyQfCBgR8FH2leOUsx/56ZkGeXXr0BCig4ecm2iLkbHossenV7NN
 P2aXsRDSkq4QlZeZDyXYQ16M0S+0W+G5qsXCVZPSa+pyDIZZI63b+sRqeKHZQa0ZbYxvDE2Not
 46X2FoZYAnKiaQ0E4X7rxma83vknz6j/ohk72tE4W9Rb2HLBpUqudBTyWuRCdtXeaFZk8JxJMC
 Qn5+6dFpKDmA7O3io30JXPpY1D8TRvawXunaZwdvpVGvJbnmr1w9A+WxwvDo58TkrjPlLjjZ1F
 a1L7PCpK0zzOPZC4xcgaJ48g
IronPort-SDR: 6TxKquluPSec8akrbNpx2XEU5vRkLEoItnPxPqSjubRPBcTgRyFQBtDFYF8aMV68bMlcqTh+IQ
 QZUkdt2C1zyWUWxxtdGNsjD9+mhYSLpI/+Eolh+QfC0qLUuFwVbCWO5tQgbS3upECuBOXF6eeY
 4xA1uWCidgw37i35NhZyETURhnvmIs8AnLxAjLfgjyxMoLmHrl0WiXTKVlJ67Pj9hhuOMtu5fv
 Zuo7iLs7TJZ9CnzSxSYN++jVfrVQ9GiLfb73ZvMWM06jBuloz3hM9/6nfVT3/WECklS4LgfqJN
 c+Q=
WDCIronportException: Internal
Message-ID: <0b5b3826-2989-8d42-4139-5a9d28582f65@opensource.wdc.com>
Date:   Mon, 29 Nov 2021 16:43:52 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v2] pata_falcon: Avoid type warnings from sparse
Content-Language: en-US
To:     Finn Thain <fthain@linux-m68k.org>
Cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Michael Schmitz <schmitzmic@gmail.com>,
        Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <8f6a78cf7b60160ef3d22445ee1b8f2c0678f74b.1637879659.git.fthain@linux-m68k.org>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital
In-Reply-To: <8f6a78cf7b60160ef3d22445ee1b8f2c0678f74b.1637879659.git.fthain@linux-m68k.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/11/26 7:34, Finn Thain wrote:
> The zero day bot reported some sparse complaints in pata_falcon.c. E.g.
> 
> drivers/ata/pata_falcon.c:58:41: warning: cast removes address space '__iomem' of expression
> drivers/ata/pata_falcon.c:58:41: warning: incorrect type in argument 1 (different address spaces)
> drivers/ata/pata_falcon.c:58:41:    expected unsigned short volatile [noderef] [usertype] __iomem *port
> drivers/ata/pata_falcon.c:58:41:    got unsigned short [usertype] *
> 
> The same thing shows up in 8 places, all told. Avoid this by removing
> unnecessary type casts.
> 
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Michael Schmitz <schmitzmic@gmail.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Finn Thain <fthain@linux-m68k.org>
> ---
>  drivers/ata/pata_falcon.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/ata/pata_falcon.c b/drivers/ata/pata_falcon.c
> index 121635aa8c00..823c88622e34 100644
> --- a/drivers/ata/pata_falcon.c
> +++ b/drivers/ata/pata_falcon.c
> @@ -55,14 +55,14 @@ static unsigned int pata_falcon_data_xfer(struct ata_queued_cmd *qc,
>  	/* Transfer multiple of 2 bytes */
>  	if (rw == READ) {
>  		if (swap)
> -			raw_insw_swapw((u16 *)data_addr, (u16 *)buf, words);
> +			raw_insw_swapw(data_addr, (u16 *)buf, words);
>  		else
> -			raw_insw((u16 *)data_addr, (u16 *)buf, words);
> +			raw_insw(data_addr, (u16 *)buf, words);
>  	} else {
>  		if (swap)
> -			raw_outsw_swapw((u16 *)data_addr, (u16 *)buf, words);
> +			raw_outsw_swapw(data_addr, (u16 *)buf, words);
>  		else
> -			raw_outsw((u16 *)data_addr, (u16 *)buf, words);
> +			raw_outsw(data_addr, (u16 *)buf, words);
>  	}
>  
>  	/* Transfer trailing byte, if any. */
> @@ -74,16 +74,16 @@ static unsigned int pata_falcon_data_xfer(struct ata_queued_cmd *qc,
>  
>  		if (rw == READ) {
>  			if (swap)
> -				raw_insw_swapw((u16 *)data_addr, (u16 *)pad, 1);
> +				raw_insw_swapw(data_addr, (u16 *)pad, 1);
>  			else
> -				raw_insw((u16 *)data_addr, (u16 *)pad, 1);
> +				raw_insw(data_addr, (u16 *)pad, 1);
>  			*buf = pad[0];
>  		} else {
>  			pad[0] = *buf;
>  			if (swap)
> -				raw_outsw_swapw((u16 *)data_addr, (u16 *)pad, 1);
> +				raw_outsw_swapw(data_addr, (u16 *)pad, 1);
>  			else
> -				raw_outsw((u16 *)data_addr, (u16 *)pad, 1);
> +				raw_outsw(data_addr, (u16 *)pad, 1);
>  		}
>  		words++;
>  	}
> 

Geert,

If your are OK with this version, please send a review tag. Thanks.

-- 
Damien Le Moal
Western Digital Research