Date:   Mon, 29 Nov 2021 10:53:14 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jeremy Kerr <jk@codeconstruct.com.au>
Cc:     kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org
Subject: Re: net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use
 kfree_skb() here instead of kfree(skb)
Message-ID: <20211129075314.GP18178@kadam>
References: <202111250652.KJ5iJFpx-lkp@intel.com>
 <0b6aec80835439afe62010a4228fc1af49f68e2b.camel@codeconstruct.com.au>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0b6aec80835439afe62010a4228fc1af49f68e2b.camel@codeconstruct.com.au>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1xr/TYSVe2Nu8KZK0YNTNd7v9YsSSVQ9i7wYOPUMQuds7hswsdGwt8fndVfA?=
 =?us-ascii?Q?NBdDWrQVKCtOMLG3FohqT3v00MasUYY2rLuc7ygTU77t1vHGTKhCYcqrnOsa?=
 =?us-ascii?Q?8mwf09xmITWpzgXazQjCjpHrvyxtucO5yUHY5CjYr1O2cM0P27bvyGlfK53M?=
 =?us-ascii?Q?NQvtY1xa1HLQNHoyPUkmjAlJSTHl05Y/+8yUR+OORur4FVwNecaDo3UoAUTk?=
 =?us-ascii?Q?xx2+Opic+KARiAxyFcJnf9Olasyjyucu7suwiwHPB7aGiZ/QiTY0I5P5AFKQ?=
 =?us-ascii?Q?AipgCElNFzA6bhpCoptS9j7J2bXnWXKhJbeiN0vpifomEOMIZavGiTsUjTA8?=
 =?us-ascii?Q?Ztx/Ql65ylVBc5A0r3i3eNmO6EoCb0LBF1HYAmt5SruweFeCKaYo7Ptx2133?=
 =?us-ascii?Q?LG3OFE14jjm31bZ5RTA7fZ+UP6ifvukq5BUaotvN4gQp7yd+Zmcmjv69WN8O?=
 =?us-ascii?Q?Z7FK0TyUtsX7ob1hAmU8lsdYQQA6FO4hNNcLHXiZ0y+lxgLu54gCMk9o832W?=
 =?us-ascii?Q?pqlslALZdfkhmiSdAy/O8VnHQhIZh+Rb7D4uDjgbcg1l7U4wrSGJMgHjot/P?=
 =?us-ascii?Q?fLfBcqlf3xax89pz7RyFJvlFndoFSHrBBKi/cqCoWi8Rh7SFmbHw7t1WkvQ3?=
 =?us-ascii?Q?L4DWLkw8oxR0gX6AF4bVFuc6oS5qAVrogEcNmhBoZe2Pxq82w6KYv79cAtpN?=
 =?us-ascii?Q?A0a5pqzKyE1V7vzTHJAFddvdoLxJnXvhOYP1xTcc5WXKhwy7n3pjTXJQBEe2?=
 =?us-ascii?Q?oPxcV3TQTS1raEdOgTKAlsb8nlSC+VCF0VA28MXZUJtj/5gvz8UGwynlvLNC?=
 =?us-ascii?Q?lfzEu6DkG6iUD8cmnFLZPRn5WGdlHR2SN30npF1RLQ3ts+oxcFpREJ2bSjwG?=
 =?us-ascii?Q?OU7Y3vBmFDU4hgEH9Xk9ARsVC/78ZHX5s6TXt01hxhjwhTwlaLU0gw4wAM2J?=
 =?us-ascii?Q?MmInfkNPhhrNIIRuK+G3B2AEVknVsiA1eWfDHzp5mcthJnD0IAX4W3AVdBwC?=
 =?us-ascii?Q?MswfMmDYb6APo9wq3uhpmHAqljCCY/YSb/iptcuC0huQSLFSHVZmy/T4kHLw?=
 =?us-ascii?Q?HS1xIpgiJFvefyUH9YeE1pDypnhobL/NNF6xZlmtsguVdj4fcAcRh9n4Dig6?=
 =?us-ascii?Q?XBGEax03sbopXgNZmkzl3jFQbv2xjt4W9CBlH+Qw1/ldr4pIBine2d653O2+?=
 =?us-ascii?Q?RmeLpZMs2g4WlviDd/K69y8I1UrsYEJ4EJgNWnBhqzRbdOr0O1m7HdwpAB8y?=
 =?us-ascii?Q?zB30OZ44WG3zbR/QhkIBbhdJ07SlMMiIgepO2kgO6LaOavqBBCkecT3uQQex?=
 =?us-ascii?Q?hB83CSHq3pU4zDs3jGlNKm7e1UTzaiVQG5Yi4llNtoBuzaRlQfaEInSxqdQj?=
 =?us-ascii?Q?9IKHu9f1p1B6+z42FGnhuhBhYXprc2jGdsa2zxR37QYs1Bdxiusyvi2GK4NW?=
 =?us-ascii?Q?yFvQagyEJ/zsG/gJvE5DLz3Y1xa21/j0pErUGU2jAprBa9JOzl47BxO7aCI/?=
 =?us-ascii?Q?9eioJgeGCfycfPFls924hkUHGVokDPYPEib/m2xsBgbc4tXh4sIaolh1LIh7?=
 =?us-ascii?Q?LPfu4Q5BUP+UyxuzQax1nUYfUxcVKMZTZLlqGSMily6SHBEZHyB7CYtAR4kN?=
 =?us-ascii?Q?LVUDTy0LFKzuyP80qRxd+e37YSaa3LU50IbkXIC/WBAf49eekDO55OxByyJU?=
 =?us-ascii?Q?CFcGMe4JTtEXz1spWfL3Gi6T0BE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02224d99-d1c3-475a-2dae-08d9b30d57a1
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 07:53:33.7652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 04mKKH3z0svbcOXgBWug0CjvqPetDFcI3zub8jQuOcO2LuHKvSVi+/PvUSR/xTh29HaeUG4f69y4HuWtynq7UeCw+jtAuzQ7NLn4HLuvHfo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4513
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10182 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0
 suspectscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111290038
X-Proofpoint-ORIG-GUID: be_jh9Uyhy4KsUB-Oa_sBL6yTSFmXFC5
X-Proofpoint-GUID: be_jh9Uyhy4KsUB-Oa_sBL6yTSFmXFC5
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 29, 2021 at 10:24:15AM +0800, Jeremy Kerr wrote:
> Hi Dan,
> 
> > smatch warnings:
> > net/mctp/test/utils.c:15 mctp_test_dev_tx() error: use kfree_skb() here instead of kfree(skb)
> 
> Thanks for the report! I've sent a fix, you're CCed.
> 
> However, I can 't seem to recreate the smatch warning; could you include
> the build command you're using for these? I've tried with
> 
>     make [...] C=1 CHECK=/path/to/smatch

The CHECK= string needs a -p=kernel added to it or it won't do kernel
specific checking.

	make [...] C=1 CHECK="/path/to/smatch -p=kernel"

regards,
dan carpenter