Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB50C433F5 for ; Mon, 29 Nov 2021 09:50:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348005AbhK2Jxp (ORCPT ); Mon, 29 Nov 2021 04:53:45 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:53506 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245374AbhK2JvQ (ORCPT ); Mon, 29 Nov 2021 04:51:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8BA8A612AB; Mon, 29 Nov 2021 09:47:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CAC5C8CFCA; Mon, 29 Nov 2021 09:47:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638179277; bh=PZc8s3X7+3Fvl9dhdA2WhkbH6WBiqlNGKDPhzYrtWIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tzv6b49Jr4kuLZ6+ooSy3BfBoTQunFcJjbBAWSec5tyFqV0ZSCu84wS3RKWJpnEP9 AR3OCgpIggV/0Sr2tkWchkhheEFuQOpOBFrArIDDBlTYqRcGWfM22mP8/bJeObiy/T gjGKGseU83VL/D1cKOHd/D+rdFXLU7AlqxfHi3S7GmfuHCLL6wotZLHy2VnTVb7jv7 /YoAVBvNtmc8GKfXCNOSNFo9si5UVDh2V524NtAU4wc1vMFSi/utB3nq6DY6UxBUS1 PzuNt2Z0fRF/30rz/HMwuGgtwKNnn/JJvYpvr3WM2NQyFLeh7GHLsIQW3EbHJ7D4UQ FEHb9UzajIiUA== Received: from mchehab by mail.kernel.org with local (Exim 4.94.2) (envelope-from ) id 1mrdGN-000RC6-2W; Mon, 29 Nov 2021 10:47:55 +0100 From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Hans Verkuil , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Nathan Chancellor Subject: [PATCH v2 19/20] media: cobalt: drop an unused variable Date: Mon, 29 Nov 2021 10:47:51 +0100 Message-Id: <22f9904099e3dfd1d245c45a125392b549e142d8.1638179135.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The clock_control value is read but never actually used. Based on a comment at the code, it has to be reset at the function. So, drop the variable that stores its value. Reviewed-by: Nathan Chancellor Signed-off-by: Mauro Carvalho Chehab --- See [PATCH v2 00/20] at: https://lore.kernel.org/all/cover.1638179135.git.mchehab+huawei@kernel.org/ drivers/media/pci/cobalt/cobalt-cpld.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/pci/cobalt/cobalt-cpld.c b/drivers/media/pci/cobalt/cobalt-cpld.c index 3d8026483ac3..fad882459d23 100644 --- a/drivers/media/pci/cobalt/cobalt-cpld.c +++ b/drivers/media/pci/cobalt/cobalt-cpld.c @@ -236,7 +236,6 @@ bool cobalt_cpld_set_freq(struct cobalt *cobalt, unsigned f_out) u8 n1, hsdiv; u8 regs[6]; int found = 0; - u16 clock_ctrl; int retries = 3; for (i = 0; i < ARRAY_SIZE(multipliers); i++) { @@ -260,9 +259,7 @@ bool cobalt_cpld_set_freq(struct cobalt *cobalt, unsigned f_out) hsdiv = multipliers[i_best].hsdiv - 4; rfreq = div_u64(dco << 28, f_xtal); - clock_ctrl = cpld_read(cobalt, SI570_CLOCK_CTRL); - clock_ctrl |= S01755_REG_CLOCK_CTRL_BITMAP_CLKHSMA_FPGA_CTRL; - clock_ctrl |= S01755_REG_CLOCK_CTRL_BITMAP_CLKHSMA_EN; + cpld_read(cobalt, SI570_CLOCK_CTRL); regs[0] = (hsdiv << 5) | (n1 >> 2); regs[1] = ((n1 & 0x3) << 6) | (rfreq >> 32); -- 2.33.1