IronPort-SDR: pC9Mo1j3FSmWnO+dJz+sdo/h8/5YPxGZu/adW1G8JBTs9GQOUA5AIyOTg1I3h6dP4CcPh/+FBK
 14Ts3BA/nMQlFwRz2GP3LA7Ijf6SYeQRGAc7XWTxS9gFODzdLErHNETvd5PHWNQKHds+A6IU+O
 cvJORXOhzGAFA/JNVu49ctwGxj2KJcHlRZfE96tafhPleIWUEzKcUGcB9z7HnAZuL4NO5WDh3S
 W63evdf8YPbcG9b6t0WEN6n0FJTRoSYYoaDdRQvr2txxITgPKrIJ8SbMYiwuqONcE3JNrYCjij
 3Y0VkNrK17hU/S8CxHTXSd8U
Date:   Mon, 29 Nov 2021 11:59:26 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     <davem@davemloft.net>, <robh+dt@kernel.org>,
        <UNGLinuxDriver@microchip.com>, <p.zabel@pengutronix.de>,
        <linux@armlinux.org.uk>, <andrew@lunn.ch>,
        <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 3/6] net: lan966x: add port module support
Message-ID: <20211129105926.4k6itzqakeu7znbw@soft-dev3-1.localhost>
References: <20211126090540.3550913-1-horatiu.vultur@microchip.com>
 <20211126090540.3550913-4-horatiu.vultur@microchip.com>
 <20211126101251.3dceb6f2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20211126101251.3dceb6f2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Precedence: bulk

The 11/26/2021 10:12, Jakub Kicinski wrote:

Hi Jakub,

> 
> On Fri, 26 Nov 2021 10:05:37 +0100 Horatiu Vultur wrote:
> > This patch adds support for netdev and phylink in the switch. The
> > injection + extraction is register based. This will be replaced with DMA
> > accees.
> >
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> 
> Clang sees issues here:
> 
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c:409:8: warning: variable 'sz' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>                        if (err != 4)
>                            ^~~~~~~~
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c:469:7: note: uninitialized use occurs here
>                if (sz < 0 || err)
>                    ^~
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c:409:4: note: remove the 'if' if its condition is always false
>                        if (err != 4)
>                        ^~~~~~~~~~~~~
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c:403:9: note: initialize the variable 'sz' to silence this warning
>                int sz, buf_len;
>                      ^
>                       = 0

Thanks for notification.
I should definitely need to start to build the kernel using Clang.


-- 
/Horatiu