Date:   Mon, 29 Nov 2021 13:52:30 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     pierre-yves.mordret@foss.st.com, alexandre.torgue@foss.st.com,
        linux-i2c@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        fabrice.gasnier@foss.st.com, amelie.delaunay@foss.st.com
Subject: Re: [PATCH 2/4] i2c: stm32f7: recover the bus on access timeout
Message-ID: <YaTNDq7rEyQIopim@kunai>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        pierre-yves.mordret@foss.st.com, alexandre.torgue@foss.st.com,
        linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        fabrice.gasnier@foss.st.com, amelie.delaunay@foss.st.com
References: <1632151292-18503-1-git-send-email-alain.volmat@foss.st.com>
 <1632151292-18503-3-git-send-email-alain.volmat@foss.st.com>
 <YaTE0f9ciy5JRZ3Q@kunai>
 <20211129123302.GB486850@gnbcxd0016.gnb.st.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5hCTBkD/yBfPADtw"
Content-Disposition: inline
In-Reply-To: <20211129123302.GB486850@gnbcxd0016.gnb.st.com>
Precedence: bulk


--5hCTBkD/yBfPADtw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Alain,

> > > +		stm32f7_i2c_wait_free_bus(i2c_dev);
> >=20
> > This does only a controller reset, not a bus recovery with 9 toggling
> > pulses, or?
>=20
> indeed. I might better rework this and at the same time introduce the
> bus recovery mechanism via the bus recovery callback in this driver.
> Please don't merge this patch and I will rework that.

Wait a sec. Resetting a controller at the end of a failed transfer might
make sense if the controller is otherwise in an confused state.

Full bus recovery (9 pulses) should be done at the beginning of a
transfer when SDA is low, though.

So, I'd actually suggest to apply this patch and add full bus recovery
based on SDA low at the beginning of a transfer seperately.

What do you think?

All the best,

   Wolfram


--5hCTBkD/yBfPADtw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmGkzQ4ACgkQFA3kzBSg
Kbb09RAApgWh5w47oO8V4rNkg78h6Cf6iocL3kiEtiG6Gxgcl/INGRIw02rb0eUb
iMfzC1fBQsdhA49WMXjKTaQ3Y/wcp2ecs7j5IF82NuI5S/zYIuuY2OIMcipfh690
UyDdz/5Vkm9dVak14Joaqm/zPhZuyJiIjq/4ncRerM+lfJ2ebS6yVFyAPwd8/No4
M1Vdtz4HG0gL6GIqO4nYOpk7rVBWGxIQaE0FEU9xCB7T8lUbolSdRKPrnhh7E1qx
NfzvvI1+ANmBaPjOD3ITCqW54wWKPhJJmU+0ymuho0qFHwzqRJvJwS/AvPwNxIRZ
/nsgxX2IVT+eL1D8YtxupdIB5o7JhvsuWQ1TlCGmnNpGTKxdNhwtwVMxqPzu+rS+
F14IZTvcQz0eiYu5s+7TGB5l13RlYsI6RT2cw9J0vniY09uFePDxd4xoe4T2l6ca
994KrTvxgJbJM6Up/A9DDbLUJerAbI1TV+rp6VTGH3fOHEpthkw6g+WZwHQgN18p
eW4RrkfKOyhrkMOD66msHgsnc6wcCMatzdWq5oaLkimFAloAtv2Lv6+m7UG+6A6d
X4WPLE4f6OB/RnrC3ntAJGq7mNygj4CACoMJTSSGuDFrmYOeSAaR3lmLFVd+7Mzo
LMdaovdObwqsZgvVyGHQTF7nGRbIlb5zbrP0MgpT9y5fadY8QLc=
=DxgC
-----END PGP SIGNATURE-----

--5hCTBkD/yBfPADtw--