Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8873C433FE for ; Mon, 29 Nov 2021 13:03:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377317AbhK2NHA (ORCPT ); Mon, 29 Nov 2021 08:07:00 -0500 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:43210 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241779AbhK2NE7 (ORCPT ); Mon, 29 Nov 2021 08:04:59 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R311e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0UyjobXv_1638190885; Received: from 30.240.100.124(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0UyjobXv_1638190885) by smtp.aliyun-inc.com(127.0.0.1); Mon, 29 Nov 2021 21:01:27 +0800 Message-ID: Date: Mon, 29 Nov 2021 21:01:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v3 0/2] use SM3 instead of SM3_256 Content-Language: en-US To: Ard Biesheuvel , James Bottomley , Jarkko Sakkinen Cc: Mimi Zohar , Jonathan Corbet , Herbert Xu , "David S. Miller" , Peter Huewe , Jason Gunthorpe , David Howells , James Morris , "Serge E. Hallyn" , Jerry Snitselaar , linux-integrity , keyrings@vger.kernel.org, Linux Doc Mailing List , Linux Kernel Mailing List , Linux Crypto Mailing List , linux-security-module@vger.kernel.org References: <20211026075626.61975-1-tianjia.zhang@linux.alibaba.com> From: Tianjia Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/21 12:08 AM, Ard Biesheuvel wrote: > On Tue, 26 Oct 2021 at 09:56, Tianjia Zhang > wrote: >> >> According to https://tools.ietf.org/id/draft-oscca-cfrg-sm3-01.html, >> SM3 always produces a 256-bit hash value and there are no plans for >> other length development, so there is no ambiguity in the name of sm3. >> > > What is the point of these changes? Having '256' in the identifiers is > merely redundant and not factually incorrect, so why can't we just > leave these as they are? > Sorry for the late reply. This is just to fix the ambiguity that may be caused by the macro name. It seems that there is no need to modify it. Please ignore this patch. Kind regards, Tianjia