Date:   Mon, 29 Nov 2021 13:21:05 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Alain Volmat <alain.volmat@foss.st.com>
Cc:     pierre-yves.mordret@foss.st.com, alexandre.torgue@foss.st.com,
        linux-i2c@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        fabrice.gasnier@foss.st.com, amelie.delaunay@foss.st.com
Subject: Re: [PATCH 3/3] i2c: stm32f7: prevent calling slave handling if no
 slave running
Message-ID: <YaTFsV0sIU6BA0ja@kunai>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Alain Volmat <alain.volmat@foss.st.com>,
        pierre-yves.mordret@foss.st.com, alexandre.torgue@foss.st.com,
        linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        fabrice.gasnier@foss.st.com, amelie.delaunay@foss.st.com
References: <1625062303-15327-1-git-send-email-alain.volmat@foss.st.com>
 <1625062303-15327-4-git-send-email-alain.volmat@foss.st.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="RG6K4j9bMxrgHdVg"
Content-Disposition: inline
In-Reply-To: <1625062303-15327-4-git-send-email-alain.volmat@foss.st.com>
Precedence: bulk


--RG6K4j9bMxrgHdVg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 30, 2021 at 04:11:43PM +0200, Alain Volmat wrote:
> Slave interrupt handler should only be called if there is actually
> a slave registered and running to avoid accessing an invalid pointer.
>=20
> Without this commit, an OOPS can be generated due to a NULL ptr dereferen=
ce
> while receiving an IT when there is no master transfer and no slave
> running:
>   - stm32f7_i2c_isr_event
>   - no master_mode hence calling stm32f7_i2c_slave_isr_event
>   - access to i2c_dev->slave_running leading to oops due to
> slave_running being NULL.
>=20
> Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support")
>=20
> Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>

Is this one still of interest? You resent patches 1 and 2 but not this
one?


--RG6K4j9bMxrgHdVg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmGkxbEACgkQFA3kzBSg
KbYw4g//XCjI9PEPvkuiZI/yOpA/zHmd7BYX//rxaUBeKAIzrE4vHos0V0QweIT9
LBBl2edf9sXervjTrNzs6TQ7GJ69VNTYX1wf4jk8xlezAnmKoCiH7L1pNcHpA2yn
ueBi4NqjH9SRVbO9QzilVRODkillt6LD5FqByeqVJtdlmAjT2dsIwA3xsSGhv5EF
u2aAX6IoWPjIwQaAvfQWu8ZQvD6q8hfp8nvIHZyT5gtjN8cEAWJGxuJTv7mkIpkU
Wwv76pfPVpDeAXdqgMaRfhoWPIF37ptbSX6JZgUFRCf4O3Lub3v7FcYi2ckyBqrS
98Hc7a5zSyYUA5/q1AI35BwTtIbHuZObWjH3KwFThbqUgIwG8YJRlCnK3O/mjb3M
2C6CN0g3B3JuEJ3ds1yNje9i4T1N4hMH0KwozcG6xPwA5sKvB2EOwLZ7Gmo4mYu+
yVVn93mMbiX1qV1eWUi/4g51VSMOSaZt3ncA3B1dsY7dtA0EU4ievewJp3Fkbd60
UxEHWOookEfVneDjqWlRa0cuthoLURSXEgQZPlB7xMJf/dfypkN4Dz6lDCu1XCjc
VZRKR5GvE0IBpCohjqeZpu16PVfouCO2jhR6jKgYH+UJ+6425xjhEMvL/w3OKtfm
foq5rqD+2dAJ4KfbE9ZCPcQ8YqrcFByacDOr4dQeW0M+dc8EQJ4=
=cZpw
-----END PGP SIGNATURE-----

--RG6K4j9bMxrgHdVg--