Date:   Mon, 29 Nov 2021 12:27:22 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Krishna Yarlagadda <kyarlagadda@nvidia.com>,
        Philipp Zabel <p.zabel@pengutronix.de>
Cc:     Laxman Dewangan <ldewangan@nvidia.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Sowjanya Komatineni <skomatineni@nvidia.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] spi: tegra210-quad: add acpi support
Message-ID: <YaTHKuohUNt/hVLq@sirena.org.uk>
References: <1637834152-32093-1-git-send-email-kyarlagadda@nvidia.com>
 <1637834152-32093-2-git-send-email-kyarlagadda@nvidia.com>
 <YZ+ImY1LrvB5a5iF@sirena.org.uk>
 <BN6PR12MB124973BF5CBB4AB35CC59B8AC3669@BN6PR12MB1249.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Y7UU9/U8laDFRwE1"
Content-Disposition: inline
In-Reply-To: <BN6PR12MB124973BF5CBB4AB35CC59B8AC3669@BN6PR12MB1249.namprd12.prod.outlook.com>
Precedence: bulk


--Y7UU9/U8laDFRwE1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 29, 2021 at 09:09:30AM +0000, Krishna Yarlagadda wrote:

> > > +#ifdef CONFIG_ACPI
> > > +	if (ACPI_FAILURE(acpi_evaluate_object(ACPI_HANDLE(tqspi->dev),
> > > +					      "_RST", NULL, NULL)))
> > > +		dev_err(tqspi->dev, "failed to reset device\n"); #endif

> > What happens when this runs on a DT system?

> For a DT system reset handle would be present and this code will not run

This code is really unclearly structured, the early return doesn't
match the normal kernel style and the ifdefs aren't helping with
clarity.  Please restructure it so it's clear that *both* cases have
checks for the correct firmware type being present.

That said frankly I'd expect this handling of ACPI reset to be pushed
into the reset code, it's obviously not good to be open coding this in
drivers when this looks like it's completely generic to any ACPI object
so shouldn't be being open coded in individual driers especially with
the ifdefery.  Shouldn't the reset API be able to figure out that an
object with _RST has a reset control and provide access to it through
the reset API?

--Y7UU9/U8laDFRwE1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGkxykACgkQJNaLcl1U
h9Crpwf+M2lKT8k9MyiOlgGyvbaUGlT/K1iYeMFMcHUTxpJHq5PFnxqGd50jKqLB
OTdmmuNZ+WxSrhirzI+/IrppEbORlp9P1xhrIqTnLYqQZ+2dR9IbxY5OnZ2Usy01
43yPEhfoK69045WPWw9RyQ4a/u+FxI+k+jA/zwbB390VNr0XVoc7JXXHhPhdZy/2
VvcWTJF4Bs2ld4IR/bhQKmMxfR+g3jYACgJl6orlxUPU4GL8Gm+kAVDw+9iT3MgM
C4j3dfKnlh2vB6V5j6roleO7jjst2AhuU8ADzYqFeDfLViMEuJ3XjExr5d6qoFgJ
q8uZgkg7+I21aOg2b3UlEg4KbRGmmA==
=rb4w
-----END PGP SIGNATURE-----

--Y7UU9/U8laDFRwE1--