From:   Jens Axboe <axboe@kernel.dk>
To:     linux-block@vger.kernel.org, Ye Bin <yebin10@huawei.com>,
        linux-kernel@vger.kernel.org
Cc:     ming.lei@redhat.com
In-Reply-To: <20211129012659.1553733-1-yebin10@huawei.com>
References: <20211129012659.1553733-1-yebin10@huawei.com>
Subject: Re: [PATCH -next] block: Fix fsync always failed if once failed
Message-Id: <163819357457.61510.7885347054893018948.b4-ty@kernel.dk>
Date:   Mon, 29 Nov 2021 06:46:14 -0700
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 29 Nov 2021 09:26:59 +0800, Ye Bin wrote:
> We do test with inject error fault base on v4.19, after test some time we found
> sync /dev/sda always failed.
> [root@localhost] sync /dev/sda
> sync: error syncing '/dev/sda': Input/output error
> 
> scsi log as follows:
> [19069.812296] sd 0:0:0:0: [sda] tag#64 Send: scmd 0x00000000d03a0b6b
> [19069.812302] sd 0:0:0:0: [sda] tag#64 CDB: Synchronize Cache(10) 35 00 00 00 00 00 00 00 00 00
> [19069.812533] sd 0:0:0:0: [sda] tag#64 Done: SUCCESS Result: hostbyte=DID_OK driverbyte=DRIVER_OK
> [19069.812536] sd 0:0:0:0: [sda] tag#64 CDB: Synchronize Cache(10) 35 00 00 00 00 00 00 00 00 00
> [19069.812539] sd 0:0:0:0: [sda] tag#64 scsi host busy 1 failed 0
> [19069.812542] sd 0:0:0:0: Notifying upper driver of completion (result 0)
> [19069.812546] sd 0:0:0:0: [sda] tag#64 sd_done: completed 0 of 0 bytes
> [19069.812549] sd 0:0:0:0: [sda] tag#64 0 sectors total, 0 bytes done.
> [19069.812564] print_req_error: I/O error, dev sda, sector 0
> 
> [...]

Applied, thanks!

[1/1] block: Fix fsync always failed if once failed
      commit: 8a7518931baa8ea023700987f3db31cb0a80610b

Best regards,
-- 
Jens Axboe