Subject: Re: allocation failed: out of vmalloc space error treating and
	VIDEO1394 IOC LISTEN CHANNEL ioctl failed problem
From: Arjan van de Ven <arjan@infradead.org>
To: David Moore <dcm@MIT.EDU>
Cc: Kristian =?ISO-8859-1?Q?H=F8gsberg?= <krh@bitplanet.net>,
       linux1394-devel@lists.sourceforge.net,
       theSeinfeld@users.sourceforge.net, Bill Davidsen <davidsen@tmr.com>,
       linux-kernel@vger.kernel.org, libdc1394-devel@lists.sourceforge.net
In-Reply-To: <1168924893.10136.52.camel@pisces.mit.edu>
References: <mailman.59.1168027378.1221.libdc1394-devel@lists.sourceforge.net>
	 <200701100023.39964.theSeinfeld@users.sf.net>
	 <tkrat.c0a43c7c901c438c@s5r6.in-berlin.de>
	 <1168802934.3123.1062.camel@laptopd505.fenrus.org> <45ABC1A2.90109@tmr.com>
	 <1168885223.3122.304.camel@laptopd505.fenrus.org>
	 <1168890881.10136.29.camel@pisces.mit.edu>
	 <59ad55d30701151306q492e07aep9c640afd7b6c442f@mail.gmail.com>
	 <1168896257.3122.577.camel@laptopd505.fenrus.org>
	 <59ad55d30701151343r6f964475tae799185f05aa579@mail.gmail.com>
	 <1168924893.10136.52.camel@pisces.mit.edu>
Content-Type: text/plain; charset=UTF-8
Organization: Intel International BV
Date: Tue, 16 Jan 2007 09:58:04 -0800
Message-Id: <1168970286.3049.129.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1951
Lines: 45

On Tue, 2007-01-16 at 00:21 -0500, David Moore wrote:
> On Mon, 2007-01-15 at 16:43 -0500, Kristian Høgsberg wrote:
> > On 1/15/07, Arjan van de Ven <arjan@infradead.org> wrote:
> > > again the best way is for you to provide an mmap method... you can then
> > > fill in the pages and keep that in some sort of array; this is for
> > > example also what the DRI/DRM layer does for textures etc...
> > 
> > That sounds a lot like what I have now (mmap method, array of pages)
> > so I'll just stick with that.
> 
> It sounds like the distinction Arjan is getting at is that the buffer
> should exist in the process's virtual address space instead of the
> kernel's virtual address space so that we have plenty of space available
> to us.

exactly! and either way the user would need that space allocated ANYWAY.

> 
> Thus, we should use get_user_pages() instead of vmalloc().  I think
> get_user_pages() will also automatically pin the memory. 

actually if you provide the mmap method yourself you're not going to
need get_user_pages(), because it's kernel allocated memory already!


>  And we'll also
> need to call get_user_pages() from a custom mmap() handler so that we
> know what process virtual address to assign to the region.

see above; it's one or the other. Personally I'd think the mmap method
is simpler, because there's less conditions to consider (again, the
malicious user passing you memory that is mmap'd PCI MMIO space is a
"fun" example, but there's a lot more cafes which are... funky)

Greetings,
   Arjan van de Ven
-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/