MIME-Version: 1.0
References: <20211126225329.1150651-1-colin.i.king@gmail.com>
In-Reply-To: <20211126225329.1150651-1-colin.i.king@gmail.com>
From:   Michal Simek <monstr@monstr.eu>
Date:   Mon, 29 Nov 2021 15:50:56 +0100
Message-ID: <CAHTX3d+Sc47Cj7Rs7HxWSLapvwXsWa-1-VBknsFLXBPmEhyRLw@mail.gmail.com>
Subject: Re: [PATCH] microblaze/mm/highmem: Remove redundant initialization of
 variable maxmem
To:     Colin Ian King <colin.i.king@googlemail.com>
Cc:     David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Colin,

p=C3=A1 26. 11. 2021 v 23:53 odes=C3=ADlatel Colin Ian King
<colin.i.king@googlemail.com> napsal:
>
> The variable maxmem is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  arch/microblaze/mm/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
> index 952f35b335b2..f328d4549fad 100644
> --- a/arch/microblaze/mm/init.c
> +++ b/arch/microblaze/mm/init.c
> @@ -144,7 +144,7 @@ int page_is_ram(unsigned long pfn)
>   */
>  static void mm_cmdline_setup(void)
>  {
> -       unsigned long maxmem =3D 0;
> +       unsigned long maxmem;
>         char *p =3D cmd_line;
>
>         /* Look for mem=3D option on command line */
> --
> 2.33.1
>

The patch is fine but From and SoB email are different. Please fix it.
./scripts/checkpatch.pl --codespell --strict
0001-microblaze-mm-highmem-Remove-redundant-initializatio.patch
WARNING: From:/Signed-off-by: email address mismatch: 'From: Colin Ian
King <colin.i.king@googlemail.com>' !=3D 'Signed-off-by: Colin Ian King
<colin.i.king@gmail.com>'

Thanks,
Michal

--=20
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs