Date:   Mon, 29 Nov 2021 15:44:22 +0000
From:   Jean-Philippe Brucker <jean-philippe@linaro.org>
To:     Eric Auger <eric.auger@redhat.com>
Cc:     joro@8bytes.org, will@kernel.org, mst@redhat.com,
        jasowang@redhat.com, virtualization@lists.linux-foundation.org,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        sebastien.boeuf@intel.com, kevin.tian@intel.com,
        pasic@linux.ibm.com
Subject: Re: [PATCH v2 5/5] iommu/virtio: Support identity-mapped domains
Message-ID: <YaT1VvUvpKZhTWvc@myrica>
References: <20211123155301.1047943-1-jean-philippe@linaro.org>
 <20211123155301.1047943-6-jean-philippe@linaro.org>
 <58572359-8232-3204-f69a-7f50b887a122@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <58572359-8232-3204-f69a-7f50b887a122@redhat.com>
Precedence: bulk

On Sat, Nov 27, 2021 at 06:09:56PM +0100, Eric Auger wrote:
> > -			vdomain->viommu = 0;
> > +			vdomain->viommu = NULL;
> nit: that change could have been done in patch 2

Ah yes, I changed that in v2 but fixed up the wrong patch

> >  			return -EOPNOTSUPP;
> >  		}
> > -
> > -		vdomain->bypass = true;
> >  	}
> >  
> >  	return 0;
> Besides
> Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks!
Jean