Message-ID: <6b9ed425-cadb-15df-4c4f-eb1dc0b814dd@intel.com>
Date:   Mon, 29 Nov 2021 11:27:21 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.2
Subject: Re: [PATCH 2/3] selftests/resctrl: Return KSFT_SKIP(4) if resctrl
 filessystem is not supported or resctrl is not run as root
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20211110093315.3219191-1-tan.shaopeng@jp.fujitsu.com>
 <20211110093315.3219191-3-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20211110093315.3219191-3-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTNPMG1XWVY5YlpEdHhDNytsWDI4SkV3Tzh2SmdBRWxqS2Y3SkNwUlBrTW9z?=
 =?utf-8?B?eklLMnpOMUM3MkVBRndrNXBEN2ZSejZUZlZkVzIrZjlpMVNsUnBrd1pYVjRj?=
 =?utf-8?B?TklTSExXVTZZZlZKZkNYeWN3VHluYWFGeEpPU3grWmNCeDNvb3pWN0NWNEhy?=
 =?utf-8?B?ZDlxdFJUS3MvWHpvZTF0TEFMbHhHK2tQbUl0ZWZxUko5YVRvYVA5TFF4UmtY?=
 =?utf-8?B?YTlkcWNHMmcvZzQzajRZU3U4azUveTRZS3VQek5KcG8va3J2ZFF5cDZodHNt?=
 =?utf-8?B?U3kzNFhOY3dDY0Nqckt0K0JnaWFVT3dzWEYyWW1BUUN4L09BU25rNS9uVEZu?=
 =?utf-8?B?enRPVnEwVnRWTSt6TEFSZmJuMFNUVmlZbE9OUngvb0E3eEJMM2N0QTJjNE0y?=
 =?utf-8?B?dUl1RDNjblZQZi9NRkN6ek13aFJjOU85QmNXbXFXV3d5eGxuYTdnQ3dmQVAy?=
 =?utf-8?B?WFAyMEU3WldOaWZtWC9yeW9OMDBQd0g0OHdLTHR5V1MwaFl0dlRQdHRGUTl0?=
 =?utf-8?B?QStUSjFxb0NocVg5NlFUa0Q4S2hQczdxeTBWcUkwOERmWE5Qb1VKNWpuWEdN?=
 =?utf-8?B?UGZZbGYzUTJBSC92bmpTL0ppOE11SEVDZ1VUZXZ2YTBPUG9JKzA2dEFJZWcz?=
 =?utf-8?B?cWNVaUlsRW5iSEJUeFVoT1ZjVXgzWUpGVldGcVhDbG8zSUtwbjZpSld4ekJK?=
 =?utf-8?B?RTNVS1d2REdFSVJNdCswZHhRVTRsWVQxcjNEVEtPL3ViV01kd2wzL0pTTVlx?=
 =?utf-8?B?NUZqWVZIVmphVm5MVjA4bHlOTnFuK21VZ1FPeUNCZ1lyN2VHTE8wcllBdFJr?=
 =?utf-8?B?U1Rrd29kNTRZQkdyemtoOWVpWE9EN1BrNzQ4NnJlSEowaVo3enZiNEtkMHgv?=
 =?utf-8?B?emtTMERkV2ZocDZvd3hnYjExd0J1cnRGYVNrbDk4UUFPa2xhcWxnMjB3K2kw?=
 =?utf-8?B?Z1hXQnFIenRSSmM3UmVpTzFNUU9HeXB5S3gyRU5OODdUTTJ1VDYramppeHZN?=
 =?utf-8?B?eVExNXQwU3RwL2hQRy9LUUJQMk5EY2l6U1R0YzliRDRQSTVhbXpyMXRvdVZG?=
 =?utf-8?B?dEF0S2tDbDBudm8xaWJiUVcraFhnU3crcmpCN2VibDlKZU1nOGpSblAzR3pB?=
 =?utf-8?B?V09teXJhd0hseVBUZmdkdnhQVTdPZHoyaFpWMFhTc0ZobThGTW5XV1A2VS9S?=
 =?utf-8?B?Qmt1SnlCZTNSL0R4Z1EwVlU4MC9EOWl3ZEw0SXVYZENhaElKM0M2SHVVYk1y?=
 =?utf-8?B?R0xNYjBmSkRMS3JpVVE0b2JGQ0lMNzJ5bTZDSHdTbE1BRjlVQkdOOU5yT3c1?=
 =?utf-8?B?TUpSbTJXcjkvWWF5WXhWZk9SejM2VWI1TmpmdTUwVU16TzVNZjdXV214RUYr?=
 =?utf-8?B?dHJzREVxVWdOWXdiWWRuaDAwQmt2TTlnVDY4WlF3bW0wUHJmblVNdHZoMEpW?=
 =?utf-8?B?S2VSd0xaaVRBSWxKb3k0LzBiSmJObExtajNVNjZZa01SdHZEWWNEdVBZbDhy?=
 =?utf-8?B?WjlFZ3lGVnhpLzRVMlBvanR3NHBYK3Vka21OU2dRbjZaL1RXL1dqbmxFY3Ux?=
 =?utf-8?B?VmJqblBtMzJwbVBDaUtpM05rUEdJdHRvNkVydXZRdUQ1djRnL000WjJMdXJY?=
 =?utf-8?B?dEcvNFZicUZHMElNSWJWZ2hGV0ZINVlFcHZTamdRcDNySUF0UVFHVFY4S1p4?=
 =?utf-8?B?Smo0cmJaZm1zTEdMaGttYTc0M2Fya05VOGkvTGcrZXR3TG15VlhiSjljcXJE?=
 =?utf-8?B?V1BMWXFTQkpBekovRmt2S2VVYU5VaStyRnM4YjNvNmk0RUMzNWRhRWFzMFJt?=
 =?utf-8?B?WHdEZWtJRldvTHJwSDRYSE5VQ210T29FZFJqM3p6b3Vqa05yOG01WUZWMktE?=
 =?utf-8?B?aHBkajlYbU4wblh4MUcyekppbkNFMkc5R3AvTUJPcE5TMlI2ZitkT2k1bHdw?=
 =?utf-8?B?ODNrWnN3QUZCVkt2NFUwcWUxVURwcmY1b1Aza2xGWkVROVEwemtVb20vaVp5?=
 =?utf-8?B?VnNyejZXekVLMFhXOVBNaUZqcit2bDgxTm0ydngvK01meXJNeE9JY3lnRTJL?=
 =?utf-8?B?dnZlMFJnMUhQMGQyaThlc1BaRDIrK1l1bUZndFNva0RGOG1rY0gvMDErMUp1?=
 =?utf-8?B?Q2xaZ3hPZUpaMnZoanBKT2x6YVBZWVZLbStRbVMreUQ0OGRmWGV4ak9zNDVz?=
 =?utf-8?B?RHo4Wjd4OHFmcXdEbnRxYU8waG1QYzhuMXlaYjNKQ0hRT1lPT0xSQlFaTlg1?=
 =?utf-8?B?MjBWRDhLQmVNb0dDMmxaQ2crbnlBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 862bfa35-21d6-4dd3-da85-08d9b36e45e2
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 19:27:25.2075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mwwL4Br0f0VQCLngHPTVguIl4MXdAEM7HuRppJQkAmuhWOGEAdkIRjzjNr9OnFPLYtldM5iMyvzJpMNJtjemnJPHwDOwP5+Xvz96TY4U6u0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1844
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

(subject line and commit message: filessystem -> file system)

On 11/10/2021 1:33 AM, Shaopeng Tan wrote:
> From: "Tan, Shaopeng" <tan.shaopeng@jp.fujitsu.com>
> 
> To unify the return code of resctrl_tests with the return code of
> selftest set, return KSFT_SKIP (4) if resctrl filessystem is not
> supported or resctrl is not run as root.

Could you please elaborate how changing ksft_exit_fail_msg() to 
ksft_exit_skip() accomplishes the goal of unifying the return code? 
What is wrong with using ksft_exit_fail_msg()?

Reinette