Message-ID: <08708d7a-4d34-3817-032f-25698a30551c@intel.com>
Date:   Mon, 29 Nov 2021 11:27:27 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.2
Subject: Re: [PATCH 1/3] selftests/resctrl: Make resctrl_tests run using
 kselftest framework
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20211110093315.3219191-1-tan.shaopeng@jp.fujitsu.com>
 <20211110093315.3219191-2-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20211110093315.3219191-2-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnhBVkIyMXhzY2lSVDJpOEFoZVN4dnNXMHhnS0E4aXJ0TTdQWTRBdlR3TWxu?=
 =?utf-8?B?WUdtQXlOQmlqemJTQnk3cWdJNFZMZUN1UkgxdkwvaDk5YUJ4L0lCNEIrSjVI?=
 =?utf-8?B?V1dYeVAxczRxTXJaanhRRFRQTTRNeHpsZkdOVHNrUkNzN0xOc25ScnJlT2x1?=
 =?utf-8?B?ckVyL1pHY21hNG5JR09OUlUvN0w3TmhkZU5SREMza0RLblJ3dy9OZHpBbVVX?=
 =?utf-8?B?VlY1anBFWGNuQjR4d0ZFZzRJSkRTVENwc1lRV2QwRkg5VmV5Z3VjbWhpQllS?=
 =?utf-8?B?UGQrenAzaDBxUDZQUUZHendqeXZxR3A3bzI4NEhMVHV1ZkYvbFVHRktiTG9K?=
 =?utf-8?B?ZmRiSTUxc3dTaDh1dCs0cUkrejdOd2k4VjVKYi9vdVI4RDJwL21KUUxEQjBs?=
 =?utf-8?B?akI4Mzl4UitlcC94VXlKa3hSTE4yZFBtYnBRa05FYkFXOC9YL3FJVTJtaDYy?=
 =?utf-8?B?YVpMMlMrVFJWaXAvY010a2hRTFgzM3R4YTNPN2kvUEI3NWRncEtyRHVkMGtZ?=
 =?utf-8?B?MURKN1JmTERMS2FHUS9CcjY2SUxTRzl2R3hvQzRIMWNNUUU1Rk9qaHFyb0lj?=
 =?utf-8?B?Vnp4RWJaakNEMFJ6cUZzU2gwZGtoZVBXYkRTNFJ3b0FTUGQ1UmpORzdQZHZh?=
 =?utf-8?B?elZkQXpaN2ZObm9xQTB2R3NFS1dXRkxUNVdsL0x5bWNGZWduYUJaZ3FHcGNz?=
 =?utf-8?B?bkllQVJJOVV1T2tmOWNlQkd1enYvUWxOQkoyT21JWDQyd3BONDhzZU5pK0xR?=
 =?utf-8?B?dkdmUWVscEl4NkcyODRLcElLZkhxSnVBU2ZPQ29lekIvZHNMNVU2ZTBoWFlP?=
 =?utf-8?B?TldZOVd6RjJVTGJ3ZEN4LzgwR3ZYdnJSeS95OHdEbGRQbVIwQndGMHc3ZEhx?=
 =?utf-8?B?eEEycXN3dmQ5Z2UrOE8vL1dXaXpxV0Nxb29IWmxmcmF2dzRIaFFZWloxaWUx?=
 =?utf-8?B?dHNHRUkzOHpuMWFKWHZpbUNOck91WExMOHd6WGJhUGhCNFV3emloVzc2WjZy?=
 =?utf-8?B?dDBISFA2THIzN0VKdkZOWDdpNWpFdEJ0VzBWYlFnOXoxVVB6Y05HemlpK0k0?=
 =?utf-8?B?UnR3UXZJUGpWdHBoT2pjMEtQMG55L2E3VitzTUtVZldVQTcybUljRWhHdnl5?=
 =?utf-8?B?aDF1d2RtcnRSYTVlTDJOZ3pDUkZjTkVPTWtkdi9nY0xWbU1lb1kwUjQ2RmRw?=
 =?utf-8?B?NFVjdG1taDFFZHdReDU0NXJsRmcwV0ZkRnU5RW5MeldhUE1nT3EvQmVxTjNj?=
 =?utf-8?B?MHN0K282YVhZL1RLVVk2SWhXa3JRaFBMMlV1MkVNcFFISkVNODJEdUg2VDdE?=
 =?utf-8?B?QWJMZEdUdEU3ZDNHTUZqOFNyaVpJUlR5THpyNC8yTGRvd1ZvemhmOXVud0hx?=
 =?utf-8?B?alBVK01iQjZLbkw4a204RGNrVy96ci9wcmUyODdtR0lvZ2JGdHk1eGpuaTV1?=
 =?utf-8?B?Q2E2YjJYUFBZZE8yWVBlSGM5V3hMM0IxVTUyZ3pEWjh5ZWg2bzR6eWh5anZj?=
 =?utf-8?B?R1k1RTR5RnRXbm1nZlE1aTI3djRPUEtsQVZPUFhXRzl4QU0rbUtVbVRmNGRp?=
 =?utf-8?B?VUxzOVlZNU85M3B1UCtoeHN2L085R3JwNVp5V05vYkoyNE1ickMwK2VENWlp?=
 =?utf-8?B?SWI3VlBDMDZhcWM3S296RzlJVCtiMWkxMmVxYVk1b1hCdWkrRytlM0d1emJS?=
 =?utf-8?B?T0h0TXV6TjF1RXZNNUxpNmFxQTQwaDJMcFo2N3FsektaUDJiQThQNVRiOXRC?=
 =?utf-8?B?RktyZXdMUi9LRXpWbTY4Zy9Qd2VoVitWKzNPdjFPeG9xK3V6R3FPNlZYeEdF?=
 =?utf-8?B?RFBxQnBzVFFVVjRyaCtXeFFNZ2pEOVdnVEgvTURIS08zMmRTdHRXMUQzblV2?=
 =?utf-8?B?QTBla3NMRnJEM3RLd0JsYjlrRGg2dERqRWRUNDJBV1lFYjMyRk15T2Zrazdr?=
 =?utf-8?B?bTZFZDRGRDdNS1RSYm02a002QU56TzcvY0Y4ZnRQRVMwODJvUUJ4SENjV1J2?=
 =?utf-8?B?OGl2TUdCaUx0RFZReXYrZFVEWnVrRlhMb0FsQzY4c2NpQlgxTjloNGdleGo0?=
 =?utf-8?B?dzdlNnMwUzJKb0ExNkxNZS91Nis1cnIrcjBMdjJ0VWpKVkFoNGoxNXVINXpv?=
 =?utf-8?B?SVpiby9hWFdPOTJHUnNMaVgyV3VBNjg3ZnNHbWx1Z3hOazY0aVBzTmJjZkYy?=
 =?utf-8?B?TGpYb3V3TjlNUmUvZ2lVc3J0akNSbTcyOWpIMlk4YUsrazFseXNaZnBLMkIz?=
 =?utf-8?B?YzloTnhQWktuNjV0cTVROGtwb1VnPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b7977a0-396f-41cd-70d5-08d9b36e490c
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 19:27:30.4913
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /noPhxtw4kE0+qwp78U6fQV8oniQDxmOe8zy7ykqcVUXUOxI8Rs7PKx0ABYcbyv5NolzJqB58blLKDGl+u2JFNOiQAvMZJ/5qZoaSt2OgBo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1844
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

On 11/10/2021 1:33 AM, Shaopeng Tan wrote:
> From: "Tan, Shaopeng" <tan.shaopeng@jp.fujitsu.com>
> 
> This commit enables kselftest to be built/run in resctrl framework.
> Build/run resctrl_tests by build/run all tests of kselftest, or by using
> the "TARGETS" variable on the make command line to specify resctrl_tests.
> To make resctrl_tests run using kselftest framework, this commit modified
> the Makefile of kernel kselftest set and the Makefile of resctrl_tests.

The above sentence mentions that changes were made to the resctrl 
selftest Makefile but it does not describe what the change accomplish or 
why they are needed. Could you please elaborate?

> To ensure the resctrl_tests finish in limited time, this commit changed
> the default limited time(45s) to 120 seconds for resctrl_tests by adding
> "setting" file.

How is changing the timeout related to the resctrl framework changes? Is 
it not a separate change?

Thank you

Reinette