Subject: Re: [PATCH] fpga: stratix10-soc: Do not use ret uninitialized in
 s10_probe()
To:     Nathan Chancellor <nathan@kernel.org>,
        Moritz Fischer <mdf@kernel.org>, "Wu Hao" <hao.wu@intel.com>,
        Xu Yilun <yilun.xu@intel.com>
CC:     Tom Rix <trix@redhat.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        "Dan Carpenter" <dan.carpenter@oracle.com>,
        <linux-fpga@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <llvm@lists.linux.dev>
References: <20211129161009.3625548-1-nathan@kernel.org>
From:   Russ Weight <russell.h.weight@intel.com>
Message-ID: <41939d45-76ef-e59f-135f-b5c05cd4f5e5@intel.com>
Date:   Mon, 29 Nov 2021 11:24:26 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.14.0
In-Reply-To: <20211129161009.3625548-1-nathan@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXhjWE41OWlGakFVZ2lQNlNFeWJ5cDhNbmx1cDNzS2w1b3lKZXcrOU1COFd2?=
 =?utf-8?B?cDZZUWJwdVNvQ1BoYkMvN0Y0TUEvOWRiaGY1bUtXckU3cm9NVkJpSWpxczBJ?=
 =?utf-8?B?UlFmYVdKTmJlakNxUHpvd0MxeTVSRmlJb2RxYU5mUy8zTFdzUmxsZWpXa0p5?=
 =?utf-8?B?Ym1CYWlhWEZ6NXJTVWQyMHJjbE11NTJ1TkgwUFZHVzBzc2tjYW1Oc3ZZZm9O?=
 =?utf-8?B?QzVpUkhkM3VmdUdPSDViWkxlTTIrNmJ0VktQR3pMMXA2dWgwb0Z2WXIvMjd2?=
 =?utf-8?B?RHRTUGVzcExwWXBLYVg2ajJObzhBQ0dabk4vWE1ERXpFV214ODVyeklkYjRV?=
 =?utf-8?B?REI5RnQ2SXhZWVdWYVhwRWpBejdPblV3elM5bFlvemhWSEQ3L2tmcVgwU1Rr?=
 =?utf-8?B?N0YxUWE1WFl5RENwZENRZnRnM2RtUHFUbXRnVHE3VjFoT01ZSjFjZFVjR1RT?=
 =?utf-8?B?Zk43V2w1WkYwckpGT0NPWEozR3V1TE5VYzlNaDdBWkN2UW1Kam1QcWw0emFq?=
 =?utf-8?B?cktMdmMySjRIdzVIakM5N0c0S1gvM3F5YmpnZmpjNk4rUzJUSTdLZUZaVlJz?=
 =?utf-8?B?bHRSby9uVGlKbUFteFVTZExKN2VURmZ4cTYrVnNTM0wxNHJTOVQyUS9pTCtp?=
 =?utf-8?B?NGt5bXZuZ285bC9aNHpqYW5lc0NDQVNlaExkc1NUdGIyZ2kxYjQ0dE83THB2?=
 =?utf-8?B?ZGlXSkorNGZta1hSaTBzeW5VaTR1WldCbnZMRlZnL0luTDhabVFlckhIZVh6?=
 =?utf-8?B?NGFJTkVWdUtIN0h3cVQvRCtHYXZFdDJkSUhab1YvcmQzTjdZdkJRbktWbXhK?=
 =?utf-8?B?TUdySW1WcGZ5NGdVbC9oTEVPcHE5MjlUbTFPNkhMcHR1bUM5aEpkSkZRU0RX?=
 =?utf-8?B?Y2QxemV5WnNjbGlHSHpJSkE5SXNGRGpsbHg3NW1kM29wVDJPU2VCdlNLNWJ2?=
 =?utf-8?B?RVJZU2t4SXBXRGNBUGJERWNPYis0bG01bUpranJ5UWFYb083QzE4UHAxTFNI?=
 =?utf-8?B?bVFpUUVrcUNYNGJhMlUyY2pKYUxUTU9USUdTaDQyeEFQVGt6WG54bm9BeUtF?=
 =?utf-8?B?NXlYMVJUR0hVU2FoWm9GRml0WjFOVUJEeWpQQlhSL0ExRGxNNlp2eTQ0TFN2?=
 =?utf-8?B?dVo1blpnbVRRK0E0Q0g3S3RhK3NaOTVkMTRTbWxsVy9KMktqbVNVQzI1VkxT?=
 =?utf-8?B?SmVhSFIvdHZKSUFNVHNTRnZhbktpWlAyeU5HZXUrU3JMT1RMVUIvc0N6cUY5?=
 =?utf-8?B?cytudTVFZmFOTXNWWGs2Wnl6VStGekVka2lORlVlTHF4OEU1RmExeW1nTzdl?=
 =?utf-8?B?eDNXdGRscFZYSmlwYjB0NzRCOTQrY3RKTW9UaVdiTTBBMGNJa3VrNmo3dDBC?=
 =?utf-8?B?WStHdkpubFJTS3hTMkdRSjY5Yk83ZG5NNDNjdmt0YUR3OUNIS1hVdTU2S1p2?=
 =?utf-8?B?Rmt2dFdCa2cvemRoalFsd1ZmZTF1STF2WFNyblRkSTFnbGhyU0ZCa1FDbVJF?=
 =?utf-8?B?ZWk1MklOa1phbjJlVG4zQi9pSGdoZks3eER3WkUvaVpWTzM2WGZ1QlRZLzRT?=
 =?utf-8?B?YUFPWDdZeWdyckMyekcycDU0UUFYUUswSURZOGxaNUVlWnRnSmZ0WjZJKy9Z?=
 =?utf-8?B?MGVVWHVQaG1kcllPYmd0Y0ZjZXgrTXl4UTVuNmdjVDFaN3ludDVmUW44WVBh?=
 =?utf-8?B?NytzbDVhSkRQV0hNN0V2REdack11Sks2MndKL2lYOEx2L0pEaVNWTjZ4dDZK?=
 =?utf-8?B?WjBGZVlFa0xPd0Q5cGRTVU5XNjdYVnZJM0EwcXBINzFjMWVxem5iT1J2c3da?=
 =?utf-8?B?MzVjenlRQlZCZmxMNEp1VUM2ZHdmWENNZlRHcnd2dGNobk05VWJLdWJMYVp3?=
 =?utf-8?B?dFNxeklyL1M5dnZLakYycnNDN2IyY245WU5lR3dtanNQTWkxRldWbk5YTFlD?=
 =?utf-8?B?cTdKdS9JSEN1QU1FVmh1U2Iwb1MvK294STdGUWY3SWdCS3B5T3c3NUxNZmV0?=
 =?utf-8?B?aTNxdFVhalVEc200eWwyekhjK2tsUlc0Z0JrNThvK2hTdTh3dWtNdTg0U2J6?=
 =?utf-8?B?aUZBNnRpbjRrYUczWU4za2cwVE1WcS93aTgvSEQ2elBBSlBOSlRpdG5BU3E1?=
 =?utf-8?B?SUlHRzM0aGRVMkdBd200Sk8rckxlRHlJRk92akMvT3JLVGNMSWRvRVVRbzFs?=
 =?utf-8?B?amQ4Z1RFNU9JcGFOWHRNSWtXUXZrOWJJdmhZM2l1MEZWSHZNQS9oRkVOUXVH?=
 =?utf-8?B?QzIyaWc3R3Rwbm96SWVQbHFGTTVRPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a8cff057-9b38-4269-b2ad-08d9b36e0291
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5163.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 19:25:32.2852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BM9+gA5DyFryj6/pMkqW7H9rZfiyXTt9C/T3mPIYfWqkjQ979uU+pXwggEtY91YGxsgg9zhk999ofk5KyPKsibUH8HXTOrRRE9KBm/vboOI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3405
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Russ Weight <russell.h.weight@intel.com>

Thanks,
- Russ

On 11/29/21 8:10 AM, Nathan Chancellor wrote:
> Clang warns:
>
> drivers/fpga/stratix10-soc.c:431:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
>         return ret;
>                ^~~
> drivers/fpga/stratix10-soc.c:402:9: note: initialize the variable 'ret' to silence this warning
>         int ret;
>                ^
>                 = 0
> 1 warning generated.
>
> ret is only assigned in an error path now so just return 0 directly.
>
> Fixes: 4ba0b2c294fe ("fpga: mgr: Use standard dev_release for class driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1517
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
>  drivers/fpga/stratix10-soc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 737d14c6e0de..357cea58ec98 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -428,7 +428,7 @@ static int s10_probe(struct platform_device *pdev)
>  	}
>  
>  	platform_set_drvdata(pdev, mgr);
> -	return ret;
> +	return 0;
>  
>  probe_err:
>  	stratix10_svc_free_channel(priv->chan);
>
> base-commit: 8886a579744fbfa53e69aa453ed10ae3b1f9abac