From:   Mike Christie <michael.christie@oracle.com>
To:     geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com,
        hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>,
        Christoph Hellwig <hch@lst.de>
Subject: [PATCH V6 01/10] fork: Make IO worker options flag based
Date:   Mon, 29 Nov 2021 13:46:58 -0600
Message-Id: <20211129194707.5863-2-michael.christie@oracle.com>
In-Reply-To: <20211129194707.5863-1-michael.christie@oracle.com>
References: <20211129194707.5863-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l3NdoDiimHIeqA6JVtLKuBSaEwIrOR+G03DSdxdIEz/6VM8njrRNKdlgPRcs?=
 =?us-ascii?Q?cMRjhKyIb+SMMO++Pkp/b215xRW6rm4Il/Vno0s9U1tfPIyLJ/cxz7NDbAnW?=
 =?us-ascii?Q?WCFR+tf3h8jrCdVsWRBI8PpjgvGq0neXLuuHg5tpV/raw2saCkDcxEiWh8AN?=
 =?us-ascii?Q?ufhJG6EddY8FukhAEGaHQjt2OpwHiFSfmm7MxdR4NlL7FMsFGTdeZhFjORlU?=
 =?us-ascii?Q?sr4rioY0WVeQYBfV4SsKdVH+tsRTHjhiAZ1uHFfNRq2wkcisop2ACk3Q7SmI?=
 =?us-ascii?Q?KuPrv1wy6RG1f2yDTGiFidW+H1JjIw7bmAsFob7ku6dDj+DKTiFQcx9Ba5Tc?=
 =?us-ascii?Q?dBWc9YPtEXCVxI2LD8ribNfuBeLFAWboTmNbVPDPvu1nZXYmm7Fl6JUvwklw?=
 =?us-ascii?Q?mIVM4tEOlMs/tdZ3eM1IjU7HMATrycTyZJqik6Mpl9A8NQ3ybEHKFq5TzQlc?=
 =?us-ascii?Q?XUb8Efkf2awIzT/DlPVrCyZgmhjtHAp5BqbdkPrJt2lYGkp3Wldn2kNYSM2b?=
 =?us-ascii?Q?cfV1oNK6YzE3RNxH+EWkFMTZ0jhWWGJ/ppC77ytLIUYF8a1/pzLehubZ/MqT?=
 =?us-ascii?Q?la4MBbEZYW51U5xpZihjxZbEuaicJzHdPPz8kxNPDT5L1p0WaFOtpm0U9Ngt?=
 =?us-ascii?Q?y2md7amDqfRVoeDmfbCzq+z3ntDY0/8qdBPqUF7/OjQkW/tEYt54INtrYjOJ?=
 =?us-ascii?Q?OWko5ER0ScTcYgQvVyWiJx+rfise/xpc6Qf/JnI+shSp0xPtUEMI7CXMujJH?=
 =?us-ascii?Q?VhfUEFoXY8NaFDofmT+MGgrAMu60RBF7t6qURDtOQOYlm844G9VAOrNcFkEE?=
 =?us-ascii?Q?fH/PSgDQTgEJMYpruk7egeZt/9EyI3ujVZVWENvhzEa5OJ3PnnERA1o2CcNL?=
 =?us-ascii?Q?1bzA34cXNKlfAp68JfJl/WBxXWrF4t+DbLroDaBMQFs88B1176/dMC9sJxxa?=
 =?us-ascii?Q?ooLAPswaxThniKvb/ggYRONdbgZGXMieAHrlMAucqALB8lgit9ULVp70PHuY?=
 =?us-ascii?Q?W4v6RCJEnn4GAXXW/zvn6Tw5HwYxaarUhwW2KQUOaGE3RsyPwP7Ebau4ZUr3?=
 =?us-ascii?Q?FkTfMpSDsKciq2nph5bgP56cKQMl5hlMdNqp3ADc+s8SxvRuBG3a6H3SSC8Q?=
 =?us-ascii?Q?fHCKS9iIqDJi3ziZgh9EPtss3ZzZSjdTbxQ0nl5/xD9DwdmTfQXYwmTizhDv?=
 =?us-ascii?Q?1Uf8/ciJYQIqE3Ro+J7lWvtmpaqdSH7x9sJTY9NpxveZToEdyq1oL/ptyl7K?=
 =?us-ascii?Q?LB8xawPuAJkmpXEbWKW88bHAiKk62r6zu55yuHERC3eQ6oDe4MNEqJ16aExA?=
 =?us-ascii?Q?RTAHJZm6USamv8tmKNartVvygxCYj1e3wmU60iSKqAL4SAtyQfO63+BBLAzQ?=
 =?us-ascii?Q?xV+9elGXDBvz7wS4GElJ6ysysXfOog4uiZdJHSDX6barWPumg8zT4RIShOEL?=
 =?us-ascii?Q?bQiEBrxIYVMYey3qLZyCBDlUP45I/my41hLRapgjO7OAXwjiz+ySNfce3uAo?=
 =?us-ascii?Q?oYGDmlSxTCEoifBRmxprPLf6wCORBfpaMnGWSLgbTNRkdczXbrESJ99pm84z?=
 =?us-ascii?Q?qGBVUr+tPpVTbZZnEhsVMclGftI1dVg6zyUjwOsb9L97878i1yk4WaR0I6tY?=
 =?us-ascii?Q?eA8d6oEHRkVL418WDvZBON2oDmkPv4RqeTWoZEhkdi79mr+iS4+KnnPrxRGE?=
 =?us-ascii?Q?is/F8w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4aa25c57-90f8-4a60-e285-08d9b3710c12
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 19:47:16.6315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bfQ9gDJROhw5BqX2ONOZ+yV4GLhu0WcAlRx4/yYolmMuxrZoOLunP043sWrx4ZNUBJg6q/1UNz1kU6z0THScWQjsA9EGVbeN1Ji9pq0MEIo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1307
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111290092
X-Proofpoint-GUID: HCMBK9iL5YiZvYee12F0HTBoRfc8GeK7
X-Proofpoint-ORIG-GUID: HCMBK9iL5YiZvYee12F0HTBoRfc8GeK7
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patchset adds a couple new options to kernel_clone_args for IO thread
like/related users. Instead of adding new fields to kernel_clone_args for
each option, this moves us to a flags based approach by first converting
io_thread.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Suggested-by: Christian Brauner <christian.brauner@ubuntu.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/sched/task.h | 4 +++-
 kernel/fork.c              | 4 ++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 058d7f371e25..65d5ec3a8a04 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -18,8 +18,11 @@ struct css_set;
 /* All the bits taken by the old clone syscall. */
 #define CLONE_LEGACY_FLAGS 0xffffffffULL
 
+#define USER_WORKER_IO		BIT(0)
+
 struct kernel_clone_args {
 	u64 flags;
+	u32 worker_flags;
 	int __user *pidfd;
 	int __user *child_tid;
 	int __user *parent_tid;
@@ -31,7 +34,6 @@ struct kernel_clone_args {
 	/* Number of elements in *set_tid */
 	size_t set_tid_size;
 	int cgroup;
-	int io_thread;
 	struct cgroup *cgrp;
 	struct css_set *cset;
 };
diff --git a/kernel/fork.c b/kernel/fork.c
index 3244cc56b697..6effd839d566 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2023,7 +2023,7 @@ static __latent_entropy struct task_struct *copy_process(
 	p = dup_task_struct(current, node);
 	if (!p)
 		goto fork_out;
-	if (args->io_thread) {
+	if (args->worker_flags & USER_WORKER_IO) {
 		/*
 		 * Mark us an IO worker, and block any signal that isn't
 		 * fatal or STOP
@@ -2524,7 +2524,7 @@ struct task_struct *create_io_thread(int (*fn)(void *), void *arg, int node)
 		.exit_signal	= (lower_32_bits(flags) & CSIGNAL),
 		.stack		= (unsigned long)fn,
 		.stack_size	= (unsigned long)arg,
-		.io_thread	= 1,
+		.worker_flags	= USER_WORKER_IO,
 	};
 
 	return copy_process(NULL, 0, node, &args);
-- 
2.25.1