From:   Mike Christie <michael.christie@oracle.com>
To:     geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com,
        hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH V6 05/10] signal: Perfom autoreap for PF_USER_WORKER
Date:   Mon, 29 Nov 2021 13:47:02 -0600
Message-Id: <20211129194707.5863-6-michael.christie@oracle.com>
In-Reply-To: <20211129194707.5863-1-michael.christie@oracle.com>
References: <20211129194707.5863-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?txr98QuS0FRQCYRN17U59QXJGkyGnT/XsFDSPpzsZ84ivJ/fy6QKMmU2I4IU?=
 =?us-ascii?Q?ycf7csHC77RFpqyNe5eJFHfhSCtsKOZqChdtTNUYA1GIFqAR0Uy1YXd7sgoq?=
 =?us-ascii?Q?ULhUs02Q7Wf9ZI6D4MBEDcIzFVC6NIfoWuFBKSeE6mbGb9p0lpruGcPE61rP?=
 =?us-ascii?Q?ghreoCNKUASzk8pU6INy3ZMLTqKyNcFuELC9iSG8WKLR1GKU6kGQPxiqIgnG?=
 =?us-ascii?Q?Q+Pd9blVIAL3tvN1X74rCOQuQslQmgbRqkRUuuYUEZ4nO2Eaq1nVhK8jEJaN?=
 =?us-ascii?Q?4wYNWoXIKVJNwsOyu1N9vVpiO9irCcXXJKe+sy+sI7//DG3iSuTT3RC+YWVF?=
 =?us-ascii?Q?zEYcA7IgG0QhVcEvSS6LW2IosrpjJZW6tHT0NpNWGg9TafmDuQVAx36OuEAb?=
 =?us-ascii?Q?yBl+8Rnz2llZvUFpGpu6UY4d+FBLna61qTTKhZq0chHbZWPV77d832AjI+T6?=
 =?us-ascii?Q?Bic5rxq+/LkIPHcjlVADZLsHyT67jrCtEo1ViXldpvaJc906RiWd97+F2LNQ?=
 =?us-ascii?Q?XDLnX5p5CB8XYqIJPCTEx7+xJ/vUrh7tO7C2p0baKSKA+LWq4TE+leMwFCO9?=
 =?us-ascii?Q?tYNND6n5BnGmGZeVVZANvS+QDyQu28/hxBRKHTrvdD1IgFmofx5mYAhFcaZU?=
 =?us-ascii?Q?HzMUFtkRhTzcHlD2aPlCzNLLE3Qb48U3t5uM1xeQ9Qqx7uwJlCp8IWY28HcN?=
 =?us-ascii?Q?5QFiu7jWuFsFVG/76kAp8rBcZojXuHWeenAmViOcSbG+OPd/dH9FyVXF+mBy?=
 =?us-ascii?Q?IAZEYXn5NrtuXicLkwaD5XH7UAoF/xZyTyF9EYCIDFwTCXU3ZbJ+QHDvAO3P?=
 =?us-ascii?Q?Zej3rgb7Rm3zj131bZdx1Az7EF/AJWH5jmMChydQXyd/WQxhGwyyiSKt5Abu?=
 =?us-ascii?Q?iS/uX9L27HC3NPyWCfivfKHROVEHhiPazbaOrKy+YNKgQA84hpRdgt8OxDo+?=
 =?us-ascii?Q?Lqct4bNQ2qqkH7gM/JUsHpmhG04r7zRfuDkVTdUgMMCvKwbxFZ1L2Tp/2XCe?=
 =?us-ascii?Q?8/c/jIzJ6EBsIr0H2Y3SAX81Rc6Pp0IrPaepUM0X8vigtXB0pLbi5hglzI60?=
 =?us-ascii?Q?qchW/WG9r/LuottzFJJ0A18++DDeUfgMF2ky0PKjhXXmwbswpRflZe5MuoiM?=
 =?us-ascii?Q?VbSQxRR3XHOEqyywJeLunCGUO1AiZLcgJlb7inxFi6AT3jjkszHKABvasNKa?=
 =?us-ascii?Q?uhzjTDVG+IaJF3FsdlqCqwqTj++m/CRz5fDIZUzhFNfdF+JuaNRhRr1BotBr?=
 =?us-ascii?Q?hSZQks55vWEMiILT/7P9wOsRAG/R0avJvxyjR1Sc/RVwiFcyTtj6jQdR+02B?=
 =?us-ascii?Q?qRzV/KudFe6mSOi/ymvHEUExcglBrmfZbuSGIuXBMu0wJwiULH6XFMbeKDsj?=
 =?us-ascii?Q?Gbth1BPfLaUjFVmwUUapfNvFPJcFvjs+ECbEJNFmnlLv5viHhYGtwKEt454K?=
 =?us-ascii?Q?SWPWQdUHx5LITYO8HS6wkS2XlRt+QIEboOurTyq7B97pC5emPRYhO7UXBLg8?=
 =?us-ascii?Q?Zp5HX+kE8VDTzr81poxKNNTQzj9UfiD5cyFbSgTwUXqLzeY8JeIoOrHCErBw?=
 =?us-ascii?Q?qFCoh/uNiK6G/KEdphgn0i2j7mIS3Qekhl8BmKMTRXDn6sSgXRo6RxrBAe+I?=
 =?us-ascii?Q?G+Lq6/aizehpBgoQVQWuRFn/KZPh/NHxXIeLzFQ4SmwltiRu9dgeduv8nhJk?=
 =?us-ascii?Q?jqi9Ug=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66efda5c-8e4f-4931-4c37-08d9b3710e83
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 19:47:20.7537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5/vQcVq5rkb9xgMqYfxVqxO3OwGcx+PcGVFHdQrZNL+2ZenFxw2jvbLlwoxYmosxT9cE+msTMvMxRLbJBtluuJ9qbjlWOD/jSxd9fAbuRqo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1307
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111290092
X-Proofpoint-GUID: UVyqP-tiHiTS7zV0s2ZZCijEvF_0lVsY
X-Proofpoint-ORIG-GUID: UVyqP-tiHiTS7zV0s2ZZCijEvF_0lVsY
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Userspace doesn't know about PF_USER_WORKER threads, so it can't do wait
to clean them up. For cases like where qemu will do dynamic/hot add/remove
of vhost devices, then we need to auto reap the thread like was done for
the kthread case, because qemu does not know what API the kernel/vhost
layer is using.

This has us do autoreaping for these threads similar to when the parent
ignores SIGCHLD and for kthreads.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 kernel/signal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index a629b11bf3e0..4ce2cc195269 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -2071,9 +2071,9 @@ bool do_notify_parent(struct task_struct *tsk, int sig)
 
 	psig = tsk->parent->sighand;
 	spin_lock_irqsave(&psig->siglock, flags);
-	if (!tsk->ptrace && sig == SIGCHLD &&
+	if (!tsk->ptrace && (tsk->flags & PF_USER_WORKER || (sig == SIGCHLD &&
 	    (psig->action[SIGCHLD-1].sa.sa_handler == SIG_IGN ||
-	     (psig->action[SIGCHLD-1].sa.sa_flags & SA_NOCLDWAIT))) {
+	     (psig->action[SIGCHLD-1].sa.sa_flags & SA_NOCLDWAIT))))) {
 		/*
 		 * We are exiting and our parent doesn't care.  POSIX.1
 		 * defines special semantics for setting SIGCHLD to SIG_IGN
-- 
2.25.1