From:   Mike Christie <michael.christie@oracle.com>
To:     geert@linux-m68k.org, vverma@digitalocean.com, hdanton@sina.com,
        hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>,
        Christoph Hellwig <hch@lst.de>
Subject: [PATCH V6 03/10] fork: add USER_WORKER flag to not dup/clone files
Date:   Mon, 29 Nov 2021 13:47:00 -0600
Message-Id: <20211129194707.5863-4-michael.christie@oracle.com>
In-Reply-To: <20211129194707.5863-1-michael.christie@oracle.com>
References: <20211129194707.5863-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kb+4/N0GNVVSTSxFKLjvSXNTOV9hMeWHs43u/FTLRwpWb7fKh6IpC2N1t0xZ?=
 =?us-ascii?Q?Y1yHZBTTbKChSG9wuxsAZOn2IxTXDga6jyOjPOvHS7n643JsW02vh4fZXFL4?=
 =?us-ascii?Q?fXj+RAbHHY3Q+kL3CmYoDLijc3PWXF0RMFL8hWhoExE2DgRiC57NsnAqM2Jc?=
 =?us-ascii?Q?JZ28w748S0yfqh1/ruru/qgTnjnB71FVVJbVLHENe+9SLJBJSG0JtOgXYye0?=
 =?us-ascii?Q?mss+0/p+gAolw3ymQV+xiXXIiezDWcF4QulHp+pVD15QWYxIGj2fG+x58dqn?=
 =?us-ascii?Q?U0JOrmtQQFINeqREjWF2Benv+ycJOX/l63azAwEIzCVdm60xV1K1OCW5xeXn?=
 =?us-ascii?Q?uAegIPtRbrKgNZFUBI2PEZKCpAnc9aE3H/NnTbyNOKZK3bqS/+JVKnHVr1WS?=
 =?us-ascii?Q?DMVjEtvlIjomyO2HnJmO8pyQl9Cu0u+ww42jeol0uNHhQiWmR5PSW5sYIkeH?=
 =?us-ascii?Q?nr3F627KiwgfpFj86Is5ItbFG1VBJIMwIm4k+Y4B2Ue6q46JmT/D9oFAjkUw?=
 =?us-ascii?Q?RU/FCYxgagmMrZi5byRnF0WhOZmLfKGCRJGeboue7g+7ugfj04CXQ/t933UE?=
 =?us-ascii?Q?Hv3rVz2QoI/J2Ff6elrPMY+V/22VVSnRLjAvvx7RbrLlfkLjB3Q+5+6P69r+?=
 =?us-ascii?Q?S7azbwsaf6xXxIh9/G8mYrNaSRDQRvby4HKVX7gz0irVT2xFgrlaOY3qdOAE?=
 =?us-ascii?Q?JMtGBmB9+u887hZ1NaXk7PyrqRovESjR+fMQItYaeYXu23BP+b3+d2x6NALM?=
 =?us-ascii?Q?QgLXykeaXC0YBoMNixQz7GGIsv7385hvoiI8rINjVpcnOjkq2XoZ6dwZXTl2?=
 =?us-ascii?Q?7/fo/CG3woXcfAeld1jzOPYrYbE8Ob0LRfpVIt6KNI0RynnEKeG3n/SPMaGu?=
 =?us-ascii?Q?F2lc6xpMy7TSsI9pKmGNwrO0cGbUgTbI12jRPKuP6yhnDayucwm46YKDQeGy?=
 =?us-ascii?Q?Busumfn4oWQZgq9ZBjAcgRSMizu4xRFeYTk9RvGqXhfwIKaQ+nSSEYpfYlFX?=
 =?us-ascii?Q?kZVYzDBP160cURBuaObvMNWJxaZR3PMaFYfeN0opvfeh9q8QNhhdAi0g9ksO?=
 =?us-ascii?Q?QWfNXDxUTR45s6eSCBKYXvX6z7E2jW87E95UgBnCcfWebHiUOJY6XJp+Ft4q?=
 =?us-ascii?Q?KMAzFFvMFFmjarj8AKz8mAkzAlS0Gkmr7YzwvHy6/1lrXIYo6gOk5pVC6d68?=
 =?us-ascii?Q?nsM+OIMI5u72sRZjkvYzkNhE84niM9m5KfhuqrE8PQWH+ZYrsnDYsoaEg0uL?=
 =?us-ascii?Q?UDkvL+ZPGA2pQ6YPUV8jdsZI6ypVgqHKbzUl9Ls5S1EuVaaq/NkMpJycIw5z?=
 =?us-ascii?Q?EVGUVacMQshMfTOVzWKRNs8ea/tccOhva814vxaK7PG14l3EFwI2PuA2Kija?=
 =?us-ascii?Q?8+k5G4kOs4dNI7OE7jAulEaDY0gcvHBdCeYE81UpbH2VJIhMyTUW5W6doSqn?=
 =?us-ascii?Q?cNgbo0n1Y3h8L2o4pjvjfG0zzwGdoWq2/v+FvNsna5GEN0smaFZqRu4uPSUJ?=
 =?us-ascii?Q?VF5NNbjs5WU8N79MAgGHQoUXGO1g6DPGhqHEJKgvlDaO6PyQqLoSTvDMK3/Q?=
 =?us-ascii?Q?1+AktUX4grzy9sqRV5ys6gRhNuonJVx/pk/2oZp/W2Okf4R47JQDLlATmp7Y?=
 =?us-ascii?Q?JqJlLmUevjKKTAMziQ8oQdNeumU1QXmSkX5ZoMPmDV9KdUTvjDPWwFlYxPuS?=
 =?us-ascii?Q?OYsMHA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73a33d6a-6bb9-4e65-1c86-08d9b3710d37
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 19:47:18.6266
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wbKtTlM2exA8JGXSjtvYs5Gvxw59E6XF2+oOkC0ZgVWIl8ET5UcaMjkWl2zfILDy8EfYpzLkkGmxl4qTqAnPQyoH4jQRFzcavcAkWNAcQbw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1307
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111290092
X-Proofpoint-GUID: hFBxfjlbjvXoNnpIYBJxqeCZqEvuPBl1
X-Proofpoint-ORIG-GUID: hFBxfjlbjvXoNnpIYBJxqeCZqEvuPBl1
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Each vhost device gets a thread that is used to perform IO and management
operations. Instead of a thread that is accessing a device, the thread is
part of the device, so when it calls the user_worker() function added in
the next patch we can't dup or clone the parent's files/FDS because it
would do an extra increment on ourself.

Later, when we do:

Qemu process exits:
        do_exit -> exit_files -> put_files_struct -> close_files

we would leak the device's resources because of that extra refcount
on the fd or file_struct.

This patch adds a no_files option so these worker threads can prevent
taking an extra refcount on themselves.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index b7861cb6a74b..e094502b2eea 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -20,6 +20,7 @@ struct css_set;
 
 #define USER_WORKER		BIT(0)
 #define USER_WORKER_IO		BIT(1)
+#define USER_WORKER_NO_FILES	BIT(2)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 0d278ac26f2f..a47bec00f37c 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1529,7 +1529,8 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk)
 	return 0;
 }
 
-static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
+static int copy_files(unsigned long clone_flags, struct task_struct *tsk,
+		      int no_files)
 {
 	struct files_struct *oldf, *newf;
 	int error = 0;
@@ -1541,6 +1542,11 @@ static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
 	if (!oldf)
 		goto out;
 
+	if (no_files) {
+		tsk->files = NULL;
+		goto out;
+	}
+
 	if (clone_flags & CLONE_FILES) {
 		atomic_inc(&oldf->count);
 		goto out;
@@ -2179,7 +2185,8 @@ static __latent_entropy struct task_struct *copy_process(
 	retval = copy_semundo(clone_flags, p);
 	if (retval)
 		goto bad_fork_cleanup_security;
-	retval = copy_files(clone_flags, p);
+	retval = copy_files(clone_flags, p,
+			    args->worker_flags & USER_WORKER_NO_FILES);
 	if (retval)
 		goto bad_fork_cleanup_semundo;
 	retval = copy_fs(clone_flags, p);
-- 
2.25.1