Message-ID: <1e55a9e5-16fb-c863-e223-df02ad1a0449@oracle.com>
Date:   Mon, 29 Nov 2021 12:58:04 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [BUG] hugetlbfs: Fix issue of preallocation of gigantic pages
 can't work
Content-Language: en-US
To:     Zhenguo Yao <yaozhenguo1@gmail.com>, akpm@linux-foundation.org,
        mlevitsk@redhat.com
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <20211129133803.15653-1-yaozhenguo1@gmail.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <20211129133803.15653-1-yaozhenguo1@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2J1OVFlTXRZMk8waXdNK1JXRndqYUdRTGdpdmFCaFNNdk9jOGlGcWtHankz?=
 =?utf-8?B?empWNFVRUG0rdHQ0aGY1VWVtRE1xZElRYTNFTmt4VUN0WEJyOXhuZHJ1Y2JJ?=
 =?utf-8?B?dWJJNDlQYXN0cFAvSXZQTXU3eTNpSlp0UFdXcnhzT0tQZGJRZkloeDlHK1ov?=
 =?utf-8?B?M1BUaHJOd1VaUFp5VEhya1pEc25WNEt5RnduNGFjM0NzRHdaa2Y5eEtUMUkx?=
 =?utf-8?B?ZEV3R3ZsV1NqdFovNlNrcWNFUnBoaUFOaDlBendmYUowL3BIQlh6WnVpRi9S?=
 =?utf-8?B?ay9UYzR3dDkxY1MzYkk1aGFkNE9EbnVVYkljck43YUttZlQrME1iVTA4Q29k?=
 =?utf-8?B?THZHQjB6VkhnRFBLS3Z6M1dRall0S2NMUmQxUUVkc1BTcnJkampZcFZKR1JO?=
 =?utf-8?B?NkxlNUxYdjBMczJURlltQVFVUXN4TnJFSUFVVEVBTC9NMFhwTmEvd2FxTTBr?=
 =?utf-8?B?MWJ4M29LSDZ1ckkzekdlUmNENkpjM0UyQXNWNk5lQ0J1UVdEZmk0NkhPTGR0?=
 =?utf-8?B?NnlWMy9pRTNTeFY5cjlxeVVlVDNLOWpPd3drUGt2QXk0MmV0ckc3U2lBZlNW?=
 =?utf-8?B?cGlOQ0ZvM1JYd0VMdnhLbVZxby9iQWRYU0p3VGVUNDVVcGRqaUNMNXM5Tjhp?=
 =?utf-8?B?VnR1T3Iza0dMVGtETjZQZG5kbmh1cnlMQW5KTXNzWUpoRG9vamhzT0tySXF2?=
 =?utf-8?B?bXBxZlE3TzNib3ZZbDc3QUUvMXRQMXk5OGk1cW9WenV0VFlpQStTVEFMVzlz?=
 =?utf-8?B?TC9GaFdxZFdZRUNtLzJEalh0TWtTM0pDVkxWRlR0cTlPZWdDWWREcXpkRlI5?=
 =?utf-8?B?MU5yM1NkWWF5VkNxcDliT051eWpUUjJCLzhKYXpLZ0NlUzdOK3NNWmxGTkxO?=
 =?utf-8?B?eGRLdEdTUEVBNCt2eHFFNTQxZUZLdDVHdkV3UjlUdFQ3R0lxTmprbktrZ2k5?=
 =?utf-8?B?MEQ0WW5WWTlVSStjdWVtL1RucjN2ZjB2OFdkU1NuQzNlQXVoT2QvazJscG9m?=
 =?utf-8?B?eTFibjhXRTBWZ0lCY0YyclVFSDc3L0c2R3BkakZraUJpdjFRN28rS1prTXFk?=
 =?utf-8?B?a0RjTFRTd2dNWno3bTkvenptODFEaHhxWnJvdEpZY0hxSGJPR0FCb3ZWMmtv?=
 =?utf-8?B?N3NsTXVGTmR5bWxxbVl5ZTV4aGc2QllBbVhPL0MrdEFuLy95NjVxdDFTaGQ3?=
 =?utf-8?B?bFBGamxFKzdycFE3R3JBS0RYeXQveFdyeWNPeFd1U3VoL0NSNHcyeDQvU2la?=
 =?utf-8?B?SXVCTnhxLzhhYXBjS1JYcStobmZ4aENvczBWL3F6UFA4eVIzQ0VrK3ZzMFBG?=
 =?utf-8?B?eHl6aVN2UUhSaDJiYklNVEY2ZTc3a254RlNHaXNpcnV5alFYNy9oMnJMVW5V?=
 =?utf-8?B?ZzdPdFJBS2xuT0c0QW5MR2xIYk0xY1pjVzNrV0FBYkE3OElJbVBnNXBSQmFT?=
 =?utf-8?B?Wk81VW9kSG92Z3VKUG1rTnE3R2hpNElubkZNcVBOOURMOHdPTjdIK0o0ejNN?=
 =?utf-8?B?aWxWRUFZYVVpdjRKMUg1T1IrQ2kvNG41M3FwZjlNRDBnN2hBQksvL3ptYSsv?=
 =?utf-8?B?eDhhRVB0NjBjOEtoYjc3S29TK21EbmZqZE5xNEtQQ1EwTEg1TXp4YnJYS2cy?=
 =?utf-8?B?TndZSVl2THZBbGpMTXNrMzJ3TnNMYy85V1o0UzM5Q0lWbTBOU3VDUkNxN3Zq?=
 =?utf-8?B?VVNvM2tjZ09kZDk2OHJ1blFRMlNXYmdwbEtwRTloS2xaa2lQVzdsQ1VPeGNl?=
 =?utf-8?B?Sm1vM3JKMEc0a1VHZDJwWUhZd2k5azJSN3FlUWFYUmVFR2JXUHJyTjR5U2Fw?=
 =?utf-8?B?Q05STUtiY1AyTjJNWUtNSVloM2FqYncyWjRVb3MzZmdQZWVWUWl5YTR4ckRW?=
 =?utf-8?B?WUVFeGZ1SC85SFI1ejJGTC9zUFNwcFp0MW14QXhoRXZGU0NySEVDeXFHWWp0?=
 =?utf-8?B?bjA5SVYyd25FYTNndXJYZGZ1MU9WbHB5Mm54TmpxS3dQdks5VVVEK29mMGhG?=
 =?utf-8?B?ODVZWndwZERhNnR0WUNwRGNUSXNsSmNhdWd3VWx2ZWtWci91UHJtWmVEaDlN?=
 =?utf-8?B?dXhGL2ErejZhRFl0U1Q5OTZtSXd6blhkdW13akNIelVIL1Q3TDFIdlZCVlJa?=
 =?utf-8?B?OEp1aktkYXkvUmxJTXhyMWpzYS93MGw3T1NIMW9hTDJlamk3aTNuek5vMjBB?=
 =?utf-8?Q?1Jxy1KS2BrdvbaCGBzu43Sg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8795258-81b9-48d6-5b53-08d9b37af188
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 20:58:07.1782
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NcKJ8Qf2vqor+QMTxa7lwn+IQ3tG8MQRlT67/1q2HZMS1Gl5bSTqtJ+Jj3SRpOAiWhsTZQCH3AttJjcd9LQRdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2949
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111290097
X-Proofpoint-ORIG-GUID: CSvaCX-KgTfa2EPugDO4oYYBNHjPGyeK
X-Proofpoint-GUID: CSvaCX-KgTfa2EPugDO4oYYBNHjPGyeK
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/21 05:38, Zhenguo Yao wrote:
> Preallocation of gigantic pages can't work bacause of commit:b5389086ad7b
> (hugetlbfs: extend the definition of hugepages parameter to support node
> allocation). When nid is NUMA_NO_NODE(-1), alloc_bootmem_huge_page will
> always return without doing allocation. Fix this by adding more check.
> 
> Signed-off-by: Zhenguo Yao <yaozhenguo1@gmail.com>

Thank you,


Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz

> ---
>  mm/hugetlb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 60f9b6a9582e..6d1603387914 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2876,7 +2876,7 @@ int __alloc_bootmem_huge_page(struct hstate *h, int nid)
>  	struct huge_bootmem_page *m = NULL; /* initialize for clang */
>  	int nr_nodes, node;
>  
> -	if (nid >= nr_online_nodes)
> +	if (nid != NUMA_NO_NODE && nid >= nr_online_nodes)
>  		return 0;
>  	/* do node specific alloc */
>  	if (nid != NUMA_NO_NODE) {
>