Subject: Re: [PATCHv3 4/4] x86/sev-es: Use insn_decode_mmio() for MMIO
 implementation
To:     "Kirill A. Shutemov" <kirill@shutemov.name>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Joerg Roedel <jroedel@suse.de>
Cc:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Sean Christopherson <seanjc@google.com>,
        Peter Zijlstra <peterz@infradead.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>
References: <20211103154555.23729-1-kirill.shutemov@linux.intel.com>
 <20211103154555.23729-5-kirill.shutemov@linux.intel.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <acf1be97-dbc9-2165-e57d-278295c1d6de@amd.com>
Date:   Mon, 29 Nov 2021 15:31:52 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211103154555.23729-5-kirill.shutemov@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTZmcms2WlEyNVVudWZuSWc0akM3TXhuOUVRZnJXSTBLbTIweWgxODhSeXV3?=
 =?utf-8?B?eCtocE1oYjNlTytpWHk4aEIwMDdMcERCanVHQzBHcjE5elN2cnpSMlhDWGdR?=
 =?utf-8?B?bDV0bjFKaWw3OVA3bUxINDhEY0QwclhJV1hLc0tPazZzUytqWTh2VDVxRUxN?=
 =?utf-8?B?aVZyTVdubjN0Z1dxOG5MSmJaRFdkcDRSeDVPUFViMUV4b3k4bVJESmhPRGly?=
 =?utf-8?B?MmxIaGFWY2xPY1oveXpQcWZKZUhydVQ4ck1yUUJyRlAyZVNqZE1ZSVBoWHNW?=
 =?utf-8?B?WHRSYVVGbitlWFVxcnY4TTRrMElLK2w3OUNLY1Q0cmthT29FSTVFeWR2WDBY?=
 =?utf-8?B?R3FaYjJxMXJ1YWc4dllCYXpXK3hPY3V2bmtqUk4zSzI5aFU1QjdmWXFDSHdU?=
 =?utf-8?B?Zks2eFgyOHNicFhGdGJWbzFuSWFDZUdqbVlBRXR4VUVKdVZHaVdGWWFLOUpx?=
 =?utf-8?B?OTh4bDZzYmdGUHhwRXNFRTdpa1hPNDhKbU8wcmU4MVEvMFQ0THV1N08rSVNi?=
 =?utf-8?B?OHc4RXZwQ1JZeGNYWHoydkFnTjFPQkpSajB2TmhLSnZZSHBUejI0RStwUlR0?=
 =?utf-8?B?U2pYNkRFc09uLytoeHlHTmZZNURXUFVLMS83U3ppTnpmSGxHUnJiWVFSZk9Z?=
 =?utf-8?B?Skc2dDFlMUZ6YllMUncvalNuamdHc3lleUhRUGFKSTVxdzlaZlRRQzBCVFVv?=
 =?utf-8?B?bDVmUDVUZzJ4WGw4TktnYVk0TE5FZlk2WmJUWTZRMHZ4T2ZUc0VsWjZxK0hI?=
 =?utf-8?B?Z2RMRlRoNnYrZWdRMG1zU3RZQjVBVG5zOEFCeVRkeW1oVjdkWFMySTBtaDJV?=
 =?utf-8?B?eEEvUTJOUlN1MnRlREZ1ZUZGa1FpcTNPMXlZNmptaFNSL0F2TkhEZWExSXVm?=
 =?utf-8?B?WDV6NU9mY2RYK0liS1laZVRITTlKRkdEY0RHdk53L2ZlT0Y4WGFaUHFkZTU0?=
 =?utf-8?B?Z28rVU94RE5GNTk4Q2psRWVMS2xaWTVKQWJvRmozYzNpSUhCMWZmSThBVkJP?=
 =?utf-8?B?ZWN2YncxUWl4N24rd3FVZUNGeEwza094RE1NMG1kSTh5Q3p2YXkyRWRVelM4?=
 =?utf-8?B?UUtzaURFZlp6Y281UHY0Z2JpbVE3WHQ2bFBrMEtHbktzMER4RlpYSi84M3VP?=
 =?utf-8?B?SGZIZjFqOXJ3V29QcUY1OStRSEVGVTQ2dENTZlQ0bUdFeGxLVXdzamwycUpB?=
 =?utf-8?B?aVY4ak5ma3FyNXRDeit4V1NzMUtBaWFianR0REpYc0oySkN2MUNOVUQ3VlZ4?=
 =?utf-8?B?Y2VQTEx0VE1jYkhEVlBBMFF6MU5VcXp0YU0yYkZrUVd2a2pLdHpZUTNVdmc0?=
 =?utf-8?B?WEdZZzF4aFJVTkJpSmVLSzBtcVhZNENPWGx0RnNnMWFuZnR0clNsVjR2cDBp?=
 =?utf-8?B?NVptZ0JCdXB0Nm9Hb2Q5ZWhUTkpZSnVpK2drWE13S3QvMktNYVdpZzROWkV6?=
 =?utf-8?B?UjJvdHVhbDZUZGlPMEJldWhySTc0cmJYczRYUi9VUWRVMFJMSWRWbXNkN0tu?=
 =?utf-8?B?dkFxS0tkYmpxa2JsNUhoQWwxdGhjcUF0cE1INUlMaVdBOHpiaDFXb2Q3MFBJ?=
 =?utf-8?B?ekVBRUdGVVZrV05icDRYemhEOWdtaDVxRVVpQTFtZXVCRVBaV28zRzRxSG5r?=
 =?utf-8?B?WU40TG1QTWszOHpZOTI2N0h2TTRFZGpUNjRjeXMxTnJiYW9aaTR3Rlp6U3V0?=
 =?utf-8?B?YWZORzVVRnl1WitrdmRTK0RLV0NRQjZtNzA2WWY2Z0xIZHVBaDJRWmxKT2Uv?=
 =?utf-8?B?LzBQVGtBQ3FzSTUrM3BLNlBLLysvV1YxSTFVZUFwUnNzNXNFN2tNYjJ5TER2?=
 =?utf-8?B?VCtESjZtRElQRXRwVE5MdGhObEFGUzA0WDd3QnQvaGNHeFZod29UcUNTdkZC?=
 =?utf-8?B?bjZJb2p3eEg5RDJWbi9zdDlmN1RaSDRrSDdPMUwzUUVUQjlvRlQwK1B0YThy?=
 =?utf-8?B?STNRSjVROXpjNG0vcThjU1FDY0Y4cVJzdmwxbFg5M20zbU40NUxpS2lSb0tZ?=
 =?utf-8?B?WXpXbDQrcmlXaUJxTnJCY081VkMwYVBTZ2NUVnpxMnYrWVVYOUl3amhidy9h?=
 =?utf-8?B?d0VQNjBxUVRmQ2YwWkNXTkN6Y3R2TC9jRjk2MEpmckt5QmpaakJURkYvSUVO?=
 =?utf-8?B?YU1BdFo1S1hORW9FbVhDdU9Sai9RbWtTOHEvaHllNkM4U2d2cjhxeEg1Vkcy?=
 =?utf-8?Q?uVHXHbtILY4vz1yaYYpMQfY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01566b2d-860a-4b30-000f-08d9b37faa83
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2021 21:31:55.4995
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tojsDw7+Rzxg+UkF2U+b5uUYIoRhESqSUZpWitVhvNJ1H10t8SSv+3uctWFnsS7rGZrZ4eMiRj8xOF6A34/YQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5358
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/3/21 10:45 AM, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill@shutemov.name>
> 
> Switch SEV implementation to insn_decode_mmio(). The helper is going
> to be used by TDX too.
> 
> No functional changes. It is only build-tested.
> 
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: Joerg Roedel <jroedel@suse.de>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> ---
>   arch/x86/kernel/sev.c | 171 ++++++++++--------------------------------
>   1 file changed, 40 insertions(+), 131 deletions(-)
> 
> diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
> index a6895e440bc3..8fea7ea67c67 100644
> --- a/arch/x86/kernel/sev.c
> +++ b/arch/x86/kernel/sev.c

...

>   		break;
> +	case MMIO_READ_ZERO_EXTEND:
> +		ret = vc_do_mmio(ghcb, ctxt, bytes, true);
> +		if (ret)
> +			break;
> +

Can you keep the "/* Zero extend based on operand size */" comment here 
much like you do below with the sign extended operation below.

Thanks,
Tom

> +		memset(reg_data, 0, insn->opnd_bytes);
> +		memcpy(reg_data, ghcb->shared_buffer, bytes);
> +		break;
> +	case MMIO_READ_SIGN_EXTEND:
> +		ret = vc_do_mmio(ghcb, ctxt, bytes, true);
> +		if (ret)
> +			break;
>   
> -		/* MOVS instruction */
> -	case 0xa4:
> -		bytes = 1;
> -		fallthrough;
> -	case 0xa5:
> -		if (!bytes)
> -			bytes = insn->opnd_bytes;
> +		if (bytes == 1) {
> +			u8 *val = (u8 *)ghcb->shared_buffer;
>   
> -		ret = vc_handle_mmio_movs(ctxt, bytes);
> +			sign_byte = (*val & 0x80) ? 0xff : 0x00;
> +		} else {
> +			u16 *val = (u16 *)ghcb->shared_buffer;
> +
> +			sign_byte = (*val & 0x8000) ? 0xff : 0x00;
> +		}
> +
> +		/* Sign extend based on operand size */
> +		memset(reg_data, sign_byte, insn->opnd_bytes);
> +		memcpy(reg_data, ghcb->shared_buffer, bytes);
>   		break;
> -		/* Two-Byte Opcodes */
> -	case 0x0f:
> -		ret = vc_handle_mmio_twobyte_ops(ghcb, ctxt);
> +	case MMIO_MOVS:
> +		ret = vc_handle_mmio_movs(ctxt, bytes);
>   		break;
>   	default:
>   		ret = ES_UNSUPPORTED;
> +		break;
>   	}
>   
>   	return ret;
>