From:   Jonathan Corbet <corbet@lwn.net>
To:     Akira Yokosawa <akiyks@gmail.com>,
        Joel Colledge <joel.colledge@linbit.com>
Cc:     Philipp Reisner <philipp.reisner@linbit.com>,
        Lars Ellenberg <lars.ellenberg@linbit.com>,
        drbd-dev@lists.linbit.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: admin-guide/blockdev: Remove digraph of
 node-states
In-Reply-To: <7df04f45-8746-e666-1a9d-a998f1ab1f91@gmail.com>
References: <7df04f45-8746-e666-1a9d-a998f1ab1f91@gmail.com>
Date:   Mon, 29 Nov 2021 14:39:33 -0700
Message-ID: <87sfvesktm.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Akira Yokosawa <akiyks@gmail.com> writes:

> While node-states-8.dot has two digraphs, the dot(1) command can
> not properly handle multiple graphs in a DOT file and the
> kernel-doc page at
>
>     https://www.kernel.org/doc/html/latest/admin-guide/blockdev/drbd/figures.html
>
> fails to render the graphs.
>
> It turned out that the digraph of node_states can be removed.
>
> Quote from Joel's reflection:
>
>     On reflection, the digraph node_states can be removed entirely.
>     It is too basic to contain any useful information. In addition
>     it references "ioctl_set_state". The ioctl configuration
>     interface for DRBD has long been removed. In fact, it was never
>     in the upstream version of DRBD.
>
> Remove node_states and rename the DOT file peer_states-8.dot.
>
> Suggested-by: Joel Colledge <joel.colledge@linbit.com>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> Cc: Philipp Reisner <philipp.reisner@linbit.com>
> Cc: Lars Ellenberg <lars.ellenberg@linbit.com>

Applied, thanks.

jon