Date:   Mon, 29 Nov 2021 20:15:48 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Dejin Zheng <zhengdejin5@gmail.com>
Cc:     helgaas@kernel.org, corbet@lwn.net, jarkko.nikula@linux.intel.com,
        andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com,
        rric@kernel.org, bhelgaas@google.com, Sanket.Goswami@amd.com,
        linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/4] i2c: designware: Use pcim_alloc_irq_vectors() to
 allocate IRQ vectors
Message-ID: <YaUm5NBr/Pb/i0Vv@kunai>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Dejin Zheng <zhengdejin5@gmail.com>, helgaas@kernel.org,
        corbet@lwn.net, jarkko.nikula@linux.intel.com,
        andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com,
        rric@kernel.org, bhelgaas@google.com, Sanket.Goswami@amd.com,
        linux-doc@vger.kernel.org, linux-i2c@vger.kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210607153916.1021016-1-zhengdejin5@gmail.com>
 <20210607153916.1021016-4-zhengdejin5@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Lgy2OFLg3jDVJdoD"
Content-Disposition: inline
In-Reply-To: <20210607153916.1021016-4-zhengdejin5@gmail.com>
Precedence: bulk


--Lgy2OFLg3jDVJdoD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 07, 2021 at 11:39:15PM +0800, Dejin Zheng wrote:
> The pcim_alloc_irq_vectors() function, an explicit device-managed version
> of pci_alloc_irq_vectors(). If pcim_enable_device() has been called
> before, then pci_alloc_irq_vectors() is actually a device-managed
> function. It is used here as a device-managed function, So replace it
> with pcim_alloc_irq_vectors(). At the same time, Remove the
> pci_free_irq_vectors() function to simplify the error handling path.
> the freeing resources will take automatically when device is gone.
>=20
> Reviewed-by: Robert Richter <rric@kernel.org>
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>

Dunno the status of this series, but if it ever goes upstream, I am fine
with the I2C changes:

Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C


--Lgy2OFLg3jDVJdoD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmGlJuQACgkQFA3kzBSg
KbZ4Hw/+JuoqxZy2bbiNX8LiPt6gXGhQrly3nu+8bhOe5smWpEmFpLUdQHX/0CPk
QJguw68urbcJH1tvCw2g5KM81McukpSavS9mi74JLSwJWblmWZFxXNBxirkDP9QP
/2c6wBEal8h+0T0inKLYm+uUk3DXmVmVp5iv6ZA9kdlfjVvJEAifcgY6/Ie8mOwc
gIuvTuNtRc6YbneDnLbFjII1sgLepkASr4paZ/KgUwVULdqjm8Q6CHzg9OmHWjwF
2oEA7CtIO30pe6Ky6tbVOdcxjBhxYC4h66erAMnqO7Wk3QLS4obEowuX1/i5uAWT
FOO7Az8tKuR+lMNNh3AfTJbkeNNs+wcAb3L2SvIy14braTddeNe5FyzSuC+9QM7X
x5wIFkXz/SbB1eJt/X4KVCadgKZXxK6NMsSmPuktO5+EYxSySZMJQgtWHcC9aP7E
4n4gt/sINW3XkKnNv19vHBuXpn7EPkM8h+t/tK/3SHWDYZzRCRLA55lebYvmcqHs
2BlPZ2cu/WbOm34KeO5y9GFmpKo5pO2TlonWrSVE6T9WnJ01yXd1iPvj4pBnCg6E
6ttwzMfrZkPn0piefq6nRnUutg2jHK/re6ylAMayBOfr9C0JlEfUELxgETyXmbn0
ASU8ebTBdSUWSdi6dyEkCUn8XFEzuojFeUBEr9G4p3ycG07BF00=
=rRir
-----END PGP SIGNATURE-----

--Lgy2OFLg3jDVJdoD--