Date:   Mon, 29 Nov 2021 10:58:03 -0700
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Tanmay Shah <tanmay.shah@xilinx.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Ben Levinsky <ben.levinsky@xilinx.com>,
        Bill Mills <bill.mills@linaro.org>,
        Sergei Korneichuk <sergei.korneichuk@xilinx.com>,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/6] arm64: dts: xilinx: zynqmp: Add RPU subsystem
 device node
Message-ID: <20211129175803.GB676889@p14s>
References: <20211123062050.1442712-1-tanmay.shah@xilinx.com>
 <20211123062050.1442712-3-tanmay.shah@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211123062050.1442712-3-tanmay.shah@xilinx.com>
Precedence: bulk

On Mon, Nov 22, 2021 at 10:20:46PM -0800, Tanmay Shah wrote:
> RPU subsystem can be configured in cluster-mode or split mode.
> Also each r5 core has separate power domains.
> 
> Signed-off-by: Tanmay Shah <tanmay.shah@xilinx.com>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 28dccb891a53..f4fb98ccb1b5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -654,6 +654,23 @@ qspi: spi@ff0f0000 {
>  			power-domains = <&zynqmp_firmware PD_QSPI>;
>  		};
>  
> +		r5fss: r5fss@ff9a0000 {
> +			compatible = "xlnx,zynqmp-r5fss";
> +			xlnx,cluster-mode = <1>;
> +
> +                        reg = <0x0 0Xff9a0000 0x0 0x228>;

This line is giving me an obvious checkpatch warning.  Please make sure you run
checkpatch.pl before sending out a patchset.

> +
> +			r5f_core0: r5f-0 {
> +				compatible = "xlnx,zynqmp-r5f";
> +				power-domains = <&zynqmp_firmware PD_RPU_0>;
> +			};
> +
> +			r5f_core1: r5f-1 {
> +				compatible = "xlnx,zynqmp-r5f";
> +				power-domains = <&zynqmp_firmware PD_RPU_1>;
> +			};
> +		};
> +
>  		psgtr: phy@fd400000 {
>  			compatible = "xlnx,zynqmp-psgtr-v1.1";
>  			status = "disabled";
> -- 
> 2.25.1
>