Date:   Mon, 29 Nov 2021 10:02:20 -0800
From:   Matthias Kaehlcke <mka@chromium.org>
To:     Sandeep Maheswaram <quic_c_sanm@quicinc.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Doug Anderson <dianders@chromium.org>,
        devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com,
        quic_ppratap@quicinc.com
Subject: Re: [PATCH 1/2] arm64: qcom: sc7280: Remove USB2 controller and phy
 nodes from common dtsi
Message-ID: <YaUVrDw9j0Aks/pn@google.com>
References: <1637837815-8532-1-git-send-email-quic_c_sanm@quicinc.com>
 <1637837815-8532-2-git-send-email-quic_c_sanm@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1637837815-8532-2-git-send-email-quic_c_sanm@quicinc.com>
Precedence: bulk

On Thu, Nov 25, 2021 at 04:26:54PM +0530, Sandeep Maheswaram wrote:
> Remove USB2 controller and phy nodes from common dtsi file as it is
> required only for SKU1 board.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>

A series shouldn't break things if it is only applied partially (in order). In
this case the USB2 controller wouldn't work on the SKU1 board if only this patch
is applied. It should be squashed with patch 2 of this series ("arm64: qcom:
sc7280: Add USB2 controller and phy nodes for SKU1 board").

Also doing the move in a single patch instead of two separate patches for remove
and add makes it easier to review the latter part, since it's evident from the
patch itself that it's just a move.