Sender: Tejun Heo <htejun@gmail.com>
Date:   Mon, 29 Nov 2021 07:39:49 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Wei Yang <richard.weiyang@gmail.com>
Cc:     lizefan.x@bytedance.com, hannes@cmpxchg.org,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] cgroup: get the wrong css for css_alloc() during
 cgroup_init_subsys()
Message-ID: <YaUQZZbFDDOpwHYY@slm.duckdns.org>
References: <20211127145919.31159-1-richard.weiyang@gmail.com>
 <20211127145919.31159-2-richard.weiyang@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211127145919.31159-2-richard.weiyang@gmail.com>
Precedence: bulk

On Sat, Nov 27, 2021 at 02:59:19PM +0000, Wei Yang wrote:
> css_alloc() needs the parent css, while cgroup_css() gets current
> cgropu's css. So we are getting the wrong css during
> cgroup_init_subsys().
> 
> Fortunately, cgrp_dfl_root.cgrp's css is not set yet, so the value we
> pass to css_alloc() doesn't harm to the system.
> 
> Let's pass NULL directly during init, since we know there is no parent
> yet.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>

Applied to cgroup/for-5.17 w/ minor description adjustment.

Thanks.

-- 
tejun