Date:   Tue, 30 Nov 2021 01:37:20 +0200
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Stefan Berger <stefanb@linux.ibm.com>
Cc:     Stefan Berger <stefanb@linux.vnet.ibm.com>,
        linux-integrity@vger.kernel.org, peterhuewe@gmx.de,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        skhan@linuxfoundation.org
Subject: Re: [PATCH v3 1/3] selftests: tpm2: Probe for available PCR bank
Message-ID: <YaVkMF8aKuef4K48@iki.fi>
References: <20211125003827.1360432-1-stefanb@linux.vnet.ibm.com>
 <20211125003827.1360432-2-stefanb@linux.vnet.ibm.com>
 <97ddf0f23592b74e7647e3c9b36b37553c594c82.camel@kernel.org>
 <2557c1e2-b0fa-8729-0eb0-6ae68ee6f653@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2557c1e2-b0fa-8729-0eb0-6ae68ee6f653@linux.ibm.com>
Precedence: bulk

On Fri, Nov 26, 2021 at 10:43:42PM -0500, Stefan Berger wrote:
> 
> On 11/26/21 19:29, Jarkko Sakkinen wrote:
> > On Wed, 2021-11-24 at 19:38 -0500, Stefan Berger wrote:
> > > From: Stefan Berger <stefanb@linux.ibm.com>
> > > 
> > > Probe for an available PCR bank to accommodate devices that do not have a
> > What does "probing for an vailable PCR bank" even mean?
> 
> Checking ? Testing ? What's the difference to those words?

This would an exact description:

"Some devices do not have SHA1 bank available. Try to use SHA256 as a
fallback when this occurs."

It does not leave any open territory what the patch does. It does exactly
this, not more or less.

/Jarkko