Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D329C433EF for ; Tue, 30 Nov 2021 01:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236808AbhK3BoL (ORCPT ); Mon, 29 Nov 2021 20:44:11 -0500 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:55756 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229779AbhK3BoI (ORCPT ); Mon, 29 Nov 2021 20:44:08 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R921e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UyoPEMz_1638236446; Received: from 30.21.164.33(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0UyoPEMz_1638236446) by smtp.aliyun-inc.com(127.0.0.1); Tue, 30 Nov 2021 09:40:47 +0800 Message-ID: Date: Tue, 30 Nov 2021 09:41:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [BUG] hugetlbfs: Fix issue of preallocation of gigantic pages can't work To: Zhenguo Yao , mike.kravetz@oracle.com, akpm@linux-foundation.org, mlevitsk@redhat.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20211129133803.15653-1-yaozhenguo1@gmail.com> From: Baolin Wang In-Reply-To: <20211129133803.15653-1-yaozhenguo1@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2021/11/29 21:38, Zhenguo Yao wrote: > Preallocation of gigantic pages can't work bacause of commit:b5389086ad7b > (hugetlbfs: extend the definition of hugepages parameter to support node > allocation). When nid is NUMA_NO_NODE(-1), alloc_bootmem_huge_page will > always return without doing allocation. Fix this by adding more check. > > Signed-off-by: Zhenguo Yao You should add a fixes tag, otherwise LGTM. Reviewed-by: Baolin Wang Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation")