Message-ID: <b8ee3be7-c0f6-d1fd-1ba1-13066b329ee3@os.amperecomputing.com>
Date:   Tue, 30 Nov 2021 09:08:05 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: [PATCH v5 1/3] i2c: aspeed: Add slave_enable() to toggle slave
 mode
Content-Language: en-US
To:     Wolfram Sang <wsa@kernel.org>, Corey Minyard <minyard@acm.org>,
        Rob Herring <robh+dt@kernel.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Brendan Higgins <brendanhiggins@google.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        openipmi-developer@lists.sourceforge.net,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
References: <20210714033833.11640-1-quan@os.amperecomputing.com>
 <20210714033833.11640-2-quan@os.amperecomputing.com>
 <YRTQP9sX0hkTJMTx@shikoro> <YaUoeFZn6zLNoGed@kunai>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <YaUoeFZn6zLNoGed@kunai>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aG5ZOTVaN2lzS2tUL081Y2R4cDZsWFVsWW1CQys4TmgzdCtNYlBlZE1LSC9L?=
 =?utf-8?B?WWpqL2VsOHlFZngrZU4wdU50QW9vREZJUjcwaUt6YzMxYkZmUWoxZVRiNE8y?=
 =?utf-8?B?MlZEcU5OOUw3TWFhbUo1V2t6cThJZTJPQTZKMmR5U2ZmNnBnLzZpWE92L21K?=
 =?utf-8?B?WW5tQTJGM0I0RVk0SDhkTUdhUVFxcHNjR3hCWU5nZmVpeFpidTVGd1dPTEVF?=
 =?utf-8?B?MkNtamREVEo1YU1XVzBZWFZnb09mM2M1NXlPanBORWFhM0tOSFpsUTdFSits?=
 =?utf-8?B?NytBU2doeDgzYXpTTDdDUDYrZlhwSEpoNDBCUVFEdThtMUJNdktzSy9uNUdv?=
 =?utf-8?B?OU1oLzM1U2wwYy9IaFZ4Q3FFQWI5REEwVGwxblNxMFJHWUdLR21sd3lHZEFu?=
 =?utf-8?B?QVdldDYyMFBucW8yaUpoaE4zSnZ5WWpaYWQrR2NYcWdrWmFZTG9RQVJ5MnN1?=
 =?utf-8?B?VzdPcEZtbkNLOGt3OTMvOGIxM2oyM1VDeWZQYmhuRGpETHhhL25YOFlRV2VJ?=
 =?utf-8?B?YVlZM1duRkJ2WWxUT0pKWDBpSUZPc3BROG1ra1ZvcTF5WndUR0hsMTJiVHFp?=
 =?utf-8?B?YXNRWjlPd0NJV3JkQzRuTGpsQjFqellZK01URXo1djgwWGlMa0tSZkR4YmMw?=
 =?utf-8?B?MFZBT0c2RkRhdnVFbGd3S2pJMjFVRUhVbnlGMXluOWl5V3VFWkgrdHZSclBQ?=
 =?utf-8?B?WmxGNUJ6MUUwMXUyQXpLSGp1dUhYcVBCRWx3SGVWbWpyUG1Ydmt5dHhPbUM1?=
 =?utf-8?B?cmhmemRZMktqOVNCZnRKSzF2TmJpVVdIYmdoOTJpNjNHZm9yOVBsNFpmZktJ?=
 =?utf-8?B?QXdyakJFaTRRRVYraGVVbWtyNTByS1JJUUtWSndhQkEybmRLOXFFeGY2MGpj?=
 =?utf-8?B?bVlyUkZ4elVydVNhOHc3TW9hRzFidS9MaUlvZHMwc3owOWZEUmVKeDJKa0hj?=
 =?utf-8?B?T1lVOEZOa2ljdFhGZW1KK1Q4MkdPTGNJK1VockVja2xJMnJubkhNejl5aTN5?=
 =?utf-8?B?cDIrNXVjSGxEL3BCQXljODZsUUF0NnBMZkU5ZWd0K1BnbjhHQXREcnFNVlp5?=
 =?utf-8?B?Zy9iaFNHdzFiZnBUejRQQnlrQWM3NUs3VjYrWlJnQ2FiY0xIQjFVUDcyRkRq?=
 =?utf-8?B?bXJyeFovRnI2VGp1QXQwR0tzVDIzd1ZPUmJETXBaY29iVjlFaEZEZy9VUWFB?=
 =?utf-8?B?dngxSUIvMit1V3FUQndUdzlGSHN3Y1hiZjZQQWhnK1hIOUR5VG5WTm9ncUNF?=
 =?utf-8?B?UlhRNVZmRXBCU2wwNGdvMlQ0WENKRFJnc1dGYVc1TmtybjZocGNwV1dLVDkx?=
 =?utf-8?B?Wk9YR1luNnBEeGdFZkViLzBld3RMZHZTeXhLZDRLdkFrNnpNaElLVnc3L2JE?=
 =?utf-8?B?dnhueGpockMwbWpoN2RHVjNMM3RtUmtSNHc3WEI0bmo3ZHJMLzZ2WTlmdnlG?=
 =?utf-8?B?OUJ4NTc5TmlsQmtVWmttSDB6SVlxaXZJNHNyNDkvRkRCNmU2Vk8walQwN1ZT?=
 =?utf-8?B?cVJDc2F3S1VXamREM1RoOU9kbUxuUG01ZXdMM25rcUd3aGI4YnlNaFBaSVMw?=
 =?utf-8?B?N1ZTS1RsTzl4L0pFbmoyVHExbUlTMVhIeXlxVlJmcHlrcUZldU5PblZVK2pl?=
 =?utf-8?B?ZHpINUpUNER4cFFtVGxySTRXMFJ4ei9uQWNEd0xJeHI3TXpUZ1VFR084cklp?=
 =?utf-8?B?Y1RQc0g2V25iVUVWYksyU1RTWml2amFMYmpySXQzOHE4NHNFRERQbXJWdEVF?=
 =?utf-8?B?NEJWenlYc3gxM2pyTk44TXk3T2NpTnlEWjRJRG53UmNzVnNJNlpSN3pTVk45?=
 =?utf-8?B?d3pCeDZDQTNBRGc1R200REttekswd3N1V0xjTENkSWtxZTF3VUJKbGRxeWo4?=
 =?utf-8?B?d2ZwbnVWYklGVjZzMEk2MGdMNXI1UDl4MkQzU0NUZmhxS0E1VG5YemRlS1Zh?=
 =?utf-8?B?UTVsQ0txS0Zsbi9QY3J2NVZQVEVFbEI4bE5MbkdIa2NlVjFsM25zbmZ3UkNs?=
 =?utf-8?B?blRrUXhGMjRPSFNXd2pscGxBckxqMVZqbkdVcGVYRmM0SkNVRTU1bXBGTkxh?=
 =?utf-8?B?QXZLVU95WXRWYnkrdCt4SmZQQTlMVzhJWTVkVjFTcnFaRXU0NDZPMnMraXl6?=
 =?utf-8?B?bTlWaVhRMjR6bUc4U0tQd01ZUkQ5NzVvNThJNU53V203VEM5NTN6V3FXVWkw?=
 =?utf-8?B?a0FJOWhheXBPY2JBeXB5UnM3QUVQVzA4RTBubUFIS1NvcXBDSFg4bUE4YWZk?=
 =?utf-8?B?eUVJdXdqNUZ2U1R5eUpBNGZQTlFBPT0=?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bddcdc04-602b-4e20-b921-08d9b3a64d8b
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 02:08:30.1619
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gvPONNqI5u0XZGmko1FWcKBIJNX7HCGnFGpI3aZhYUkgqoBgsqzXnKdQTIen706cl5Gvg0KiSRT6VGuwBJQYMKFl+GXZFmfo01UM7Z5Cfec=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR01MB4277
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 30/11/2021 02:22, Wolfram Sang wrote:
> Hi,
> 
> I still wonder if we can't get the SSIF BMC driver upstream...
> 

Thanks Wolfram to help bring this up,

This driver was tested with Aspeed ast2500 and we have tried many way to 
avoid using slave_enable() to toggle slave mode but there is no progress.
Our expectation is still to have this driver upstream'ed and I'm 
thinking about testing this driver on other HW and re-post the driver.

>> @all: Plus, I neither like the API (because it doesn't look generic to
>> me but mostly handling one issue needed here) nor do I fully understand
>> the use case. Normally, when a read is requested and the backend needs
>> time to deliver the data, the hardware should stretch the SCL clock
>> until some data register is finally written to. If it doesn't do it for
>> whatever reason, this is a quirky hardware in my book and needs handling
>> in the driver only. So, what is special with this HW? Can't we solve it
>> differently?
> 
> ... for that, it would be great if somebody could answer my questions
> here :)
> 

I have to admit that you are all right with the above comments. The fact 
is we still not be able to find any way to solve this differently. We 
don't own this HW and dont know what happen on this particular issue. 
The SCL clock stretching on this HW does not work as expected and the 
slave_enable() is the only solution for now. I hope if someone could 
help with the issue as well.

Best regards,
- Quan