MIME-Version: 1.0
References: <20211129133803.15653-1-yaozhenguo1@gmail.com>
In-Reply-To: <20211129133803.15653-1-yaozhenguo1@gmail.com>
From:   Muchun Song <songmuchun@bytedance.com>
Date:   Tue, 30 Nov 2021 10:33:35 +0800
Message-ID: <CAMZfGtUxihm0_G6P2L=Vcf97p3kHj=X+MCRUOBb_M4-H7LHdQQ@mail.gmail.com>
Subject: Re: [BUG] hugetlbfs: Fix issue of preallocation of gigantic pages
 can't work
To:     Zhenguo Yao <yaozhenguo1@gmail.com>
Cc:     Mike Kravetz <mike.kravetz@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>, mlevitsk@redhat.com,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 29, 2021 at 11:27 PM Zhenguo Yao <yaozhenguo1@gmail.com> wrote:
>
> Preallocation of gigantic pages can't work bacause of commit:b5389086ad7b
> (hugetlbfs: extend the definition of hugepages parameter to support node
> allocation). When nid is NUMA_NO_NODE(-1), alloc_bootmem_huge_page will
> always return without doing allocation. Fix this by adding more check.
>
> Signed-off-by: Zhenguo Yao <yaozhenguo1@gmail.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.