To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
        Nilesh Javali <njavali@marvell.com>,
        Manish Rangankar <mrangankar@marvell.com>,
        GR-QLogic-Storage-Upstream@marvell.com (supporter:QLOGIC QL41xxx ISCSI
        DRIVER), "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org (open list:QLOGIC QL41xxx ISCSI DRIVER)
Subject: Re: [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1fsrez4cn.fsf@ca-mkp.ca.oracle.com>
References: <20211126201708.27140-1-f.fainelli@gmail.com>
        <20211126201708.27140-3-f.fainelli@gmail.com>
Date:   Mon, 29 Nov 2021 22:59:58 -0500
In-Reply-To: <20211126201708.27140-3-f.fainelli@gmail.com> (Florian Fainelli's
        message of "Fri, 26 Nov 2021 12:17:08 -0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TQwy708Lxm1WI3Yy+Eg87QkVCvqSU5Pu2weNowt7eg7Qzu/LqRcHI9oUwb8q?=
 =?us-ascii?Q?EEzJIWDXN7XUte3GriFr8QA8goCVDC0UdA8/m3QAJtam3iU4PJHgEvqb04pk?=
 =?us-ascii?Q?31RflUr22hmIb+HVcUpDFh30I5xicFyctm+rKJXCK1g54OgHCrBiuzcu7bre?=
 =?us-ascii?Q?49r16QVDxMGkqHMiknuR7yK4yQgnZgYRIK4cCaG/XYE6Oga3AX/qoApJOyWB?=
 =?us-ascii?Q?iAy5bKvC9RnkhUPyi4QQRby0KQlWbiogNxGfBDj00g+HVTarsOe6wLP1dM55?=
 =?us-ascii?Q?OXj4jaNx1QehECqBm8MfdRo7vJgMInozoa7UbSbLUdyWLAWjS25Zpf25wQ0+?=
 =?us-ascii?Q?Fwu4PNfU/PMQ64KqQt8OJTI6MGOZpQC6G2tRFQ1+uOw2qi6siQzO6PsoShDz?=
 =?us-ascii?Q?hfpCitvuS6YS/TawDLrVePuegaW6ERcAd9KCdqg2qoviW5A6mc9b6MRSXo7g?=
 =?us-ascii?Q?quHQ4jN0LGbilnTY1M9BR8zv8Wn7QuoXNjmkx1HoG15OYMr+zuf3S2lKjilp?=
 =?us-ascii?Q?VGAMtpUtMUVKRjjfI9/OA9J+DOhOiifA1iWEgBjuBLdjCEBx7Clx2gxaKltt?=
 =?us-ascii?Q?YbYuXM8sphFU6qBhsHI/T4wAfAZ0uMhNJ4/lhpNDiAXeR39xtzergYPSh8bx?=
 =?us-ascii?Q?26PTOJuwcNjbkMC21E2xih3765yWZBZUujo3cZd9Sg2PNSSUerC9sK0yIhCV?=
 =?us-ascii?Q?QW7mMXa7rWzm1G/BhwzW2YsOfj6zI0fuWlawT0lKWYR/JaEAVNZ2Q3YE6NVl?=
 =?us-ascii?Q?BhAcmcDnBketgFXlfCCLK5T0C2dcHiT6LUJR9PpcYMZoLBwUs9SVtdRhaA3y?=
 =?us-ascii?Q?qVz68brE+alYF5tewNy6MOwSDUbaQ2qIcc4ZBSkFsW66jQlzG41u7BU019hs?=
 =?us-ascii?Q?2wFZMvThVDHCVh6RDlc4Ao55rMmWR26Lt44SZQDREWafGvU25RaTlAuwb+OU?=
 =?us-ascii?Q?cUmmnpEFitzjPSBM+aoaErszZ/TAh37/bNe7PeV5Ys5nca1Tqi7YMcwwTWAT?=
 =?us-ascii?Q?88y8zRu/OHw9D89rXmRnl8gMm2BBPhcb6CXEpcDJ2S/fE8zK7OqSjAhD3UIF?=
 =?us-ascii?Q?P4wff2veF3qMlRJw2yaWCmL3bZ7HgPwFeO/PZ1PYwWlz0WIX3N3YY/euov9z?=
 =?us-ascii?Q?uipUuRUJemF5TzjV+8TnuvDt/fuP6rLZXuzMl4pfNkpI4dLSWJHTt6+GyKUc?=
 =?us-ascii?Q?uIuwfsvol4Vs3uEledsUGjSM6yyQVeqQmJD+gJogNDnjeWXJZ+O+yXoLnCRL?=
 =?us-ascii?Q?FHvPvyr7DLBdrGuE4Iaz4M2D+cWLa3iHW5xMLFh6MyxCjjUbmDuSzBBPN0qJ?=
 =?us-ascii?Q?rjyQWiQpCXQFPtwdZIpQnUYo+LxG2KVtQ36LXVjzmudO77hOZOWQ1m4nwDNT?=
 =?us-ascii?Q?r8KsgiOZs4ChCuS9cD46KHHdWlgCqAkUjML5u3MwFNFOKCHdd1imhmpcRcYp?=
 =?us-ascii?Q?e2hXamlrzsAwf7AITEYYtiQ4/giDjA1SbVG2j+jl1/0qMm7xHD+tO7FbWcwU?=
 =?us-ascii?Q?+2ZFy0AZT0o+b32P674Dj42OzY7geL/I+xevBX5D1qaDpDmJE8iRuJx5Cwby?=
 =?us-ascii?Q?YH5+FQklPui6jHa++Ef1PZS2/oay2gHtefRF2rBkPLFjGKYI5QVz3N26XV/M?=
 =?us-ascii?Q?0cpcpKPF6fPncGgumEvwXpqA35+YKqeGbpib2ewlR+5JBlz1T0nO5P74hz6v?=
 =?us-ascii?Q?m78kyw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2aa79e1-a988-4e7d-ba68-08d9b3b5e13c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 04:00:00.0275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1UzNpPNZelEy3DgLPacsPloAsJsGZdPxwK4gDe/WwZfrvfy6PPvczmOYLbwV8g0/AXIW/MCm+Hxzx9TGizwMfyFGhmsMEtbWNNxzZ1WXDug=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5732
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0
 suspectscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111300022
X-Proofpoint-ORIG-GUID: ZSS2CPQTc9FyRSUvObHRO5BwPbp-iJBh
X-Proofpoint-GUID: ZSS2CPQTc9FyRSUvObHRO5BwPbp-iJBh
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Florian,

> The format used for formatting SYSFS_FLAG_FW_SEL_BOOT creates the
> following warning:
>
> drivers/scsi/qedi/qedi_main.c:2259:35: warning: format specifies type
> 'char' but the argument has type 'int' [-Wformat]
>                    rc = snprintf(buf, 3, "%hhd\n",
> SYSFS_FLAG_FW_SEL_BOOT);
>
> Fix this to cast the constant as an u8 since the intention is to print
> it via sysfs as a byte.

The other occurrences of SYSFS_FLAG_FW_SEL_BOOT use "%d". Since %hh is
deprecated I suggest you just fix the snprintf().

-- 
Martin K. Petersen	Oracle Linux Engineering