To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
        Nilesh Javali <njavali@marvell.com>,
        Manish Rangankar <mrangankar@marvell.com>,
        "supporter:QLOGIC QL41xxx ISCSI DRIVER" 
        <GR-QLogic-Storage-Upstream@marvell.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "open list:QLOGIC QL41xxx ISCSI DRIVER" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1r1ayxoj4.fsf@ca-mkp.ca.oracle.com>
References: <20211126201708.27140-1-f.fainelli@gmail.com>
        <20211126201708.27140-3-f.fainelli@gmail.com>
        <yq1fsrez4cn.fsf@ca-mkp.ca.oracle.com>
        <4a61707b-a82b-4950-88b3-5f268d9fc92c@gmail.com>
Date:   Mon, 29 Nov 2021 23:25:21 -0500
In-Reply-To: <4a61707b-a82b-4950-88b3-5f268d9fc92c@gmail.com> (Florian
        Fainelli's message of "Mon, 29 Nov 2021 20:09:55 -0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NXIboFPSTQxY7aEczZy92/fWTNRQ4j6h6Q0ZMv1ZAaUjRQTbmx9R8kW7FYjC?=
 =?us-ascii?Q?I/PuPamPAQI76sFbcus9446GeUV7ghRDia2TF89e6ZudovroiLPeATX9nEuW?=
 =?us-ascii?Q?lfl11NtLmnBi6ctqkPZSXcCsEtO0IcznitQtEyDyFAD57xc1b8cdFy20lNF1?=
 =?us-ascii?Q?P0pEkVCNEA6Te7ykOMLn9QYu0/XFfVnYkrRkE4XwWaOUJzyeBqOwmD9F1/Vh?=
 =?us-ascii?Q?lDyD+n0/rvEeZxR4WEAQ+LvEDK2FYQtSQqlM6SilI0Yif9Ej3pyjpd3CCmVo?=
 =?us-ascii?Q?7U13+M1t1RTLJIfYkZBh7hNM02nXVvxINYDgjHvJyubcyqT5aCcsHIwIbwTh?=
 =?us-ascii?Q?20clnxIiogvtUc1MiJwid0FjoF++sKCVg9js/Otyf7hKRxQff86sQB9bSXgg?=
 =?us-ascii?Q?u6HHXr98+ZpOCUulgRxJ8bGAVvh1Z2MhgxBdZR6aD6eKFSxY3OpSEdsHR2YJ?=
 =?us-ascii?Q?HzszCKxxy8qaKko7YGapfk53Aaz3/6VWA3dTjlhVCjDp6WwXviIUBu50xeBp?=
 =?us-ascii?Q?oH5+J1Ys+0LdYzBd0rD4qr1fsBEusdv1XT9KDKvR4Ik9LRzaf58qOHiTA+0I?=
 =?us-ascii?Q?shIz8pQjXIs3tv6ATDXPLlp3OtWt5mlX17ZyvTBMhkWqsVv0Bl01SJAjly+6?=
 =?us-ascii?Q?WbPe1EcI1C2IA5fs8gkCLNNtcZbKJOH/5yYMJRVJj+bO4IWk7PNMgTO+bDKL?=
 =?us-ascii?Q?QOT8v1YoeAPOAUiw/xwJK2jQ9COjO9KDG/dzLHJMduYcCH00iyzs0ePRDx73?=
 =?us-ascii?Q?8pD3sT17DkPP6ELOAW07V1yTq7UGvANisqOKu/nIdGnMoDhromAAToWlmQJg?=
 =?us-ascii?Q?L41qzpdysoYwOpRWUhodwRfWvn1bCTNnYWBXIgTJWYBXlAbEJoGs1GAN+o0v?=
 =?us-ascii?Q?yWlg0JAcubRdhLg4KJkNOPecF+Z/bHAmmTDhBpWKpj6/trepW5K4f4Q6PJ+n?=
 =?us-ascii?Q?m3kSUa55aeHYe68Tu7M9tX43zvYNl/qgQ2QJ3fA+l1LZh7v0YmbqCW0FXd0o?=
 =?us-ascii?Q?mcrmCHr7A0QzwkELxI1dIN56Cp1ik8JYxEo5J/QeeJvdHfPABAHQhOgUU+8r?=
 =?us-ascii?Q?vM+EdYWLcrmC0uQkfOo1hB90vyCuIFSZTx5gjGyl26HzH2CwqplDZaqeeIu5?=
 =?us-ascii?Q?L86PtT4Yh7lN1d/0paJmCvCn3zi8zu0/Y4ii5XP3RNuwYWbviR6y7PoLA0Y5?=
 =?us-ascii?Q?x9THsMYDSwfjKI5e5aHlGPaIv/HY8HnczWK82nZTHGfhhB26l6Jy+5QtopAc?=
 =?us-ascii?Q?rf0qhhBnm9R2lhOoln8lxKvczx1SDDPbv1aYuOPDYGbxCB5CjUI2qHzu1Iqk?=
 =?us-ascii?Q?NJ/V5psiTGumQH7opZ/lvr7NPulBQTs+B1rXqtIFxyCgeJr/iE85nbzyQI44?=
 =?us-ascii?Q?4ZK1wyD/0q75JhJh7BVupbjo2D0hb8aH1QJVkWdeyuqL4017qVKs6IZdofal?=
 =?us-ascii?Q?FRj4UFpO4pUMk/nhi9Ve3uK2kDnUSMUUJRQMV2m3NgezZnvcRW/yietDt9T+?=
 =?us-ascii?Q?MDYyEG/pZsrfTDTbCDCuP/czQC/CHH4xsGFmiyFlXZZNv/jicOBRUM2WtV8Z?=
 =?us-ascii?Q?etUWOId9WLiIEJ1juJyMKMYIQdaQQ8PeFQMnm8sNdD48Xw6zWNzLHxbIsrPb?=
 =?us-ascii?Q?qQaFB30ttmOQzzOtGibAJVSAq8aVgS1dcSc93Tgud8gbfV4Vntu/sJpa5eh7?=
 =?us-ascii?Q?F+3SxQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc55b438-8bb0-4791-8fc9-08d9b3b96d28
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2021 04:25:23.2288
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r7KwoJKn7wYovy69AOZ/No54w5N0eC2bDrsTY4+7ny3HOk7ihoSZANow6gnCjooUQCQTKepsU+BL0b+0ed10Rh0tDTyBLgH2O8uZ/xHaSgQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5818
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10183 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2111300025
X-Proofpoint-GUID: WNY1cFjW2puHsR1mNh_Bf8dXUKtZqfsv
X-Proofpoint-ORIG-GUID: WNY1cFjW2puHsR1mNh_Bf8dXUKtZqfsv
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Florian,

>> The other occurrences of SYSFS_FLAG_FW_SEL_BOOT use "%d". Since %hh
>> is deprecated I suggest you just fix the snprintf().
>
> That was what v1 did here:
>
> https://lkml.org/lkml/2021/11/26/9
>
> however Manish seemed to want that flag to be printed as a byte I am
> fine either way.

Not sure I understand the concern since this is a constant which will
always be "2".

But if you must cast, do it in snprintf() and not in the macro
definition. checkpatch also complains about the cast.

I would prefer for all instances of this to be consistent, though. So
whatever you do, please also fix qla4xxx.

-- 
Martin K. Petersen	Oracle Linux Engineering